From: Francisco Jerez <currojerez@riseup.net>
To: Jordan Justen <jordan.l.justen@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Add Haswell CS GPR registers to whitelist
Date: Tue, 08 Mar 2016 14:06:39 -0800 [thread overview]
Message-ID: <87fuw0fwuo.fsf@riseup.net> (raw)
In-Reply-To: <1457335830-30923-5-git-send-email-jordan.l.justen@intel.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 2284 bytes --]
Jordan Justen <jordan.l.justen@intel.com> writes:
> This is needed for the Mesa Vulkan driver on Haswell.
>
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
> ---
> drivers/gpu/drm/i915/i915_cmd_parser.c | 16 ++++++++++++++++
> drivers/gpu/drm/i915/i915_reg.h | 4 ++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c b/drivers/gpu/drm/i915/i915_cmd_parser.c
> index ba01836..e1608da 100644
> --- a/drivers/gpu/drm/i915/i915_cmd_parser.c
> +++ b/drivers/gpu/drm/i915/i915_cmd_parser.c
> @@ -475,6 +475,22 @@ static const struct drm_i915_reg_descriptor gen7_render_regs[] = {
> };
>
> static const struct drm_i915_reg_descriptor hsw_render_regs[] = {
> + REG64_IDX(HSW_CS_GPR, 0),
> + REG64_IDX(HSW_CS_GPR, 1),
> + REG64_IDX(HSW_CS_GPR, 2),
> + REG64_IDX(HSW_CS_GPR, 3),
> + REG64_IDX(HSW_CS_GPR, 4),
> + REG64_IDX(HSW_CS_GPR, 5),
> + REG64_IDX(HSW_CS_GPR, 6),
> + REG64_IDX(HSW_CS_GPR, 7),
> + REG64_IDX(HSW_CS_GPR, 8),
> + REG64_IDX(HSW_CS_GPR, 9),
> + REG64_IDX(HSW_CS_GPR, 10),
> + REG64_IDX(HSW_CS_GPR, 11),
> + REG64_IDX(HSW_CS_GPR, 12),
> + REG64_IDX(HSW_CS_GPR, 13),
> + REG64_IDX(HSW_CS_GPR, 14),
> + REG64_IDX(HSW_CS_GPR, 15),
> REG32(HSW_SCRATCH1,
> .mask = ~HSW_SCRATCH1_L3_DATA_ATOMICS_DISABLE,
> .value = 0),
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index f76cbf3..5ba7761 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -586,6 +586,10 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
> #define GEN7_GPGPU_DISPATCHDIMY _MMIO(0x2504)
> #define GEN7_GPGPU_DISPATCHDIMZ _MMIO(0x2508)
>
> +/* There are the 16 64-bit CS General Purpose Registers */
> +#define HSW_CS_GPR(n) _MMIO(0x2600 + (n) * 8)
> +#define HSW_CS_GPR_UDW(n) _MMIO(0x2600 + (n) * 8 + 4)
> +
> #define OACONTROL _MMIO(0x2360)
>
> #define _GEN7_PIPEA_DE_LOAD_SL 0x70068
> --
> 2.7.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 212 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-08 22:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 7:30 [PATCH 0/5] Haswell Command Parser updates for Vulkan Jordan Justen
2016-03-07 7:30 ` [PATCH 1/5] drm/i915: Add TIMESTAMP to register whitelist Jordan Justen
2016-03-08 22:06 ` Francisco Jerez
2016-03-07 7:30 ` [PATCH 2/5] drm/i915: Use an array of register tables in command parser Jordan Justen
2016-03-16 23:33 ` Francisco Jerez
2016-03-07 7:30 ` [PATCH 3/5] drm/i915: Move Haswell registers to separate whitelist table Jordan Justen
2016-03-08 22:05 ` Francisco Jerez
2016-03-07 7:30 ` [PATCH 4/5] drm/i915: Add Haswell CS GPR registers to whitelist Jordan Justen
2016-03-08 22:06 ` Francisco Jerez [this message]
2016-03-07 7:30 ` [PATCH 5/5] drm/i915: Bump command parser version for new whitelisted registers Jordan Justen
2016-03-08 22:07 ` Francisco Jerez
2016-03-21 9:03 ` Daniel Vetter
2016-03-07 12:27 ` ✗ Fi.CI.BAT: failure for Haswell Command Parser updates for Vulkan Patchwork
2016-03-21 8:53 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuw0fwuo.fsf@riseup.net \
--to=currojerez@riseup.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jordan.l.justen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox