From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915: Consider HW CSB write pointer before resetting the sw read pointer Date: Fri, 25 Sep 2015 18:44:34 +0300 Message-ID: <87fv22a4gt.fsf@gaia.fi.intel.com> References: <1443019430-20792-1-git-send-email-michel.thierry@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id AA6936F157 for ; Fri, 25 Sep 2015 08:45:02 -0700 (PDT) In-Reply-To: <1443019430-20792-1-git-send-email-michel.thierry@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michel Thierry , intel-gfx@lists.freedesktop.org Cc: deepak.s@intel.com List-Id: intel-gfx@lists.freedesktop.org TWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4gd3JpdGVzOgoKPiBBIHBy ZXZpb3VzIGNvbW1pdCByZXNldHMgdGhlIENvbnRleHQgU3RhdHVzIEJ1ZmZlciAoQ1NCKSByZWFk IHBvaW50ZXIgaW4KPiByaW5nIGluaXQKPiAgICAgY29tbWl0IGMwYTAzYTJlNGM0ZSAoImRybS9p OTE1OiBSZXNldCBDU0IgcmVhZCBwb2ludGVyIGluIHJpbmcgaW5pdCIpCj4KPiBUaGlzIGlzIGdl bmVyYWxseSBjb3JyZWN0LCBidXQgdGhpcyBwb2ludGVyIGlzIG5vdCByZXNldCBhZnRlcgo+IHN1 c3BlbmQvcmVzdW1lIGluIHNvbWUgcGxhdGZvcm1zIChjaHQpLiBJbiB0aGlzIGNhc2UsIHRoZSBk cml2ZXIgc2hvdWxkCj4gcmVhZCB0aGUgcmVnaXN0ZXIgdmFsdWUgaW5zdGVhZCBvZiByZXNldHRp bmcgdGhlIHN3IHJlYWQgY291bnRlciB0byAwLgo+IE90aGVyd2lzZSB3ZSBwcm9jZXNzIG9sZCBl dmVudHMsIGxlYWRpbmcgdG8gdW53YW50ZWQgcHJlLWVtcHRpb25zIG9yCj4gc29tZXRoaW5nIHdv cnNlLgo+Cj4gQnV0IGluIG90aGVyIHBsYXRmb3JtcyAoYmR3KSBhbmQgYWxzbyBkdXJpbmcgR1BV IHJlc2V0IG9yIHBvd2VyIHVwLCB0aGUKPiBDU0JXUCBpcyByZXNldCB0byAweDcgKGFuIGludmFs aWQgbnVtYmVyKSwgYW5kIGluIHRoaXMgY2FzZSB0aGUgcmVhZAo+IHBvaW50ZXIgc2hvdWxkIGJl IHNldCB0byAwLgo+Cj4gU2lnbmVkLW9mZi1ieTogTGVpIFNoZW4gPGxlaS5zaGVuQGludGVsLmNv bT4KPiBTaWduZWQtb2ZmLWJ5OiBEZWVwYWsgUyA8ZGVlcGFrLnNAaW50ZWwuY29tPgo+IFNpZ25l ZC1vZmYtYnk6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgMjQgKysrKysrKysrKysrKysr KysrKysrKystCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u KC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IGZmOWE0ODEuLmRkODc4MTIg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC0xNDc5LDYgKzE0NzksNyBAQCBz dGF0aWMgaW50IGdlbjhfaW5pdF9jb21tb25fcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpy aW5nKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gcmluZy0+ZGV2Owo+ICAJc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXU4 IG5leHRfY29udGV4dF9zdGF0dXNfYnVmZmVyX2h3Owo+ICAKPiAgCWxyY19zZXR1cF9oYXJkd2Fy ZV9zdGF0dXNfcGFnZShyaW5nLAo+ICAJCQkJcmluZy0+ZGVmYXVsdF9jb250ZXh0LT5lbmdpbmVb cmluZy0+aWRdLnN0YXRlKTsKPiBAQCAtMTQ5Niw3ICsxNDk3LDI4IEBAIHN0YXRpYyBpbnQgZ2Vu OF9pbml0X2NvbW1vbl9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4gIAkJICAg X01BU0tFRF9CSVRfRElTQUJMRShHRlhfUkVQTEFZX01PREUpIHwKPiAgCQkgICBfTUFTS0VEX0JJ VF9FTkFCTEUoR0ZYX1JVTl9MSVNUX0VOQUJMRSkpOwo+ICAJUE9TVElOR19SRUFEKFJJTkdfTU9E RV9HRU43KHJpbmcpKTsKPiAtCXJpbmctPm5leHRfY29udGV4dF9zdGF0dXNfYnVmZmVyID0gMDsK PiArCj4gKwkvKgo+ICsJICogSW5zdGVhZCBvZiByZXNldHRpbmcgdGhlIENvbnRleHQgU3RhdHVz IEJ1ZmZlciAoQ1NCKSByZWFkIHBvaW50ZXIgdG8KPiArCSAqIHplcm8sIHdlIG5lZWQgdG8gcmVh ZCB0aGUgd3JpdGUgcG9pbnRlciBmcm9tIGhhcmR3YXJlIGFuZCB1c2UgaXRzCj4gKwkgKiB2YWx1 ZSBiZWNhdXNlICJ0aGlzIHJlZ2lzdGVyIGlzIHBvd2VyIGNvbnRleHQgc2F2ZSByZXN0b3JlZCIu Cj4gKwkgKiBFZmZlY3RpdmVseSwgdGhlc2Ugc3RhdGVzIGhhdmUgYmVlbiBvYnNlcnZlZDoKPiAr CSAqCj4gKwkgKiAgICAgIHwgU3VzcGVuZC10by1pZGxlIChmcmVlemUpIHwgU3VzcGVuZC10by1S QU0gKG1lbSkgfAo+ICsJICogQkRXICB8IENTQiByZWdzIG5vdCByZXNldCAgICAgICB8IENTQiBy ZWdzIHJlc2V0ICAgICAgIHwKPiArCSAqIENIVCAgfCBDU0IgcmVncyBub3QgcmVzZXQgICAgICAg fCBDU0IgcmVncyBub3QgcmVzZXQgICB8Cj4gKwkgKi8KPiArCW5leHRfY29udGV4dF9zdGF0dXNf YnVmZmVyX2h3ID0gSTkxNV9SRUFEKFJJTkdfQ09OVEVYVF9TVEFUVVNfUFRSKHJpbmcpKSAmIDB4 MDc7Cj4gKwo+ICsJLyoKPiArCSAqIFdoZW4gdGhlIENTQiByZWdpc3RlcnMgYXJlIHJlc2V0IChh bHNvIGFmdGVyIHBvd2VyLXVwIC8gZ3B1IHJlc2V0KSwKPiArCSAqIENTQiB3cml0ZSBwb2ludGVy IGlzIHNldCB0byBhbGwgMSdzLCB3aGljaCBpcyBub3QgdmFsaWQsIHVzZSAwIGluCj4gKwkgKiB0 aGlzIHNwZWNpYWwgY2FzZS4KPiArCSAqLwo+ICsJaWYgKG5leHRfY29udGV4dF9zdGF0dXNfYnVm ZmVyX2h3ID09IDB4NykKPiArCQluZXh0X2NvbnRleHRfc3RhdHVzX2J1ZmZlcl9odyA9IDA7CgoK SWYgaGFyZHdhcmUgaGFzIGJlZW4gcmVzZXQgYW5kIHdlIGhhdmUgYjExMSBoZXJlLCBJIGFzc3Vt ZQp0aGUgZmlyc3Qgd3JpdGUgd2lsbCBiZSBhdCBpbmRleCB6ZXJvLgoKSWYgd2UgbG9vayBhdCB0 aGUgaW50ZXJydXB0IGNvZGUgdGhlcmUgaXMgd2hpbGUgKHJlYWRfcG9pbnRlciA8CndyaXRlX3Bv aW50ZXIpLiBJbml0aWFsaXppbmcgbmV4dCBzdGF0dXMgYnVmZmVyIHRvIHplcm8Kd291bGQgbWVh biB0aGF0IHlvdSBtaXNzIHRoZSBmaXJzdCB3cml0ZSB0byBjc2JbMF0uCgpJZiBiMTExIGlzIGZv dW5kLCBJIHRoaW5rIHRoZSBjb3JyZWN0IHZhbHVlIGlzIDUuCgotTWlrYQoKCj4gKwo+ICsJcmlu Zy0+bmV4dF9jb250ZXh0X3N0YXR1c19idWZmZXIgPSBuZXh0X2NvbnRleHRfc3RhdHVzX2J1ZmZl cl9odzsKPiAgCURSTV9ERUJVR19EUklWRVIoIkV4ZWNsaXN0cyBlbmFibGVkIGZvciAlc1xuIiwg cmluZy0+bmFtZSk7Cj4gIAo+ICAJbWVtc2V0KCZyaW5nLT5oYW5nY2hlY2ssIDAsIHNpemVvZihy aW5nLT5oYW5nY2hlY2spKTsKPiAtLSAKPiAyLjUuMwo+Cj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK