From: "Bjørn Mork" <bjorn@mork.no>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Still time for v4.2? - c0165304e10f ("drm/i915: Only enable cursor if it can be enabled.")
Date: Tue, 25 Aug 2015 09:45:24 +0200 [thread overview]
Message-ID: <87fv37ak17.fsf@nemi.mork.no> (raw)
Hello, I see that I consistently get the warning below on v4.2-rc8. I
believe you already fixed this a long time ago by commit c0165304e10f
("drm/i915: Only enable cursor if it can be enabled."), which I assume is
a stable candidate for v4.2.y.
But wouldn't it look better if you managed to squeeze this into v4.2?
The warning will probably cause a few unnecessary worries and reports
from users...
Sample WARNING from v4.2-rc8, minus the irrelevant list of modules:
------------[ cut here ]------------
WARNING: CPU: 1 PID: 2675 at drivers/gpu/drm/i915/intel_display.c:9669 intel_crtc_update_cursor+0x335/0x452 [i915]()
Missing switch case (0) in i9xx_update_cursor
CPU: 1 PID: 2675 Comm: Xorg Tainted: G W 4.2.0-rc8 #339
Hardware name: LENOVO 2776LEG/2776LEG, BIOS 6EET55WW (3.15 ) 12/19/2011
0000000000000009 ffff88022ca07b68 ffffffff81423887 0000000000000006
ffff88022ca07bb8 ffff88022ca07ba8 ffffffff8104a9d6 0000000000070088
ffffffffa036b141 ffff8802317c9000 000000000053e000 ffff880231790000
Call Trace:
[<ffffffff81423887>] dump_stack+0x4c/0x65
[<ffffffff8104a9d6>] warn_slowpath_common+0xa1/0xbb
[<ffffffffa036b141>] ? intel_crtc_update_cursor+0x335/0x452 [i915]
[<ffffffff8104aa36>] warn_slowpath_fmt+0x46/0x48
[<ffffffffa035cf66>] ? gen2_write32+0x35/0x44 [i915]
[<ffffffffa036b141>] intel_crtc_update_cursor+0x335/0x452 [i915]
[<ffffffffa0372afa>] intel_crtc_enable_planes+0xce/0xfd [i915]
[<ffffffffa03748b4>] intel_crtc_control+0x7d/0xe1 [i915]
[<ffffffffa0374965>] intel_crtc_update_dpms+0x4d/0x5d [i915]
[<ffffffffa0379115>] intel_connector_dpms+0x49/0x55 [i915]
[<ffffffffa02a3c36>] drm_mode_obj_set_property_ioctl+0x103/0x1b3 [drm]
[<ffffffffa02a3d16>] drm_mode_connector_property_set_ioctl+0x30/0x32 [drm]
[<ffffffffa0295be5>] drm_ioctl+0x37d/0x421 [drm]
[<ffffffffa02a3ce6>] ? drm_mode_obj_set_property_ioctl+0x1b3/0x1b3 [drm]
[<ffffffff81073d35>] ? local_clock+0x19/0x22
[<ffffffff811799ca>] do_vfs_ioctl+0x430/0x4ef
[<ffffffff81054ec0>] ? do_sigaltstack+0xbe/0x16a
[<ffffffff81182c06>] ? __fget_light+0x50/0x78
[<ffffffff81179ae3>] SyS_ioctl+0x5a/0x7f
[<ffffffff81429557>] entry_SYSCALL_64_fastpath+0x12/0x6f
---[ end trace 7c3e6448deed5ebc ]---
Thanks,
Bjørn
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2015-08-25 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 7:45 Bjørn Mork [this message]
2015-08-25 10:12 ` Still time for v4.2? - c0165304e10f ("drm/i915: Only enable cursor if it can be enabled.") Maarten Lankhorst
2015-08-25 10:41 ` Bjørn Mork
2015-09-08 7:31 ` Bjørn Mork
2015-09-08 8:44 ` Maarten Lankhorst
2015-09-08 8:50 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv37ak17.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox