Re: [PATCH 12/17] drm/i915: Arm cmd parser with aliasng ppgtt only

[Mika Kuoppala <mika.kuoppala@linux.intel.com>]

Daniel Vetter <daniel.vetter@ffwll.ch> writes:

> With the binding regression from the original full ppgtt patches
> fixed we can throw the switch. Yay!
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_execbuffer.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> index f005f3151147..819f2b2317ff 100644
> --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> @@ -1557,12 +1557,8 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
>  		 * dispatch_execbuffer implementations. We specifically
>  		 * don't want that set when the command parser is
>  		 * enabled.
> -		 *
> -		 * FIXME: with aliasing ppgtt, buffers that should only
> -		 * be in ggtt still end up in the aliasing ppgtt. remove
> -		 * this check when that is fixed.
>  		 */
> -		if (USES_FULL_PPGTT(dev))
> +		if (USES_PPGTT(dev))
>  			dispatch_flags |= I915_DISPATCH_SECURE;
>  

You can remove the check for USES_PPGTT here, like in patch 
that Chris posted. The i915_needs_cmd_parser() checks that
for us.

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

>  		exec_start = 0;
> -- 
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx