From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: Make intel_pipe_has_type() take an output type enum
Date: Wed, 29 Oct 2014 13:48:15 +0200 [thread overview]
Message-ID: <87fve7jdvk.fsf@intel.com> (raw)
In-Reply-To: <1414581419-8918-1-git-send-email-damien.lespiau@intel.com>
On Wed, 29 Oct 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> As Paulo said when introducing the enum, having more types is really
> good to document what should go where (int foo(int, int, bool, bool).
>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> drivers/gpu/drm/i915/intel_drv.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 92f0005..efc3b82 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -408,7 +408,7 @@ static void vlv_clock(int refclk, intel_clock_t *clock)
> /**
> * Returns whether any output on the specified pipe is of the specified type
> */
> -bool intel_pipe_has_type(struct intel_crtc *crtc, int type)
> +bool intel_pipe_has_type(struct intel_crtc *crtc, enum intel_output_type type)
> {
> struct drm_device *dev = crtc->base.dev;
> struct intel_encoder *encoder;
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index d53ac23..f9adf3c 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -880,7 +880,7 @@ int intel_get_pipe_from_crtc_id(struct drm_device *dev, void *data,
> struct drm_file *file_priv);
> enum transcoder intel_pipe_to_cpu_transcoder(struct drm_i915_private *dev_priv,
> enum pipe pipe);
> -bool intel_pipe_has_type(struct intel_crtc *crtc, int type);
> +bool intel_pipe_has_type(struct intel_crtc *crtc, enum intel_output_type type);
> static inline void
> intel_wait_for_vblank(struct drm_device *dev, int pipe)
> {
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-10-29 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 11:16 [PATCH] drm/i915: Make intel_pipe_has_type() take an output type enum Damien Lespiau
2014-10-29 11:48 ` Jani Nikula [this message]
2014-11-03 14:18 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fve7jdvk.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox