From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Do not leak pages when freeing userptr objects Date: Mon, 29 Sep 2014 16:18:37 +0300 Message-ID: <87fvfalg42.fsf@intel.com> References: <1411740322-12537-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20140926145551.GC9308@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CD0C89F73 for ; Mon, 29 Sep 2014 06:18:41 -0700 (PDT) In-Reply-To: <20140926145551.GC9308@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 26 Sep 2014, Chris Wilson wrote: > On Fri, Sep 26, 2014 at 03:05:22PM +0100, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> sg_alloc_table_from_pages() can build us a table with coalesced ranges which >> means we need to iterate over pages and not sg table entries when releasing >> page references. >> >> Signed-off-by: Tvrtko Ursulin >> Cc: Chris Wilson >> Cc: "Barbalho, Rafael" > > Oh that's fun. I blame Imre for the recent invention of for_each_sg_page()! > Reviewed-by: Chris Wilson > Cc: stable@vger.kernel.org Pushed to drm-intel-fixes, with the unused struct scatterlist *sg variable removed. Thanks for the patch, review, and testing. BR, Jani. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center