From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 2/3] drm/sysfs: Don't pollute
	connector->kdev if drm_connector_sysfs_add() fails
Date: Tue, 05 Nov 2013 09:13:16 +0200
Message-ID: <87fvrbs4mr.fsf@intel.com>
References: <1383592728-20851-1-git-send-email-ville.syrjala@linux.intel.com>
	<1383592728-20851-3-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <1383592728-20851-3-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAwNCBOb3YgMjAxMywgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6
Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K
Pgo+IEN1cnJlbnRseSBpZiBkcm1fY29ubmVjdG9yX3N5c2ZzX2FkZCgpIGZhaWxzLCBpdCBjYW4g
bGVhdmUgY29ubmVjdG9yLT5rZGV2Cj4gcG9wdWxhdGVkIHdpdGggYW4gRVJSX1BUUiB2YWx1ZSwg
b3IgcG9pbnRpbmcgdG8gYW4gYWxyZWFkeSBmcmVlZCBkZXZpY2UuCj4gVXNlIGEgdGVtcG9yYXJh
cnkga2RldiBwb2ludGVyIGR1cmluZyBkcm1fY29ubmVjdG9yX3N5c2ZzX2FkZCgpLCBhbmQKPiBv
bmx5IHNldCBjb25uZWN0b3ItPmtkZXYgaWYgdGhlIGZ1bmN0aW9uIHN1Y2NlZWRzLiBUaGlzIGF2
b2lkcyBvb3BzaW5nCj4gaWYgZHJtX2Nvbm5lY3Rvcl9zeXNmc19yZW1vdmUoKSBnZXRzIGNhbGxl
ZCBmb3IgYSBjb25uZWN0b3Igd2hlcmUKPiBkcm1fY29ubmVjdG9yX3N5c2ZzX2FkZCgpIHByZXZp
b3VzbHkgZmFpbGVkLgoKcy9jb25uZWN0b3Jfc3lzZnMvc3lzZnNfY29ubmVjdG9yL2cKCj4gR2l2
ZSBkcm1fc3lzZnNfZGV2aWNlX2FkZCgpIHRoZSBzYW1lIHRyZWF0bWVudCBmb3IgdGhlIHNha2Ug
b2YKPiBjb25zaXN0ZW5jeS4KCk1heWJlIHRoYXQgb25lIHNob3VsZCBoYXZlIHRoZSBpZiAobWlu
b3ItPmtkZXYpIHJldHVybiAwOyBwYXJ0IHRvbyBpZgpjb25zaXN0ZW5jeSBpcyB3aGF0IHlvdSdy
ZSBhZnRlci4KClRoZSBhYm92ZSBhZGRyZXNzZWQgYW5kIHlvdSd2ZSBnb3QKUmV2aWV3ZWQtYnk6
IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cgo+Cj4gU2lnbmVkLW9mZi1ieTog
VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAg
ZHJpdmVycy9ncHUvZHJtL2RybV9zeXNmcy5jIHwgNDMgKysrKysrKysrKysrKysrKysrKysrKysr
Ky0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwg
MTggZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9zeXNm
cy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zeXNmcy5jCj4gaW5kZXggMWEzNWVhNS4uYTgyZGM4
YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5c2ZzLmMKPiArKysgYi9kcml2
ZXJzL2dwdS9kcm0vZHJtX3N5c2ZzLmMKPiBAQCAtMzcwLDYgKzM3MCw3IEBAIHN0YXRpYyBzdHJ1
Y3QgYmluX2F0dHJpYnV0ZSBlZGlkX2F0dHIgPSB7Cj4gIGludCBkcm1fc3lzZnNfY29ubmVjdG9y
X2FkZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJt
X2RldmljZSAqZGV2ID0gY29ubmVjdG9yLT5kZXY7Cj4gKwlzdHJ1Y3QgZGV2aWNlICprZGV2Owo+
ICAJaW50IGF0dHJfY250ID0gMDsKPiAgCWludCBvcHRfY250ID0gMDsKPiAgCWludCBpOwo+IEBA
IC0zNzgsMjIgKzM3OSwyMiBAQCBpbnQgZHJtX3N5c2ZzX2Nvbm5lY3Rvcl9hZGQoc3RydWN0IGRy
bV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgCWlmIChjb25uZWN0b3ItPmtkZXYpCj4gIAkJcmV0
dXJuIDA7Cj4gIAo+IC0JY29ubmVjdG9yLT5rZGV2ID0gZGV2aWNlX2NyZWF0ZShkcm1fY2xhc3Ms
IGRldi0+cHJpbWFyeS0+a2RldiwKPiAtCQkJCQkwLCBjb25uZWN0b3IsICJjYXJkJWQtJXMiLAo+
IC0JCQkJCWRldi0+cHJpbWFyeS0+aW5kZXgsIGRybV9nZXRfY29ubmVjdG9yX25hbWUoY29ubmVj
dG9yKSk7Cj4gKwlrZGV2ID0gZGV2aWNlX2NyZWF0ZShkcm1fY2xhc3MsIGRldi0+cHJpbWFyeS0+
a2RldiwKPiArCQkJICAgICAwLCBjb25uZWN0b3IsICJjYXJkJWQtJXMiLAo+ICsJCQkgICAgIGRl
di0+cHJpbWFyeS0+aW5kZXgsIGRybV9nZXRfY29ubmVjdG9yX25hbWUoY29ubmVjdG9yKSk7Cj4g
IAlEUk1fREVCVUcoImFkZGluZyBcIiVzXCIgdG8gc3lzZnNcbiIsCj4gIAkJICBkcm1fZ2V0X2Nv
bm5lY3Rvcl9uYW1lKGNvbm5lY3RvcikpOwo+ICAKPiAtCWlmIChJU19FUlIoY29ubmVjdG9yLT5r
ZGV2KSkgewo+IC0JCURSTV9FUlJPUigiZmFpbGVkIHRvIHJlZ2lzdGVyIGNvbm5lY3RvciBkZXZp
Y2U6ICVsZFxuIiwgUFRSX0VSUihjb25uZWN0b3ItPmtkZXYpKTsKPiAtCQlyZXQgPSBQVFJfRVJS
KGNvbm5lY3Rvci0+a2Rldik7Cj4gKwlpZiAoSVNfRVJSKGtkZXYpKSB7Cj4gKwkJRFJNX0VSUk9S
KCJmYWlsZWQgdG8gcmVnaXN0ZXIgY29ubmVjdG9yIGRldmljZTogJWxkXG4iLCBQVFJfRVJSKGtk
ZXYpKTsKPiArCQlyZXQgPSBQVFJfRVJSKGtkZXYpOwo+ICAJCWdvdG8gb3V0Owo+ICAJfQo+ICAK
PiAgCS8qIFN0YW5kYXJkIGF0dHJpYnV0ZXMgKi8KPiAgCj4gIAlmb3IgKGF0dHJfY250ID0gMDsg
YXR0cl9jbnQgPCBBUlJBWV9TSVpFKGNvbm5lY3Rvcl9hdHRycyk7IGF0dHJfY250KyspIHsKPiAt
CQlyZXQgPSBkZXZpY2VfY3JlYXRlX2ZpbGUoY29ubmVjdG9yLT5rZGV2LCAmY29ubmVjdG9yX2F0
dHJzW2F0dHJfY250XSk7Cj4gKwkJcmV0ID0gZGV2aWNlX2NyZWF0ZV9maWxlKGtkZXYsICZjb25u
ZWN0b3JfYXR0cnNbYXR0cl9jbnRdKTsKPiAgCQlpZiAocmV0KQo+ICAJCQlnb3RvIGVycl9vdXRf
ZmlsZXM7Cj4gIAl9Cj4gQEAgLTQxMCw3ICs0MTEsNyBAQCBpbnQgZHJtX3N5c2ZzX2Nvbm5lY3Rv
cl9hZGQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgCQljYXNlIERSTV9NT0RF
X0NPTk5FQ1RPUl9Db21wb25lbnQ6Cj4gIAkJY2FzZSBEUk1fTU9ERV9DT05ORUNUT1JfVFY6Cj4g
IAkJCWZvciAob3B0X2NudCA9IDA7IG9wdF9jbnQgPCBBUlJBWV9TSVpFKGNvbm5lY3Rvcl9hdHRy
c19vcHQxKTsgb3B0X2NudCsrKSB7Cj4gLQkJCQlyZXQgPSBkZXZpY2VfY3JlYXRlX2ZpbGUoY29u
bmVjdG9yLT5rZGV2LCAmY29ubmVjdG9yX2F0dHJzX29wdDFbb3B0X2NudF0pOwo+ICsJCQkJcmV0
ID0gZGV2aWNlX2NyZWF0ZV9maWxlKGtkZXYsICZjb25uZWN0b3JfYXR0cnNfb3B0MVtvcHRfY250
XSk7Cj4gIAkJCQlpZiAocmV0KQo+ICAJCQkJCWdvdG8gZXJyX291dF9maWxlczsKPiAgCQkJfQo+
IEBAIC00MTksMjEgKzQyMCwyMyBAQCBpbnQgZHJtX3N5c2ZzX2Nvbm5lY3Rvcl9hZGQoc3RydWN0
IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgCQkJYnJlYWs7Cj4gIAl9Cj4gIAo+IC0JcmV0
ID0gc3lzZnNfY3JlYXRlX2Jpbl9maWxlKCZjb25uZWN0b3ItPmtkZXYtPmtvYmosICZlZGlkX2F0
dHIpOwo+ICsJcmV0ID0gc3lzZnNfY3JlYXRlX2Jpbl9maWxlKCZrZGV2LT5rb2JqLCAmZWRpZF9h
dHRyKTsKPiAgCWlmIChyZXQpCj4gIAkJZ290byBlcnJfb3V0X2ZpbGVzOwo+ICAKPiAgCS8qIExl
dCB1c2Vyc3BhY2Uga25vdyB3ZSBoYXZlIGEgbmV3IGNvbm5lY3RvciAqLwo+ICAJZHJtX3N5c2Zz
X2hvdHBsdWdfZXZlbnQoZGV2KTsKPiAgCj4gKwljb25uZWN0b3ItPmtkZXYgPSBrZGV2Owo+ICsK
PiAgCXJldHVybiAwOwo+ICAKPiAgZXJyX291dF9maWxlczoKPiAgCWZvciAoaSA9IDA7IGkgPCBv
cHRfY250OyBpKyspCj4gLQkJZGV2aWNlX3JlbW92ZV9maWxlKGNvbm5lY3Rvci0+a2RldiwgJmNv
bm5lY3Rvcl9hdHRyc19vcHQxW2ldKTsKPiArCQlkZXZpY2VfcmVtb3ZlX2ZpbGUoa2RldiwgJmNv
bm5lY3Rvcl9hdHRyc19vcHQxW2ldKTsKPiAgCWZvciAoaSA9IDA7IGkgPCBhdHRyX2NudDsgaSsr
KQo+IC0JCWRldmljZV9yZW1vdmVfZmlsZShjb25uZWN0b3ItPmtkZXYsICZjb25uZWN0b3JfYXR0
cnNbaV0pOwo+IC0JZGV2aWNlX3VucmVnaXN0ZXIoY29ubmVjdG9yLT5rZGV2KTsKPiArCQlkZXZp
Y2VfcmVtb3ZlX2ZpbGUoa2RldiwgJmNvbm5lY3Rvcl9hdHRyc1tpXSk7Cj4gKwlkZXZpY2VfdW5y
ZWdpc3RlcihrZGV2KTsKPiAgCj4gIG91dDoKPiAgCXJldHVybiByZXQ7Cj4gQEAgLTUwMSw2ICs1
MDQsNyBAQCBFWFBPUlRfU1lNQk9MKGRybV9zeXNmc19ob3RwbHVnX2V2ZW50KTsKPiAgaW50IGRy
bV9zeXNmc19kZXZpY2VfYWRkKHN0cnVjdCBkcm1fbWlub3IgKm1pbm9yKQo+ICB7Cj4gIAljaGFy
ICptaW5vcl9zdHI7Cj4gKwlzdHJ1Y3QgZGV2aWNlICprZGV2Owo+ICAKPiAgCWlmIChtaW5vci0+
dHlwZSA9PSBEUk1fTUlOT1JfQ09OVFJPTCkKPiAgCQltaW5vcl9zdHIgPSAiY29udHJvbEQlZCI7
Cj4gQEAgLTUwOSwxMyArNTEzLDE2IEBAIGludCBkcm1fc3lzZnNfZGV2aWNlX2FkZChzdHJ1Y3Qg
ZHJtX21pbm9yICptaW5vcikKPiAgICAgICAgICBlbHNlCj4gICAgICAgICAgICAgICAgICBtaW5v
cl9zdHIgPSAiY2FyZCVkIjsKPiAgCj4gLQltaW5vci0+a2RldiA9IGRldmljZV9jcmVhdGUoZHJt
X2NsYXNzLCBtaW5vci0+ZGV2LT5kZXYsCj4gLQkJCQkgICAgTUtERVYoRFJNX01BSk9SLCBtaW5v
ci0+aW5kZXgpLAo+IC0JCQkJICAgIG1pbm9yLCBtaW5vcl9zdHIsIG1pbm9yLT5pbmRleCk7Cj4g
LQlpZiAoSVNfRVJSKG1pbm9yLT5rZGV2KSkgewo+IC0JCURSTV9FUlJPUigiZGV2aWNlIGNyZWF0
ZSBmYWlsZWQgJWxkXG4iLCBQVFJfRVJSKG1pbm9yLT5rZGV2KSk7Cj4gLQkJcmV0dXJuIFBUUl9F
UlIobWlub3ItPmtkZXYpOwo+ICsJa2RldiA9IGRldmljZV9jcmVhdGUoZHJtX2NsYXNzLCBtaW5v
ci0+ZGV2LT5kZXYsCj4gKwkJCSAgICAgTUtERVYoRFJNX01BSk9SLCBtaW5vci0+aW5kZXgpLAo+
ICsJCQkgICAgIG1pbm9yLCBtaW5vcl9zdHIsIG1pbm9yLT5pbmRleCk7Cj4gKwlpZiAoSVNfRVJS
KGtkZXYpKSB7Cj4gKwkJRFJNX0VSUk9SKCJkZXZpY2UgY3JlYXRlIGZhaWxlZCAlbGRcbiIsIFBU
Ul9FUlIoa2RldikpOwo+ICsJCXJldHVybiBQVFJfRVJSKGtkZXYpOwo+ICAJfQo+ICsKPiArCW1p
bm9yLT5rZGV2ID0ga2RldjsKPiArCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiAtLSAKPiAxLjgu
MS41Cj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+
IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl
bAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg
bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3Rz
LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=