From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v5 0/4] Fix Win8 backlight issue Date: Mon, 28 Oct 2013 10:09:11 +0200 Message-ID: <87fvrl7r6g.fsf@intel.com> References: <1381498066-16011-1-git-send-email-aaron.lu@intel.com> <2140073.U60XyxRqVZ@vostro.rjw.lan> <5268D6BB.3010207@intel.com> <1382682925.3328.4.camel@ThinkPad-X230.localdomain> <526DCFD7.7060002@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <526DCFD7.7060002@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Igor Gnatenko Cc: James Hogan , Mike Galbraith , Felipe Contreras , dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, Henrique de Moraes Holschuh , Matthew Garrett , linux-acpi@vger.kernel.org, Kalle Valo , Yves-Alexis Perez , Martin Steigerwald , Lee Chun-Yi , Ben Jencks , =?utf-8?Q?J=C3=B6rg?= Otte , intel-gfx@lists.freedesktop.org, Kevin Smith , Peter Weber , Joerg Platte , Seth Forshee , Lennart Poettering , Mika Westerberg , Aaron Lu , Theodore Tso , Ra List-Id: intel-gfx@lists.freedesktop.org On Mon, 28 Oct 2013, Aaron Lu wrote: > On 10/25/2013 02:35 PM, Igor Gnatenko wrote: >> Aaron, add this notebook to list. I've CC'ed owner. >> And I've tested this patch on my TP X230 (add as Reported-and-Tested me >> please) >> + { >> + .callback = video_set_use_native_backlight, >> + .ident = "Dell Inspiron 7520", >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), >> + DMI_MATCH(DMI_PRODUCT_VERSION, "Inspiron 7520"), >> + }, >> + }, > > Thanks Igor, updated patch follows: > > From: Aaron Lu > Subject: [PATCH] ACPI / video: Add systems that should favour native backlight > interface > > Some system's ACPI video backlight control interface is broken and the > native backlight control interface should be used by default. This patch > sets the use_native_backlight parameter to true for those systems so > that video backlight control interface will not be created. To be > specific, the ThinkPad T430s/X230, Lenovo Yoga 13 and Dell Inspiron 7520 > are added here. > > Thinkpad T430s: > Reported-by: Theodore Tso > Reported-and-tested-by: Peter Weber > Thinkpad X230: > Reported-and-tested-by: Igor Gnatenko > Lenovo Yoga 13: > Reported-by: Lennart Poettering > Reported-and-tested-by: Kevin Smith > Dell Inspiron 7520: > Reported-by: Renat Ibragimov > > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=51231 > Signed-off-by: Aaron Lu > --- > drivers/acpi/video.c | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c > index d020df5..0a1b030 100644 > --- a/drivers/acpi/video.c > +++ b/drivers/acpi/video.c > @@ -412,6 +412,12 @@ static int video_ignore_initial_backlight(const struct dmi_system_id *d) > return 0; > } > > +static int __init video_set_use_native_backlight(const struct dmi_system_id *d) > +{ > + use_native_backlight = true; > + return 0; > +} Hi Aaron, it might be beneficial to make use_native_backlight support three values: force true, force false, and use platform default based on DMI. BR, Jani. > + > static struct dmi_system_id video_dmi_table[] __initdata = { > /* > * Broken _BQC workaround http://bugzilla.kernel.org/show_bug.cgi?id=13121 > @@ -504,6 +510,38 @@ static struct dmi_system_id video_dmi_table[] __initdata = { > DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion m4 Notebook PC"), > }, > }, > + { > + .callback = video_set_use_native_backlight, > + .ident = "ThinkPad T430s", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T430s"), > + }, > + }, > + { > + .callback = video_set_use_native_backlight, > + .ident = "ThinkPad X230", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X230"), > + }, > + }, > + { > + .callback = video_set_use_native_backlight, > + .ident = "Lenovo Yoga 13", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo IdeaPad Yoga 13"), > + }, > + }, > + { > + .callback = video_set_use_native_backlight, > + .ident = "Dell Inspiron 7520", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_VERSION, "Inspiron 7520"), > + }, > + }, > {} > }; > > -- > 1.8.4.39.ga0d3f10 > -- Jani Nikula, Intel Open Source Technology Center