From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/i915: Protect mmaped buffers from casual eviction. Date: Tue, 11 May 2010 09:38:36 -0700 Message-ID: <87fx1yqtpv.fsf@pollan.anholt.net> References: <1273593327-3051-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1344166240==" Return-path: In-Reply-To: <1273593327-3051-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1344166240== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 11 May 2010 16:55:27 +0100, Chris Wilson = wrote: > By keeping buffers that are in use by the CPU, having been mmapped and > moved to the CPU or GTT domain since their last rendering on a separate > inactive list, prevents the first-pass eviction process from unbinding > one of these buffers. Those buffers are evicted as normal during > evict-everything so that the memory can be recovered under high pressure > or a forced idle. >=20 > References: >=20 > Bug 20152 - [G45/GM965 UXA] cannot view JPG in firefox when running UXA > https://bugs.freedesktop.org/show_bug.cgi?id=3D20152 >=20 > Bug 24369 - Hang when scrolling firefox page with window in front > https://bugs.freedesktop.org/show_bug.cgi?id=3D24369 >=20 > Bug 15911 - Intermittent X crash (freeze) > https://bugzilla.kernel.org/show_bug.cgi?id=3D15911 Couldn't this be more easily handled by the times where you would move to the tail of mmap, just move to the tail of inactive? Since inactive is "obj_priv->gtt_space && !obj_priv->active" already. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkvpiAwACgkQHUdvYGzw6vf4WACfRBpaGysS8jBE6MroOp6Y/wg0 gX8AoI3IQkbRH+Z8x8AxnU3gZNIVZMLe =bHTc -----END PGP SIGNATURE----- --=-=-=-- --===============1344166240== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1344166240==--