From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D35FC43334 for ; Tue, 28 Jun 2022 04:48:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AEA7210F6A0; Tue, 28 Jun 2022 04:48:28 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id CEF1D10F6A0; Tue, 28 Jun 2022 04:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656391707; x=1687927707; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=wNfXW2MzaIVb4DUflJxU2xU8wT+mMA+IL8ui+9twJ58=; b=lHOLpLDKYS9KGTGP3TOJPhLP9WTVGRLRL8BOwppl8YNUkEcRyQtzY5MX YO7MWotuEK0z7mi0IajGB1Vp6agqY7D7PEezhTeCEDM1KbNJKdttSsu4a 0w22ZGlr0jbuC3bJXi39zJOjCZhuE8V8o9WYzFP35ScMw/CMJ0naszQaJ pULsRzrccT67damHyxVPeaTcdkxmwX8gqLJ0r1d399WyKKFWkZ4FoGMW7 fMFAp8EpJQFHJPEVQhSuktOZslLWtwH/s/Ga40IAFn1pQjL1SpcuCWeaG Qmc99JEcKNiizBsDUxL/rj6J1VvhP1EpVr4xWL1km1NAulauNUeTYXHqE A==; X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="345630796" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="345630796" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 21:48:27 -0700 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="717304725" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.15.219]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 21:48:27 -0700 Date: Mon, 27 Jun 2022 21:48:27 -0700 Message-ID: <87h745pf50.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Vinay Belgaumkar In-Reply-To: <20220627230346.27720-1-vinay.belgaumkar@intel.com> References: <20220627230346.27720-1-vinay.belgaumkar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 27 Jun 2022 16:03:46 -0700, Vinay Belgaumkar wrote: > > /* Actual frequency should rise above min */ > - if (max_act_freq == slpc_min_freq) { > + if (max_act_freq <= slpc_min_freq) { > pr_err("Actual freq did not rise above min\n"); > + pr_err("Perf Limit Reasons: 0x%x\n", > + intel_uncore_read(gt->uncore, GT0_PERF_LIMIT_REASONS)); > err = -EINVAL; > } Maybe to be clear, we should combine these two pr_err's into a single pr_err. In any case this patch is: Reviewed-by: Ashutosh Dixit