From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEA1AC433EF for ; Mon, 4 Oct 2021 07:46:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 915316136F for ; Mon, 4 Oct 2021 07:46:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 915316136F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB3C86E949; Mon, 4 Oct 2021 07:46:01 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A9046E949 for ; Mon, 4 Oct 2021 07:46:00 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10126"; a="222773944" X-IronPort-AV: E=Sophos;i="5.85,345,1624345200"; d="scan'208";a="222773944" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 00:45:58 -0700 X-IronPort-AV: E=Sophos;i="5.85,345,1624345200"; d="scan'208";a="712312251" Received: from pmittal1-mobl.gar.corp.intel.com (HELO localhost) ([10.251.223.27]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 00:45:52 -0700 From: Jani Nikula To: "Saarinen\, Jani" , Dave Airlie , Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Intel Graphics Development , Dave Airlie , "Sarvela\, Tomi P" In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <41c3e1896162fc08e22e40b00642791365a8c00e.1632869550.git.jani.nikula@intel.com> Date: Mon, 04 Oct 2021 10:45:49 +0300 Message-ID: <87h7dx2pxu.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 04 Oct 2021, "Saarinen, Jani" wrote: >> -----Original Message----- >> From: Intel-gfx On Behalf Of D= ave Airlie >> Sent: maanantai 4. lokakuuta 2021 3.33 >> To: Ville Syrj=C3=A4l=C3=A4 >> Cc: Nikula, Jani ; Intel Graphics Development > gfx@lists.freedesktop.org>; Dave Airlie ; Sarvela, T= omi P >> >> Subject: Re: [Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get= function >> into separate vfunc >> >> On Sun, 3 Oct 2021 at 05:27, Ville Syrj=C3=A4l=C3=A4 wrote: >> > >> > On Wed, Sep 29, 2021 at 01:57:45AM +0300, Jani Nikula wrote: >> > > From: Dave Airlie >> > > >> > > constify it while here. drop the put function since it was never >> > > overloaded and always has done the same thing, no point in >> > > indirecting it for show. >> > > >> > > Reviewed-by: Jani Nikula >> > > Signed-off-by: Dave Airlie >> > > Signed-off-by: Jani Nikula >> > >> > This has totally broken snb and ivb machines. Total death ensues >> > somewhere in uncore init after some backtraces fly by. >> > Didn't get any logs out to disk unfortunately. Please revert. >> > >> > Sadly CI is still afraid to report when machines disappear. >> > For the bat report you at least get a list of machines that were awol, >> > but the shard run seems to not even mention that all snbs suddenly >> > vanished. >> > >> > I've said it before and I'll say it again. We really should >> > *not* be loading i915 when the machine boots. That way we'd at least >> > get the machine up and running and can report that loading i915 is the >> > thing that killed it... >> >> That is frustrating, I've sent a oneline fix that should fix it up. >> hopefully CI will pick it up. > It seems it did (this for ivb, snb only): > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21231/index.html?hosts= =3Dsnb%7Civb Pushed now. BR, Jani. > >> >> Dave. --=20 Jani Nikula, Intel Open Source Graphics Center