intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Chris Chiu <chiu@endlessm.com>
Subject: Re: [PATCH] drm/i915: delay hotplug scheduling
Date: Wed, 26 Sep 2018 10:06:56 +0300	[thread overview]
Message-ID: <87h8icvisv.fsf@intel.com> (raw)
In-Reply-To: <153786495402.21139.6159886314109961422@skylake-alporthouse-com>

On Tue, 25 Sep 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2018-09-25 08:18:36)
>> On some systems we get the hotplug irq on unplug before the DDC pins
>> have been disconnected, resulting in connector status remaining
>> connected. Since previous attempts at using hotplug live status before
>> DDC have failed, the only viable option is to reduce the window for
>> mistakes. Delay the hotplug processing.
>
> The only concern I would raise is there some expectation for latency of
> hotplug? 300ms doesn't seem like it would irk the user -- it won't be
> noticeable unless using a kvm or equivalent. I would be more concerned
> if there was a line in the conformance tests that expect a response to a
> hotplug interrupt within a certain time window.

Frankly, I don't know. But I suppose a conformance test like that would
like the retry approach even less?

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-09-26  7:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25  7:18 [PATCH] drm/i915: delay hotplug scheduling Jani Nikula
2018-09-25  7:30 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-09-25  7:51 ` ✓ Fi.CI.BAT: success " Patchwork
2018-09-25  8:42 ` [PATCH] " Chris Wilson
2018-09-26  7:06   ` Jani Nikula [this message]
2018-09-26 10:35     ` Chris Wilson
2018-09-25  8:54 ` ✓ Fi.CI.IGT: success for " Patchwork
2018-09-26 23:44 ` [PATCH] " Guang Bai
2018-09-27  0:43   ` Guang Bai
2018-09-27  6:45     ` Jani Nikula
2018-09-27 16:49       ` Guang Bai
2018-09-28  6:26         ` Jani Nikula
2018-09-28 15:36           ` Guang Bai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8icvisv.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=chiu@endlessm.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).