From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915/ringbuffer: Move double invalidate to after pd flush Date: Tue, 04 Sep 2018 16:22:17 +0300 Message-ID: <87h8j55ree.fsf@gaia.fi.intel.com> References: <20180904063802.13880-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id D669789915 for ; Tue, 4 Sep 2018 13:22:24 +0000 (UTC) In-Reply-To: <20180904063802.13880-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQ29udGlu dWluZyB0aGUgZnVuIG9mIHRyeWluZyB0byBmaW5kIGV4YWN0bHkgdGhlIGRlbGF5IHRoYXQgaXMK PiBzdWZmaWNpZW50IHRvIGVuc3VyZSB0aGF0IHRoZSBwYWdlIGRpcmVjdG9yeSBpcyBmdWxseSBs b2FkZWQgYmV0d2Vlbgo+IGNvbnRleHQgc3dpdGNoZXMsIG1vdmUgdGhlIGV4dHJhIGZsdXNoIGFk ZGVkIGluIGNvbW1pdCA3MGI3M2Y5YWMxMTMKPiAoImRybS9pOTE1L3JpbmdidWZmZXI6IERlbGF5 IGFmdGVyIGludmFsaWRhdGluZyBnZW42KyB4Y3MiKSB0byBqdXN0Cj4gYWZ0ZXIgd2UgZmx1c2gg dGhlIHBkLiBFbnRpcmVseSBiYXNlZCBvbiB0aGUgZW1waXJpY2FsIGRhdGEgb2YgcnVubmluZwo+ IGZhaWxpbmcgdGVzdHMgaW4gYSBsb29wIHVudGlsIHdlIHN1cnZpdmUgYSBkYXkgKGJlZm9yZSB0 aGUgbXRiZiBpcyAxMC0zMAo+IG1pbnV0ZXMpLgo+Cj4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5m cmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzc2OQo+IFJlZmVyZW5jZXM6IDcwYjcz ZjlhYzExMyAoImRybS9pOTE1L3JpbmdidWZmZXI6IERlbGF5IGFmdGVyIGludmFsaWRhdGluZyBn ZW42KyB4Y3MiKQo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2ls c29uLmNvLnVrPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVy LmMgfCA0MCArKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMiBp bnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9yaW5nYnVmZmVyLmMKPiBpbmRleCA4NjYwNGRkMWM1YTUuLjQ3MjkzOWY1YzE4ZiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBAQCAtMTcwNyw5ICsxNzA3 LDI5IEBAIHN0YXRpYyBpbnQgc3dpdGNoX2NvbnRleHQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEp Cj4gIAl9Cj4gIAo+ICAJaWYgKHBwZ3R0KSB7Cj4gKwkJcmV0ID0gZW5naW5lLT5lbWl0X2ZsdXNo KHJxLCBFTUlUX0lOVkFMSURBVEUpOwo+ICsJCWlmIChyZXQpCj4gKwkJCWdvdG8gZXJyX21tOwo+ ICsKPiAgCQlyZXQgPSBmbHVzaF9wZF9kaXIocnEpOwo+ICAJCWlmIChyZXQpCj4gIAkJCWdvdG8g ZXJyX21tOwo+ICsKPiArCQkvKgo+ICsJCSAqIE5vdCBvbmx5IGRvIHdlIG5lZWQgYSBmdWxsIGJh cnJpZXIgKHBvc3Qtc3luYyB3cml0ZSkgYWZ0ZXIKPiArCQkgKiBpbnZhbGlkYXRpbmcgdGhlIFRM QnMsIGJ1dCB3ZSBuZWVkIHRvIHdhaXQgYSBsaXR0bGUgYml0Cj4gKwkJICogbG9uZ2VyLiBXaGV0 aGVyIHRoaXMgaXMgbWVyZWx5IGRlbGF5aW5nIHVzLCBvciB0aGUKPiArCQkgKiBzdWJzZXF1ZW50 IGZsdXNoIGlzIGEga2V5IHBhcnQgb2Ygc2VyaWFsaXNpbmcgd2l0aCB0aGUKPiArCQkgKiBwb3N0 LXN5bmMgb3AsIHRoaXMgZXh0cmEgcGFzcyBhcHBlYXJzIHZpdGFsIGJlZm9yZSBhCj4gKwkJICog bW0gc3dpdGNoIQo+ICsJCSAqLwo+ICsJCXJldCA9IGVuZ2luZS0+ZW1pdF9mbHVzaChycSwgRU1J VF9JTlZBTElEQVRFKTsKPiArCQlpZiAocmV0KQo+ICsJCQlnb3RvIGVycl9tbTsKPiArCj4gKwkJ cmV0ID0gZW5naW5lLT5lbWl0X2ZsdXNoKHJxLCBFTUlUX0ZMVVNIKTsKPiArCQlpZiAocmV0KQo+ ICsJCQlnb3RvIGVycl9tbTsKClNvbWVvbmUgc2FpZCB0aGF0IHByb29mIGlzIGluIHRoZSBwdWRk aW5nLiBKdXN0IGNvdWxkCmJlIG1vcmUgZnVuIGlmIHNvbWVvbmUgd291bGQgc2hvdyB1cyB0aGUg cmVjaXBlLgoKQWNrZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50 ZWwuY29tPgoKCj4gIAl9Cj4gIAo+ICAJaWYgKGN0eC0+cmVtYXBfc2xpY2UpIHsKPiBAQCAtMTk0 Nyw3ICsxOTY3LDcgQEAgc3RhdGljIHZvaWQgZ2VuNl9ic2Rfc3VibWl0X3JlcXVlc3Qoc3RydWN0 IGk5MTVfcmVxdWVzdCAqcmVxdWVzdCkKPiAgCWludGVsX3VuY29yZV9mb3JjZXdha2VfcHV0KGRl dl9wcml2LCBGT1JDRVdBS0VfQUxMKTsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBlbWl0X21pX2Zs dXNoX2R3KHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLCB1MzIgZmxhZ3MpCj4gK3N0YXRpYyBpbnQg bWlfZmx1c2hfZHcoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEsIHUzMiBmbGFncykKPiAgewo+ICAJ dTMyIGNtZCwgKmNzOwo+ICAKPiBAQCAtMTk4NSwyMyArMjAwNSw3IEBAIHN0YXRpYyBpbnQgZW1p dF9taV9mbHVzaF9kdyhzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSwgdTMyIGZsYWdzKQo+ICAKPiAg c3RhdGljIGludCBnZW42X2ZsdXNoX2R3KHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLCB1MzIgbW9k ZSwgdTMyIGludmZsYWdzKQo+ICB7Cj4gLQlpbnQgZXJyOwo+IC0KPiAtCS8qCj4gLQkgKiBOb3Qg b25seSBkbyB3ZSBuZWVkIGEgZnVsbCBiYXJyaWVyIChwb3N0LXN5bmMgd3JpdGUpIGFmdGVyCj4g LQkgKiBpbnZhbGlkYXRpbmcgdGhlIFRMQnMsIGJ1dCB3ZSBuZWVkIHRvIHdhaXQgYSBsaXR0bGUg Yml0Cj4gLQkgKiBsb25nZXIuIFdoZXRoZXIgdGhpcyBpcyBtZXJlbHkgZGVsYXlpbmcgdXMsIG9y IHRoZQo+IC0JICogc3Vic2VxdWVudCBmbHVzaCBpcyBhIGtleSBwYXJ0IG9mIHNlcmlhbGlzaW5n IHdpdGggdGhlCj4gLQkgKiBwb3N0LXN5bmMgb3AsIHRoaXMgZXh0cmEgcGFzcyBhcHBlYXJzIHZp dGFsIGJlZm9yZSBhCj4gLQkgKiBtbSBzd2l0Y2ghCj4gLQkgKi8KPiAtCWlmIChtb2RlICYgRU1J VF9JTlZBTElEQVRFKSB7Cj4gLQkJZXJyID0gZW1pdF9taV9mbHVzaF9kdyhycSwgaW52ZmxhZ3Mp Owo+IC0JCWlmIChlcnIpCj4gLQkJCXJldHVybiBlcnI7Cj4gLQl9Cj4gLQo+IC0JcmV0dXJuIGVt aXRfbWlfZmx1c2hfZHcocnEsIDApOwo+ICsJcmV0dXJuIG1pX2ZsdXNoX2R3KHJxLCBtb2RlICYg RU1JVF9JTlZBTElEQVRFID8gaW52ZmxhZ3MgOiAwKTsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBn ZW42X2JzZF9yaW5nX2ZsdXNoKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLCB1MzIgbW9kZSkKPiAt LSAKPiAyLjE5LjAucmMxCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==