From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/5] drm/i915: Suspend submission tasklets around wedging Date: Fri, 02 Mar 2018 16:34:15 +0200 Message-ID: <87h8pypmvs.fsf@gaia.fi.intel.com> References: <20180302143246.2579-1-chris@chris-wilson.co.uk> <20180302143246.2579-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id B547F6E0E2 for ; Fri, 2 Mar 2018 14:38:51 +0000 (UTC) In-Reply-To: <20180302143246.2579-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQWZ0ZXIg c3RhcnRpbmcgaGFyZCBhdCBzZXF1ZW5jZXMgbGlrZQoKUGVyaGFwcyB5b3UgbWVhbnQgc3Rhcmlu ZywgYnV0IHN0YXJ0aW5nIGlzIGZpbmUgdG9vLgotTWlrYQoKPgo+IFsgICAyOC4xOTkwMTNdICBz eXN0ZW1kLTEgICAgICAgMi4ucy4gMjYwNjIyMjh1cyA6IGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rh c2tsZXQ6IHJjczAgY3MtaXJxIGhlYWQ9MCBbMD9dLCB0YWlsPTEgWzE/XQo+IFsgICAyOC4xOTkw OTVdICBzeXN0ZW1kLTEgICAgICAgMi4ucy4gMjYwNjIyMjl1cyA6IGV4ZWNsaXN0c19zdWJtaXNz aW9uX3Rhc2tsZXQ6IHJjczAgY3NiWzFdOiBzdGF0dXM9MHgwMDAwMDAxODoweDAwMDAwMDAwLCBh Y3RpdmU9MHgxCj4gWyAgIDI4LjE5OTE3N10gIHN5c3RlbWQtMSAgICAgICAyLi5zLiAyNjA2MjIz MHVzIDogZXhlY2xpc3RzX3N1Ym1pc3Npb25fdGFza2xldDogcmNzMCBvdXRbMF06IGN0eD0wLjEs IHNlcW5vPTMsIHByaW89LTEwMjQKPiBbICAgMjguMTk5MjU4XSAgc3lzdGVtZC0xICAgICAgIDIu LnMuIDI2MDYyMjMxdXMgOiBleGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0OiByY3MwIGNvbXBs ZXRlZCBjdHg9MAo+IFsgICAyOC4xOTkzNDBdICBnZW1fZWlvLTgyOSAgICAgMS4uczEgMjYwNjY4 NTN1cyA6IGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rhc2tsZXQ6IHJjczAgaW5bMF06ICBjdHg9MS4x LCBzZXFubz0xLCBwcmlvPTAKPiBbICAgMjguMTk5NDIxXSAgIDxpZGxlPi0wICAgICAgIDIuLnMu IDI2MDY2ODYzdXMgOiBleGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0OiByY3MwIGNzLWlycSBo ZWFkPTEgWzE/XSwgdGFpbD0yIFsyP10KPiBbICAgMjguMTk5NTAzXSAgIDxpZGxlPi0wICAgICAg IDIuLnMuIDI2MDY2ODY1dXMgOiBleGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0OiByY3MwIGNz YlsyXTogc3RhdHVzPTB4MDAwMDAwMDE6MHgwMDAwMDAwMCwgYWN0aXZlPTB4MQo+IFsgICAyOC4x OTk1ODVdICBnZW1fZWlvLTgyOSAgICAgMS4uczEgMjYwNjcwNzd1cyA6IGV4ZWNsaXN0c19zdWJt aXNzaW9uX3Rhc2tsZXQ6IHJjczAgaW5bMV06ICBjdHg9My4xLCBzZXFubz0yLCBwcmlvPTAKPiBb ICAgMjguMTk5NjY3XSAgZ2VtX2Vpby04MjkgICAgIDEuLnMxIDI2MDY3MDc4dXMgOiBleGVjbGlz dHNfc3VibWlzc2lvbl90YXNrbGV0OiByY3MwIGluWzBdOiAgY3R4PTEuMiwgc2Vxbm89MSwgcHJp bz0wCj4gWyAgIDI4LjE5OTc0OV0gICA8aWRsZT4tMCAgICAgICAyLi5zLiAyNjA2NzA4NHVzIDog ZXhlY2xpc3RzX3N1Ym1pc3Npb25fdGFza2xldDogcmNzMCBjcy1pcnEgaGVhZD0yIFsyP10sIHRh aWw9MyBbMz9dCj4gWyAgIDI4LjE5OTgzMF0gICA8aWRsZT4tMCAgICAgICAyLi5zLiAyNjA2NzA4 NXVzIDogZXhlY2xpc3RzX3N1Ym1pc3Npb25fdGFza2xldDogcmNzMCBjc2JbM106IHN0YXR1cz0w eDAwMDA4MDAyOjB4MDAwMDAwMDEsIGFjdGl2ZT0weDEKPiBbICAgMjguMTk5OTEyXSAgIDxpZGxl Pi0wICAgICAgIDIuLnMuIDI2MDY3MDg2dXMgOiBleGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0 OiByY3MwIG91dFswXTogY3R4PTEuMiwgc2Vxbm89MSwgcHJpbz0wCj4gWyAgIDI4LjE5OTk5NF0g IGdlbV9laW8tODI5ICAgICAyLi5zLiAyODI0NjA4NHVzIDogZXhlY2xpc3RzX3N1Ym1pc3Npb25f dGFza2xldDogcmNzMCBjcy1pcnEgaGVhZD0zIFszP10sIHRhaWw9NCBbND9dCj4gWyAgIDI4LjIw MDA5Nl0gIGdlbV9laW8tODI5ICAgICAyLi5zLiAyODI0NjA4OHVzIDogZXhlY2xpc3RzX3N1Ym1p c3Npb25fdGFza2xldDogcmNzMCBjc2JbNF06IHN0YXR1cz0weDAwMDAwMDE0OjB4MDAwMDAwMDEs IGFjdGl2ZT0weDUKPiBbICAgMjguMjAwMTc4XSAgZ2VtX2Vpby04MjkgICAgIDIuLnMuIDI4MjQ2 MDg5dXMgOiBleGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0OiByY3MwIG91dFswXTogY3R4PTAu MCwgc2Vxbm89MCwgcHJpbz0wCj4gWyAgIDI4LjIwMDI2MF0gIGdlbV9laW8tODI5ICAgICAyLi5z LiAyODI0NjEyN3VzIDogZXhlY2xpc3RzX3N1Ym1pc3Npb25fdGFza2xldDogZXhlY2xpc3RzX3N1 Ym1pc3Npb25fdGFza2xldDo4ODYgR0VNX0JVR19PTihidWZbMiAqIGhlYWQgKyAxXSAhPSBwb3J0 LT5jb250ZXh0X2lkKQo+Cj4gdGhlIGNvbmNsdXNpb24gaXMgdGhhdCB0aGUgb25seSBwbGFjZSB3 aGVyZSB0aGUgcG9ydHMgYXJlIHJlc2V0IHRvIHplcm8sCj4gaXMgZnJvbSBlbmdpbmUtPmNhbmNl bF9yZXF1ZXN0cyBjYWxsZWQgZHVyaW5nIGk5MTVfZ2VtX3NldF93ZWRnZWQoKS4KPgo+IFRoZSBy YWNlIGlzIGhvcnJpYmxlIGFzIGl0IHJlc3VsdHMgZnJvbSBjYWxsaW5nIHNldC13ZWRnZWQgb24g YWN0aXZlIEhXCj4gKHRoZSBHUFUgcmVzZXQgZmFpbGVkKSBhbmQgYXMgc3VjaCB3ZSBuZWVkIHRv IGJlIGNhcmVmdWwgYXMgdGhlIEhXIHN0YXRlCj4gY2hhbmdlcyBiZW5lYXRoIHVzLiBGb3J0dW5h dGVseSwgaXQncyB0aGUgc2FtZSBzY2FyeSBjb25kaXRpb25zIGFzCj4gYWZmZWN0IG5vcm1hbCBy ZXNldCwgc28gd2UgY2FuIHJldXNlIHRoZSBzYW1lIG1hY2hpbmVyeSB0byBkaXNhYmxlIHN0YXRl Cj4gdHJhY2tpbmcgYXMgd2UgY2xvYmJlciBpdC4KPgo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3Mu ZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQ5NDUKPiBTaWduZWQtb2ZmLWJ5OiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWlrYSBLdW9wcGFs YSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IE1pY2hlbCBUaGllcnJ5IDxt aWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4gRml4ZXM6IGFmN2E4ZmZhZDljNSAoImRybS9pOTE1 OiBVc2UgcmN1IGluc3RlYWQgb2Ygc3RvcF9tYWNoaW5lIGluIHNldF93ZWRnZWQiKQo+IFJldmll d2VkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiBM aW5rOiBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvbXNnaWQvMjAxODAz MDIxMTMzMjQuMjMxODktMi1jaHJpc0BjaHJpcy13aWxzb24uY28udWsKPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgfCA2ICsrKysrLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9scmMuYyB8IDUgKysrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCBj MjliMWExY2JlOTYuLmRjZGNjMDkyNDBiOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ IEBAIC0zMjEyLDggKzMyMTIsMTAgQEAgdm9pZCBpOTE1X2dlbV9zZXRfd2VkZ2VkKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAJICogcm9sbGluZyB0aGUgZ2xvYmFsIHNlcW5vIGZv cndhcmQgKHNpbmNlIHRoaXMgd291bGQgY29tcGxldGUgcmVxdWVzdHMKPiAgCSAqIGZvciB3aGlj aCB3ZSBoYXZlbid0IHNldCB0aGUgZmVuY2UgZXJyb3IgdG8gRUlPIHlldCkuCj4gIAkgKi8KPiAt CWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGk5MTUsIGlkKQo+ICsJZm9yX2VhY2hfZW5naW5lKGVu Z2luZSwgaTkxNSwgaWQpIHsKPiArCQlpOTE1X2dlbV9yZXNldF9wcmVwYXJlX2VuZ2luZShlbmdp bmUpOwo+ICAJCWVuZ2luZS0+c3VibWl0X3JlcXVlc3QgPSBub3Bfc3VibWl0X3JlcXVlc3Q7Cj4g Kwl9Cj4gIAo+ICAJLyoKPiAgCSAqIE1ha2Ugc3VyZSBubyBvbmUgaXMgcnVubmluZyB0aGUgb2xk IGNhbGxiYWNrIGJlZm9yZSB3ZSBwcm9jZWVkIHdpdGgKPiBAQCAtMzI1NSw2ICszMjU3LDggQEAg dm9pZCBpOTE1X2dlbV9zZXRfd2VkZ2VkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ ICAJCWludGVsX2VuZ2luZV9pbml0X2dsb2JhbF9zZXFubyhlbmdpbmUsCj4gIAkJCQkJICAgICAg IGludGVsX2VuZ2luZV9sYXN0X3N1Ym1pdChlbmdpbmUpKTsKPiAgCQlzcGluX3VubG9ja19pcnFy ZXN0b3JlKCZlbmdpbmUtPnRpbWVsaW5lLT5sb2NrLCBmbGFncyk7Cj4gKwo+ICsJCWk5MTVfZ2Vt X3Jlc2V0X2ZpbmlzaF9lbmdpbmUoZW5naW5lKTsKPiAgCX0KPiAgCj4gIAl3YWtlX3VwX2FsbCgm aTkxNS0+Z3B1X2Vycm9yLnJlc2V0X3F1ZXVlKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ IGluZGV4IDE0Mjg4NzQzOTA5Zi4uYzFhMzYzNmU5NGZjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHJjLmMKPiBAQCAtNjg3LDYgKzY4Nyw4IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19jYW5j ZWxfcmVxdWVzdHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJc3RydWN0IHJi X25vZGUgKnJiOwo+ICAJdW5zaWduZWQgbG9uZyBmbGFnczsKPiAgCj4gKwlHRU1fVFJBQ0UoIiVz XG4iLCBlbmdpbmUtPm5hbWUpOwo+ICsKPiAgCXNwaW5fbG9ja19pcnFzYXZlKCZlbmdpbmUtPnRp bWVsaW5lLT5sb2NrLCBmbGFncyk7Cj4gIAo+ICAJLyogQ2FuY2VsIHRoZSByZXF1ZXN0cyBvbiB0 aGUgSFcgYW5kIGNsZWFyIHRoZSBFTFNQIHRyYWNrZXIuICovCj4gQEAgLTczMyw2ICs3MzUsOSBA QCBzdGF0aWMgdm9pZCBleGVjbGlzdHNfY2FuY2VsX3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKmVuZ2luZSkKPiAgCSAqLwo+ICAJY2xlYXJfYml0KEVOR0lORV9JUlFfRVhFQ0xJU1Qs ICZlbmdpbmUtPmlycV9wb3N0ZWQpOwo+ICAKPiArCS8qIE1hcmsgYWxsIENTIGludGVycnVwdHMg YXMgY29tcGxldGUgKi8KPiArCWV4ZWNsaXN0cy0+YWN0aXZlID0gMDsKPiArCj4gIAlzcGluX3Vu bG9ja19pcnFyZXN0b3JlKCZlbmdpbmUtPnRpbWVsaW5lLT5sb2NrLCBmbGFncyk7Cj4gIH0KPiAg Cj4gLS0gCj4gMi4xNi4yCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=