From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH v2 9/9] drm/i915: Split intel_enable_ddi()
	into	DP and HDMI variants
Date: Wed, 11 Oct 2017 23:06:07 +0300
Message-ID: <87h8v5o3f4.fsf@intel.com>
References: <20171010121207.570-1-ville.syrjala@linux.intel.com>
 <20171010121207.570-10-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 189166E0D7
 for <intel-gfx@lists.freedesktop.org>; Wed, 11 Oct 2017 20:06:24 +0000 (UTC)
In-Reply-To: <20171010121207.570-10-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCAxMCBPY3QgMjAxNywgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p
bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs
aW51eC5pbnRlbC5jb20+Cj4KPiBVbnRhbmdsZSBpbnRlbF9lbmFibGVfZGRpKCkgYnkgc3BsaXR0
aW5nIGl0IGludG8gRFAgYW5kIEhETUkgc3BlY2lmaWMKPiB2YXJpYW50cy4KPgo+IHYyOiBLZWVw
IHVzaW5nIGludGVsX2RkaV9nZXRfZW5jb2Rlcl9wb3J0KCkgZm9yIG5vdwo+Cj4gU2lnbmVkLW9m
Zi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAt
LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgfCA4NiArKysrKysrKysrKysr
KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0OSBpbnNlcnRp
b25zKCspLCAzNyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gaW5k
ZXggNDljZjhkOWQyYmMxLi4xOGJmMDZjN2U0M2YgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
ZGkuYwo+IEBAIC0yMzY5LDQ1ICsyMzY5LDU3IEBAIHZvaWQgaW50ZWxfZGRpX2ZkaV9wb3N0X2Rp
c2FibGUoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAlJOTE1X1dSSVRFKEZESV9S
WF9DVEwoUElQRV9BKSwgdmFsKTsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxl
X2RkaShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqaW50ZWxfZW5jb2RlciwKPiAtCQkJICAgICBjb25z
dCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gK3N0YXRpYyB2b2lkIGlu
dGVsX2VuYWJsZV9kZGlfZHAoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gKwkJCQlj
b25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiArCQkJCWNvbnN0IHN0
cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJt
X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGVuY29kZXItPmJhc2UuZGV2KTsKPiAr
CXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAgPSBlbmNfdG9faW50ZWxfZHAoJmVuY29kZXItPmJh
c2UpOwo+ICsJZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kZGlfZ2V0X2VuY29kZXJfcG9ydChlbmNv
ZGVyKTsKPiArCj4gKwlpZiAocG9ydCA9PSBQT1JUX0EgJiYgSU5URUxfR0VOKGRldl9wcml2KSA8
IDkpCj4gKwkJaW50ZWxfZHBfc3RvcF9saW5rX3RyYWluKGludGVsX2RwKTsKPiArCj4gKwlpbnRl
bF9lZHBfYmFja2xpZ2h0X29uKGNydGNfc3RhdGUsIGNvbm5fc3RhdGUpOwo+ICsJaW50ZWxfcHNy
X2VuYWJsZShpbnRlbF9kcCwgY3J0Y19zdGF0ZSk7CgpUaGlzIGlzIGJyb2tlbiB3aXRob3V0IGVk
cCBjaGVjay4KCkJSLApKYW5pLgoKCj4gKwlpbnRlbF9lZHBfZHJyc19lbmFibGUoaW50ZWxfZHAs
IGNydGNfc3RhdGUpOwo+ICsKPiArCWlmIChjcnRjX3N0YXRlLT5oYXNfYXVkaW8pCj4gKwkJaW50
ZWxfYXVkaW9fY29kZWNfZW5hYmxlKGVuY29kZXIsIGNydGNfc3RhdGUsIGNvbm5fc3RhdGUpOwo+
ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBpbnRlbF9lbmFibGVfZGRpX2hkbWkoc3RydWN0IGludGVs
X2VuY29kZXIgKmVuY29kZXIsCj4gKwkJCQkgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl
ICpjcnRjX3N0YXRlLAo+ICsJCQkJICBjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAq
Y29ubl9zdGF0ZSkKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g
dG9faTkxNShlbmNvZGVyLT5iYXNlLmRldik7Cj4gKwlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0
ICpkaWdfcG9ydCA9IGVuY190b19kaWdfcG9ydCgmZW5jb2Rlci0+YmFzZSk7Cj4gKwllbnVtIHBv
cnQgcG9ydCA9IGludGVsX2RkaV9nZXRfZW5jb2Rlcl9wb3J0KGVuY29kZXIpOwo+ICsKPiArCWlu
dGVsX2hkbWlfaGFuZGxlX3Npbmtfc2NyYW1ibGluZyhlbmNvZGVyLAo+ICsJCQkJCSAgY29ubl9z
dGF0ZS0+Y29ubmVjdG9yLAo+ICsJCQkJCSAgY3J0Y19zdGF0ZS0+aGRtaV9oaWdoX3RtZHNfY2xv
Y2tfcmF0aW8sCj4gKwkJCQkJICBjcnRjX3N0YXRlLT5oZG1pX3NjcmFtYmxpbmcpOwo+ICsKPiAr
CS8qIEluIEhETUkvRFZJIG1vZGUsIHRoZSBwb3J0IHdpZHRoLCBhbmQgc3dpbmcvZW1waGFzaXMg
dmFsdWVzCj4gKwkgKiBhcmUgaWdub3JlZCBzbyBub3RoaW5nIHNwZWNpYWwgbmVlZHMgdG8gYmUg
ZG9uZSBiZXNpZGVzCj4gKwkgKiBlbmFibGluZyB0aGUgcG9ydC4KPiArCSAqLwo+ICsJSTkxNV9X
UklURShERElfQlVGX0NUTChwb3J0KSwKPiArCQkgICBkaWdfcG9ydC0+c2F2ZWRfcG9ydF9iaXRz
IHwgRERJX0JVRl9DVExfRU5BQkxFKTsKPiArCj4gKwlpZiAoY3J0Y19zdGF0ZS0+aGFzX2F1ZGlv
KQo+ICsJCWludGVsX2F1ZGlvX2NvZGVjX2VuYWJsZShlbmNvZGVyLCBjcnRjX3N0YXRlLCBjb25u
X3N0YXRlKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX2RkaShzdHJ1Y3Qg
aW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiArCQkJICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0
Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgCQkJICAgICBjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rv
cl9zdGF0ZSAqY29ubl9zdGF0ZSkKPiAgewo+IC0Jc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVy
ID0gJmludGVsX2VuY29kZXItPmJhc2U7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2
X3ByaXYgPSB0b19pOTE1KGVuY29kZXItPmRldik7Cj4gLQllbnVtIHBvcnQgcG9ydCA9IGludGVs
X2RkaV9nZXRfZW5jb2Rlcl9wb3J0KGludGVsX2VuY29kZXIpOwo+IC0JaW50IHR5cGUgPSBpbnRl
bF9lbmNvZGVyLT50eXBlOwo+IC0KPiAtCWlmICh0eXBlID09IElOVEVMX09VVFBVVF9IRE1JKSB7
Cj4gLQkJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQgPQo+IC0JCQll
bmNfdG9fZGlnX3BvcnQoZW5jb2Rlcik7Cj4gLQkJYm9vbCBjbG9ja19yYXRpbyA9IHBpcGVfY29u
ZmlnLT5oZG1pX2hpZ2hfdG1kc19jbG9ja19yYXRpbzsKPiAtCQlib29sIHNjcmFtYmxpbmcgPSBw
aXBlX2NvbmZpZy0+aGRtaV9zY3JhbWJsaW5nOwo+IC0KPiAtCQlpbnRlbF9oZG1pX2hhbmRsZV9z
aW5rX3NjcmFtYmxpbmcoaW50ZWxfZW5jb2RlciwKPiAtCQkJCQkJICBjb25uX3N0YXRlLT5jb25u
ZWN0b3IsCj4gLQkJCQkJCSAgY2xvY2tfcmF0aW8sIHNjcmFtYmxpbmcpOwo+IC0KPiAtCQkvKiBJ
biBIRE1JL0RWSSBtb2RlLCB0aGUgcG9ydCB3aWR0aCwgYW5kIHN3aW5nL2VtcGhhc2lzIHZhbHVl
cwo+IC0JCSAqIGFyZSBpZ25vcmVkIHNvIG5vdGhpbmcgc3BlY2lhbCBuZWVkcyB0byBiZSBkb25l
IGJlc2lkZXMKPiAtCQkgKiBlbmFibGluZyB0aGUgcG9ydC4KPiAtCQkgKi8KPiAtCQlJOTE1X1dS
SVRFKERESV9CVUZfQ1RMKHBvcnQpLAo+IC0JCQkgICBpbnRlbF9kaWdfcG9ydC0+c2F2ZWRfcG9y
dF9iaXRzIHwKPiAtCQkJICAgRERJX0JVRl9DVExfRU5BQkxFKTsKPiAtCX0gZWxzZSBpZiAodHlw
ZSA9PSBJTlRFTF9PVVRQVVRfRURQKSB7Cj4gLQkJc3RydWN0IGludGVsX2RwICppbnRlbF9kcCA9
IGVuY190b19pbnRlbF9kcChlbmNvZGVyKTsKPiAtCj4gLQkJaWYgKHBvcnQgPT0gUE9SVF9BICYm
IElOVEVMX0dFTihkZXZfcHJpdikgPCA5KQo+IC0JCQlpbnRlbF9kcF9zdG9wX2xpbmtfdHJhaW4o
aW50ZWxfZHApOwo+IC0KPiAtCQlpbnRlbF9lZHBfYmFja2xpZ2h0X29uKHBpcGVfY29uZmlnLCBj
b25uX3N0YXRlKTsKPiAtCQlpbnRlbF9wc3JfZW5hYmxlKGludGVsX2RwLCBwaXBlX2NvbmZpZyk7
Cj4gLQkJaW50ZWxfZWRwX2RycnNfZW5hYmxlKGludGVsX2RwLCBwaXBlX2NvbmZpZyk7Cj4gLQl9
Cj4gLQo+IC0JaWYgKHBpcGVfY29uZmlnLT5oYXNfYXVkaW8pCj4gLQkJaW50ZWxfYXVkaW9fY29k
ZWNfZW5hYmxlKGludGVsX2VuY29kZXIsIHBpcGVfY29uZmlnLCBjb25uX3N0YXRlKTsKPiArCWlm
IChpbnRlbF9jcnRjX2hhc190eXBlKGNydGNfc3RhdGUsIElOVEVMX09VVFBVVF9IRE1JKSkKPiAr
CQlpbnRlbF9lbmFibGVfZGRpX2hkbWkoZW5jb2RlciwgY3J0Y19zdGF0ZSwgY29ubl9zdGF0ZSk7
Cj4gKwllbHNlCj4gKwkJaW50ZWxfZW5hYmxlX2RkaV9kcChlbmNvZGVyLCBjcnRjX3N0YXRlLCBj
b25uX3N0YXRlKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaW50ZWxfZGlzYWJsZV9kZGlfZHAo
c3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9w
ZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz
LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp
c3RpbmZvL2ludGVsLWdmeAo=