Re: [PATCH] drm/i915: Use execlists_num_ports instead of size of array

[Mika Kuoppala <mika.kuoppala@linux.intel.com>]

Joonas Lahtinen <joonas.lahtinen@linux.intel.com> writes:

> On Tue, 2017-10-10 at 14:48 +0300, Mika Kuoppala wrote:
>> There is function to tell how many ports we have, so use it.
>> We still have direct relationship with array size and port count,
>> so no harm was done.
>> 
>> Fixes: 76e70087d360 ("drm/i915: Make execlist port count variable")
>> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> <SNIP>
>
>> +++ b/drivers/gpu/drm/i915/i915_guc_submission.c
>> @@ -500,7 +500,7 @@ static void i915_guc_submit(struct intel_engine_cs *engine)
>>  	const unsigned int engine_id = engine->id;
>>  	unsigned int n;
>>  
>> -	for (n = 0; n < ARRAY_SIZE(execlists->port); n++) {
>> +	for (n = 0; n < execlists_num_ports(execlists); n++) {
>
> For a while I was looking this delta in reverse and could not figure it
> out.
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>

I think I messed atleast on one of these missing on the countless
rebases.

Thanks for reviews. Pushed.
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx