From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 8/8] drm/i915: Keep track of reserved execlist ports
Date: Tue, 12 Sep 2017 13:29:48 +0300 [thread overview]
Message-ID: <87h8w82orn.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <150520822205.22039.3727686607588714175@mail.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2017-09-12 09:36:18)
>> +static inline unsigned int
>> +execlist_active_ports(const struct intel_engine_execlist * const el)
>> {
>> - const unsigned int i = port_index(port, el);
>> + return READ_ONCE(el->port_count);
>
> READ_ONCE? Could we separate the racy check from the serialized uses
> inside the tasklet where we do want the compiler to go to town?
Hmm so substitute execlist_active_ports() in i915_irq.c with
READ_ONCE(el->port_count) and remove it in this function?
-Mika
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-12 10:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 8:36 [PATCH 0/8] Support for more than two execlist ports Mika Kuoppala
2017-09-12 8:36 ` [PATCH 1/8] drm/i915: Make own struct for execlist items Mika Kuoppala
2017-09-12 10:14 ` Chris Wilson
2017-09-12 8:36 ` [PATCH 2/8] drm/i915: Wrap port cancellation into a function Mika Kuoppala
2017-09-12 10:15 ` Chris Wilson
2017-09-12 8:36 ` [PATCH 3/8] drm/i915: Add execlist_port_complete Mika Kuoppala
2017-09-12 10:19 ` Chris Wilson
2017-09-12 8:36 ` [PATCH 4/8] drm/i915: Make execlist port count variable Mika Kuoppala
2017-09-12 8:55 ` Chris Wilson
2017-09-12 10:24 ` Chris Wilson
2017-09-12 8:36 ` [PATCH 5/8] drm/i915: Introduce iterators for execlist ports Mika Kuoppala
2017-09-12 10:30 ` Chris Wilson
2017-09-12 10:36 ` Mika Kuoppala
2017-09-12 8:36 ` [PATCH 6/8] drm/i915: Introduce execlist_port_* accessors Mika Kuoppala
2017-09-12 10:37 ` Chris Wilson
2017-09-12 8:36 ` [PATCH 7/8] drm/i915: Move execlist initialization into intel_engine_cs.c Mika Kuoppala
2017-09-12 10:41 ` Chris Wilson
2017-09-12 8:36 ` [PATCH 8/8] drm/i915: Keep track of reserved execlist ports Mika Kuoppala
2017-09-12 9:15 ` Chris Wilson
2017-09-12 10:27 ` Mika Kuoppala
2017-09-12 10:51 ` Chris Wilson
2017-09-12 9:17 ` Chris Wilson
2017-09-12 9:19 ` Chris Wilson
2017-09-12 9:23 ` Chris Wilson
2017-09-12 10:29 ` Mika Kuoppala [this message]
2017-09-12 10:53 ` Chris Wilson
2017-09-12 9:35 ` Chris Wilson
2017-09-12 10:45 ` Chris Wilson
2017-09-12 8:59 ` ✓ Fi.CI.BAT: success for Support for more than two " Patchwork
2017-09-12 10:48 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8w82orn.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox