intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@intel.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/4] drm/i915: Set link status property for DP connector
Date: Mon, 31 Oct 2016 18:08:15 +0200	[thread overview]
Message-ID: <87h97slcwg.fsf@intel.com> (raw)
In-Reply-To: <1477703245-27375-3-git-send-email-manasi.d.navare@intel.com>

On Sat, 29 Oct 2016, Manasi Navare <manasi.d.navare@intel.com> wrote:
> This defines a helper function to set the property value.
> This will be used to set the link status to Bad in case
> of link training failures.
>
> v2:
> * Simplify the return value (Jani Nikula)
>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/intel_dp.c  | 11 +++++++++++
>  drivers/gpu/drm/i915/intel_drv.h |  2 ++
>  2 files changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 1063afe..2b6f51c 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4640,6 +4640,17 @@ static int intel_dp_get_modes(struct drm_connector *connector)
>  	return 0;
>  }
>  
> +int
> +intel_dp_set_link_status_property(struct drm_connector *connector,
> +				  uint64_t val)
> +{
> +	struct drm_device *dev = connector->dev;
> +
> +	return drm_object_property_set_value(&connector->base,
> +					     dev->mode_config.link_status_property,
> +					     val);
> +}
> +
>  static int
>  intel_dp_connector_register(struct drm_connector *connector)
>  {
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index 2616d92..3cb7481 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -1391,6 +1391,8 @@ u32 skl_plane_stride(const struct drm_framebuffer *fb, int plane,
>  bool intel_dp_init(struct drm_device *dev, i915_reg_t output_reg, enum port port);
>  bool intel_dp_init_connector(struct intel_digital_port *intel_dig_port,
>  			     struct intel_connector *intel_connector);
> +int intel_dp_set_link_status_property(struct drm_connector *connector,
> +				      uint64_t val);
>  void intel_dp_set_link_params(struct intel_dp *intel_dp,
>  			      int link_rate, uint8_t lane_count,
>  			      bool link_mst);

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-10-31 16:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-29  1:07 [PATCH v2 0/4] Handle link training failure during modeset for DDI Manasi Navare
2016-10-29  1:07 ` [PATCH v2 1/4] drm: Add a new connector property for link status Manasi Navare
2016-10-31 13:16   ` Jani Nikula
2016-10-31 21:29   ` [PATCH v3 " Manasi Navare
2016-11-09 13:45     ` Jani Nikula
2016-10-29  1:07 ` [PATCH v2 2/4] drm/i915: Set link status property for DP connector Manasi Navare
2016-10-31 16:08   ` Jani Nikula [this message]
2016-10-29  1:07 ` [PATCH v2 3/4] drm/i915: Find fallback link rate/lane count Manasi Navare
2016-10-29  1:07 ` [PATCH v2 4/4] drm/i915: Implement Link Rate fallback on Link training failure Manasi Navare
2016-11-01  8:49   ` Jani Nikula
2016-11-01 16:26     ` Manasi Navare
2016-11-01 19:16       ` Jani Nikula
2016-11-01 19:34         ` Manasi Navare
2016-11-02  0:29           ` Manasi Navare
2016-11-02 20:55   ` [PATCH v3 " Manasi Navare
2016-11-07 19:24     ` Manasi Navare
2016-11-09 13:07       ` Jani Nikula
2016-11-09 13:04     ` Jani Nikula
2016-11-09 22:05       ` Manasi Navare
2016-10-29  1:55 ` ✗ Fi.CI.BAT: failure for Handle link training failure during modeset for DDI Patchwork
2016-10-31 21:55 ` ✗ Fi.CI.BAT: failure for Handle link training failure during modeset for DDI (rev2) Patchwork
2016-11-02 21:24 ` ✗ Fi.CI.BAT: failure for Handle link training failure during modeset for DDI (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h97slcwg.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=manasi.d.navare@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).