From: Jani Nikula <jani.nikula@intel.com>
To: "Lee, Shawn C" <shawn.c.lee@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915 : Restore PWM_GRANULARITY after resume
Date: Mon, 19 Sep 2016 11:41:28 +0300 [thread overview]
Message-ID: <87h99cnux3.fsf@intel.com> (raw)
In-Reply-To: <1474275232-21478-1-git-send-email-shawn.c.lee@intel.com>
On Mon, 19 Sep 2016, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
> + if (HAS_PCH_LPT(dev_priv)) {
> + mul = I915_READ(SOUTH_CHICKEN2);
> + mul &= ~LPT_PWM_GRANULARITY;
> + I915_WRITE(SOUTH_CHICKEN2, mul | (panel->backlight.pwm_alternate_increment << LPT_PWM_GRANULARITY));
> + } else {
> + mul = I915_READ(SOUTH_CHICKEN1);
> + mul &= ~SPT_PWM_GRANULARITY;
> + I915_WRITE(SOUTH_CHICKEN1, mul | (panel->backlight.pwm_alternate_increment << SPT_PWM_GRANULARITY));
> + }
Also, both of the shifts are wrong here. The *_PWM_GRANULARITY macros
already contain the shifts.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-19 8:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 10:18 [PATCH] drm/i915 : Restore PWM_GRANULARITY after resume Lee, Shawn C
2016-09-08 10:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-09-09 7:46 ` [PATCH] " Jani Nikula
2016-09-19 8:53 ` [PATCH v2] " Lee, Shawn C
2016-09-19 8:38 ` Jani Nikula
2016-09-19 8:41 ` Jani Nikula [this message]
2016-09-19 10:30 ` kbuild test robot
2016-09-19 10:50 ` kbuild test robot
2016-09-19 9:56 ` [PATCH] " Lee, Shawn C
2016-09-19 9:42 ` Jani Nikula
2016-09-19 10:01 ` Lee, Shawn C
2016-09-19 10:20 ` ✓ Fi.CI.BAT: success for drm/i915 : Restore PWM_GRANULARITY after resume (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h99cnux3.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shawn.c.lee@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox