From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 11/11] drm/i915: Clean up .get_aux_clock_divider() functions Date: Tue, 01 Dec 2015 14:56:12 +0200 Message-ID: <87h9k249ar.fsf@intel.com> References: <1448893432-6978-1-git-send-email-ville.syrjala@linux.intel.com> <1448893432-6978-12-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 43B866E837 for ; Tue, 1 Dec 2015 04:52:07 -0800 (PST) In-Reply-To: <1448893432-6978-12-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAzMCBOb3YgMjAxNSwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pgo+IE5vdyB0aGF0IHRoZSBtZXNzIHdpdGggQVVYIGNsb2NrIGRpdmRlciByb3VuZGluZyBpcyBz b3J0ZWQgb3V0IGFuZAo+IHdlIGhhdmUgYm90aCBjZGNsayBhbmQgcmF3Y2xrIGNhY2hlZCBpbiBk ZXZfcHJpdiwgd2UgY2FuIGNsZWFuIHVwCj4gdGhlIC5nZXRfYXV4X2Nsb2NrX2RpdmlkZXIoKSBm dW5jdGlvbnMgYSBiaXQuCj4KPiBUaGUgbWFpbiB0aGluZyBoZXJlIGlzIGp1c3QgY2FsbGluZyBp bGtfZ2V0X2F1eF9jbG9ja19kaXZpZGVyKCkKPiBmcm9tIGhzd19nZXRfYXV4X2Nsb2NrX2Rpdmlk ZXIoKSBleGNlcHQgZm9yIHRoZSBMUFQ6SCBzcGVjaWFsCj4gY2FzZS4KPgo+IFdlIGNvdWxkIGdv dCBmdXJ0aGVyIGFuZCBjYWxsIGc0eF9nZXRfYXV4X2Nsb2NrX2RpdmlkZXIoKSBmcm9tCj4gaWxr X2dldF9hdXhfY2xvY2tfZGl2aWRlcigpIGZvciB0aGUgUENIIHBvcnRzLCBidXQgSSdtIHN1cmUg SmFuaQo+IHdvdWxkIG9iamVjdCwgc28gbGVhdmUgdGhhdCBiZS4KClRoYW5rcy4gOikKClJldmll d2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKCj4gV2hpbGUgYXQg aXQgcmVwZWF0IHRoZSBjb21tZW50IHdoZXJlIHRoZSBBVVggY2xvY2sgY29tZXMgZnJvbQo+IGlu IGlsa19nZXRfYXV4X2Nsb2NrX2RpdmlkZXIoKS4KPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCAyOCArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDM5YTE2ODliYWM3ZC4uZGY5ZmMzOTZkMThk IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTY3NywyMiArNjc3LDI5IEBAIHN0 YXRpYyB1aW50MzJfdCBnNHhfZ2V0X2F1eF9jbG9ja19kaXZpZGVyKHN0cnVjdCBpbnRlbF9kcCAq aW50ZWxfZHAsIGludCBpbmRleCkKPiAgCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVs X2RpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+ICAJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShpbnRlbF9kaWdfcG9ydC0+YmFzZS5iYXNlLmRl dik7Cj4gIAo+ICsJaWYgKGluZGV4KQo+ICsJCXJldHVybiAwOwo+ICsKPiAgCS8qCj4gIAkgKiBU aGUgY2xvY2sgZGl2aWRlciBpcyBiYXNlZCBvZmYgdGhlIGhyYXdjbGssIGFuZCB3b3VsZCBsaWtl IHRvIHJ1biBhdAo+IC0JICogMk1Iei4gIFNvLCB0YWtlIHRoZSBocmF3Y2xrIHZhbHVlIGFuZCBk aXZpZGUgYnkgMiBhbmQgdXNlIHRoYXQKPiArCSAqIDJNSHouICBTbywgdGFrZSB0aGUgaHJhd2Ns ayB2YWx1ZSBhbmQgZGl2aWRlIGJ5IDIwMDAgYW5kIHVzZSB0aGF0Cj4gIAkgKi8KPiAtCXJldHVy biBpbmRleCA/IDAgOiBESVZfUk9VTkRfQ0xPU0VTVChkZXZfcHJpdi0+cmF3Y2xrX2ZyZXEsIDIw MDApOwo+ICsJcmV0dXJuIERJVl9ST1VORF9DTE9TRVNUKGRldl9wcml2LT5yYXdjbGtfZnJlcSwg MjAwMCk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB1aW50MzJfdCBpbGtfZ2V0X2F1eF9jbG9ja19kaXZp ZGVyKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIGludCBpbmRleCkKPiAgewo+ICAJc3RydWN0 IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQgPSBkcF90b19kaWdfcG9ydChpbnRl bF9kcCk7Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gaW50ZWxfZGlnX3BvcnQtPmJhc2Uu YmFzZS5kZXY7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRl dl9wcml2YXRlOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx NShpbnRlbF9kaWdfcG9ydC0+YmFzZS5iYXNlLmRldik7Cj4gIAo+ICAJaWYgKGluZGV4KQo+ICAJ CXJldHVybiAwOwo+ICAKPiArCS8qCj4gKwkgKiBUaGUgY2xvY2sgZGl2aWRlciBpcyBiYXNlZCBv ZmYgdGhlIGNkY2xrIG9yIFBDSCByYXdjbGssIGFuZCB3b3VsZAo+ICsJICogbGlrZSB0byBydW4g YXQgMk1Iei4gIFNvLCB0YWtlIHRoZSBjZGNsayBvciBQQ0ggcmF3Y2xrIHZhbHVlIGFuZAo+ICsJ ICogZGl2aWRlIGJ5IDIwMDAgYW5kIHVzZSB0aGF0Cj4gKwkgKi8KPiAgCWlmIChpbnRlbF9kaWdf cG9ydC0+cG9ydCA9PSBQT1JUX0EpCj4gIAkJcmV0dXJuIERJVl9ST1VORF9DTE9TRVNUKGRldl9w cml2LT5jZGNsa19mcmVxLCAyMDAwKTsKPiAgCWVsc2UKPiBAQCAtNzAyLDIzICs3MDksMTggQEAg c3RhdGljIHVpbnQzMl90IGlsa19nZXRfYXV4X2Nsb2NrX2RpdmlkZXIoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCwgaW50IGluZGV4KQo+ICBzdGF0aWMgdWludDMyX3QgaHN3X2dldF9hdXhfY2xv Y2tfZGl2aWRlcihzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCBpbnQgaW5kZXgpCj4gIHsKPiAg CXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0gZHBfdG9fZGlnX3Bv cnQoaW50ZWxfZHApOwo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RpZ19wb3J0 LT5iYXNlLmJhc2UuZGV2Owo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0g ZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IHRvX2k5MTUoaW50ZWxfZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYpOwo+ICAKPiAtCWlmIChpbnRl bF9kaWdfcG9ydC0+cG9ydCA9PSBQT1JUX0EpIHsKPiAtCQlpZiAoaW5kZXgpCj4gLQkJCXJldHVy biAwOwo+IC0JCXJldHVybiBESVZfUk9VTkRfQ0xPU0VTVChkZXZfcHJpdi0+Y2RjbGtfZnJlcSwg MjAwMCk7Cj4gLQl9IGVsc2UgaWYgKEhBU19QQ0hfTFBUX0goZGV2X3ByaXYpKSB7Cj4gKwlpZiAo aW50ZWxfZGlnX3BvcnQtPnBvcnQgIT0gUE9SVF9BICYmIEhBU19QQ0hfTFBUX0goZGV2X3ByaXYp KSB7Cj4gIAkJLyogV29ya2Fyb3VuZCBmb3Igbm9uLVVMVCBIU1cgKi8KPiAgCQlzd2l0Y2ggKGlu ZGV4KSB7Cj4gIAkJY2FzZSAwOiByZXR1cm4gNjM7Cj4gIAkJY2FzZSAxOiByZXR1cm4gNzI7Cj4g IAkJZGVmYXVsdDogcmV0dXJuIDA7Cj4gIAkJfQo+IC0JfSBlbHNlICB7Cj4gLQkJcmV0dXJuIGlu ZGV4ID8gMCA6IERJVl9ST1VORF9DTE9TRVNUKGRldl9wcml2LT5yYXdjbGtfZnJlcSwgMjAwMCk7 Cj4gIAl9Cj4gKwo+ICsJcmV0dXJuIGlsa19nZXRfYXV4X2Nsb2NrX2RpdmlkZXIoaW50ZWxfZHAs IGluZGV4KTsKPiAgfQo+ICAKPiAgc3RhdGljIHVpbnQzMl90IHNrbF9nZXRfYXV4X2Nsb2NrX2Rp dmlkZXIoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgaW50IGluZGV4KQoKLS0gCkphbmkgTmlr dWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=