* HDMI 4k modes VIC @ 2015-10-28 13:58 Sharma, Shashank 2015-10-28 14:30 ` Damien Lespiau 0 siblings, 1 reply; 7+ messages in thread From: Sharma, Shashank @ 2015-10-28 13:58 UTC (permalink / raw) To: Lespiau, Damien; +Cc: intel-gfx@lists.freedesktop.org Hi Damien This is regarding one of the patches: drm: Add support for alternate clocks of 4k modes (3f2f653378112c1453c0d83c81746a9225e4bc75) I am seeing that from function drm_match_hdmi_mode we are not returning correct VIC's for 4k modes (listed in edid_4k_modes[]) Looks like we are returning VIC=(1, 2, 3, 4) for 4K modes (3840x2160@30Hz, 3840x2160@25Hz, 3840x2160@24Hz and 4096x2160@24Hz) But as per the CEA-861-F specs, the respective VIC should be (95, 94 and 93). The VIC returned is being used for writing AVI IF in drm_hdmi_vendor_infoframe_from_display_mode. Please help me to understand if there any specific reason for this, or am I missing something in interpretation ? Regards Shashank _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: HDMI 4k modes VIC 2015-10-28 13:58 HDMI 4k modes VIC Sharma, Shashank @ 2015-10-28 14:30 ` Damien Lespiau 2015-10-28 16:38 ` Jani Nikula 0 siblings, 1 reply; 7+ messages in thread From: Damien Lespiau @ 2015-10-28 14:30 UTC (permalink / raw) To: Sharma, Shashank; +Cc: intel-gfx@lists.freedesktop.org On Wed, Oct 28, 2015 at 01:58:55PM +0000, Sharma, Shashank wrote: > Hi Damien > > This is regarding one of the patches: > drm: Add support for alternate clocks of 4k modes > (3f2f653378112c1453c0d83c81746a9225e4bc75) > > I am seeing that from function drm_match_hdmi_mode we are not returning > correct VIC's for 4k modes (listed in edid_4k_modes[]) > Looks like we are returning VIC=(1, 2, 3, 4) for 4K modes (3840x2160@30Hz, > 3840x2160@25Hz, 3840x2160@24Hz and 4096x2160@24Hz) drm_match_hdmi_mode() doesn't return the VIC for the AVI infoframe, but the VIC for the HDMI vendor specific infoframe. See section 8.2.3 of the HDMI 1.4 spec. > But as per the CEA-861-F specs, the respective VIC should be (95, 94 and > 93). The VIC returned is being used for writing AVI IF in > drm_hdmi_vendor_infoframe_from_display_mode. That's not the AVI infoframe, that's the HDMI vendor specific infoframe. > Please help me to understand if there any specific reason for this, or am > I missing something in interpretation ? Are you seeing a bug? it's totally possible, I've never used an actual conformance tool when I wrote that code, so it's likely buggy and the VIC in the AVI infoframe may well be wrong. -- Damien _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: HDMI 4k modes VIC 2015-10-28 14:30 ` Damien Lespiau @ 2015-10-28 16:38 ` Jani Nikula 2015-10-28 16:50 ` Damien Lespiau 0 siblings, 1 reply; 7+ messages in thread From: Jani Nikula @ 2015-10-28 16:38 UTC (permalink / raw) To: Damien Lespiau, Sharma, Shashank; +Cc: intel-gfx@lists.freedesktop.org On Wed, 28 Oct 2015, Damien Lespiau <damien.lespiau@intel.com> wrote: > On Wed, Oct 28, 2015 at 01:58:55PM +0000, Sharma, Shashank wrote: >> Hi Damien >> >> This is regarding one of the patches: >> drm: Add support for alternate clocks of 4k modes >> (3f2f653378112c1453c0d83c81746a9225e4bc75) >> >> I am seeing that from function drm_match_hdmi_mode we are not returning >> correct VIC's for 4k modes (listed in edid_4k_modes[]) >> Looks like we are returning VIC=(1, 2, 3, 4) for 4K modes (3840x2160@30Hz, >> 3840x2160@25Hz, 3840x2160@24Hz and 4096x2160@24Hz) > > drm_match_hdmi_mode() doesn't return the VIC for the AVI infoframe, but > the VIC for the HDMI vendor specific infoframe. See section 8.2.3 of the > HDMI 1.4 spec. > >> But as per the CEA-861-F specs, the respective VIC should be (95, 94 and >> 93). The VIC returned is being used for writing AVI IF in >> drm_hdmi_vendor_infoframe_from_display_mode. > > That's not the AVI infoframe, that's the HDMI vendor specific infoframe. > >> Please help me to understand if there any specific reason for this, or am >> I missing something in interpretation ? > > Are you seeing a bug? it's totally possible, I've never used an actual > conformance tool when I wrote that code, so it's likely buggy and the > VIC in the AVI infoframe may well be wrong. Possibly relevant https://bugs.freedesktop.org/show_bug.cgi?id=92217 > > -- > Damien > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: HDMI 4k modes VIC 2015-10-28 16:38 ` Jani Nikula @ 2015-10-28 16:50 ` Damien Lespiau 2015-10-29 8:03 ` Sharma, Shashank 0 siblings, 1 reply; 7+ messages in thread From: Damien Lespiau @ 2015-10-28 16:50 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx@lists.freedesktop.org On Wed, Oct 28, 2015 at 06:38:21PM +0200, Jani Nikula wrote: > > Are you seeing a bug? it's totally possible, I've never used an actual > > conformance tool when I wrote that code, so it's likely buggy and the > > VIC in the AVI infoframe may well be wrong. > > Possibly relevant > https://bugs.freedesktop.org/show_bug.cgi?id=92217 That one looks different, we don't do aspect ratio on modes very well, not even exposing them to user space. -- Damien _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: HDMI 4k modes VIC 2015-10-28 16:50 ` Damien Lespiau @ 2015-10-29 8:03 ` Sharma, Shashank 2015-10-29 13:18 ` [Intel-gfx] " Ville Syrjälä 0 siblings, 1 reply; 7+ messages in thread From: Sharma, Shashank @ 2015-10-29 8:03 UTC (permalink / raw) To: Lespiau, Damien, Jani Nikula; +Cc: intel-gfx@lists.freedesktop.org Actually we should update the cea_modedb in drm layer with 4k modes and appropriate VIC, coz the AVI infoframe functions are not getting proper VICs for cea modes. Or while processing alternative cea modes, we should check and return VICs. I was planning to add 4k@60 modes, I will probably add one patch there, for handling the 4k modes in CEA db. As per CEA-861-F compliance, the 4k@30 and 4k@60 modes can come in cea DB as SVD modes. So we should have VICs for them also. We will also start upstreaming the patches we added for VLV/CHV, for handling aspect ratio support in libdrm layer as well as kernel. Regards Shashank -----Original Message----- From: Lespiau, Damien Sent: Wednesday, October 28, 2015 10:21 PM To: Jani Nikula Cc: Sharma, Shashank; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] HDMI 4k modes VIC On Wed, Oct 28, 2015 at 06:38:21PM +0200, Jani Nikula wrote: > > Are you seeing a bug? it's totally possible, I've never used an > > actual conformance tool when I wrote that code, so it's likely buggy > > and the VIC in the AVI infoframe may well be wrong. > > Possibly relevant > https://bugs.freedesktop.org/show_bug.cgi?id=92217 That one looks different, we don't do aspect ratio on modes very well, not even exposing them to user space. -- Damien _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] HDMI 4k modes VIC 2015-10-29 8:03 ` Sharma, Shashank @ 2015-10-29 13:18 ` Ville Syrjälä 2015-10-29 15:06 ` Sharma, Shashank 0 siblings, 1 reply; 7+ messages in thread From: Ville Syrjälä @ 2015-10-29 13:18 UTC (permalink / raw) To: Sharma, Shashank; +Cc: dri-devel, intel-gfx@lists.freedesktop.org On Thu, Oct 29, 2015 at 08:03:29AM +0000, Sharma, Shashank wrote: > Actually we should update the cea_modedb in drm layer with 4k modes and appropriate VIC, coz the AVI infoframe functions are > not getting proper VICs for cea modes. Or while processing alternative cea modes, we should check and return VICs. That's not surprising since the drm mode lists haven't been updated for 861-F. IIRC Thierry may already have some patches for that, as well as HDMI 2.0. > > I was planning to add 4k@60 modes, I will probably add one patch there, for handling the 4k modes in CEA db. > As per CEA-861-F compliance, the 4k@30 and 4k@60 modes can come in cea DB as SVD modes. So we should have VICs for them also. > We will also start upstreaming the patches we added for VLV/CHV, for handling aspect ratio support in libdrm layer as well as kernel. > > Regards > Shashank > -----Original Message----- > From: Lespiau, Damien > Sent: Wednesday, October 28, 2015 10:21 PM > To: Jani Nikula > Cc: Sharma, Shashank; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] HDMI 4k modes VIC > > On Wed, Oct 28, 2015 at 06:38:21PM +0200, Jani Nikula wrote: > > > Are you seeing a bug? it's totally possible, I've never used an > > > actual conformance tool when I wrote that code, so it's likely buggy > > > and the VIC in the AVI infoframe may well be wrong. > > > > Possibly relevant > > https://bugs.freedesktop.org/show_bug.cgi?id=92217 > > That one looks different, we don't do aspect ratio on modes very well, not even exposing them to user space. > > -- > Damien > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [Intel-gfx] HDMI 4k modes VIC 2015-10-29 13:18 ` [Intel-gfx] " Ville Syrjälä @ 2015-10-29 15:06 ` Sharma, Shashank 0 siblings, 0 replies; 7+ messages in thread From: Sharma, Shashank @ 2015-10-29 15:06 UTC (permalink / raw) To: Ville Syrjälä Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Thanks for the suggestion. I will check with Thierrey also. Regards Shashank -----Original Message----- From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com] Sent: Thursday, October 29, 2015 6:48 PM To: Sharma, Shashank Cc: Lespiau, Damien; Jani Nikula; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Thierry Reding Subject: Re: [Intel-gfx] HDMI 4k modes VIC On Thu, Oct 29, 2015 at 08:03:29AM +0000, Sharma, Shashank wrote: > Actually we should update the cea_modedb in drm layer with 4k modes > and appropriate VIC, coz the AVI infoframe functions are not getting proper VICs for cea modes. Or while processing alternative cea modes, we should check and return VICs. That's not surprising since the drm mode lists haven't been updated for 861-F. IIRC Thierry may already have some patches for that, as well as HDMI 2.0. > > I was planning to add 4k@60 modes, I will probably add one patch there, for handling the 4k modes in CEA db. > As per CEA-861-F compliance, the 4k@30 and 4k@60 modes can come in cea DB as SVD modes. So we should have VICs for them also. > We will also start upstreaming the patches we added for VLV/CHV, for handling aspect ratio support in libdrm layer as well as kernel. > > Regards > Shashank > -----Original Message----- > From: Lespiau, Damien > Sent: Wednesday, October 28, 2015 10:21 PM > To: Jani Nikula > Cc: Sharma, Shashank; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] HDMI 4k modes VIC > > On Wed, Oct 28, 2015 at 06:38:21PM +0200, Jani Nikula wrote: > > > Are you seeing a bug? it's totally possible, I've never used an > > > actual conformance tool when I wrote that code, so it's likely > > > buggy and the VIC in the AVI infoframe may well be wrong. > > > > Possibly relevant > > https://bugs.freedesktop.org/show_bug.cgi?id=92217 > > That one looks different, we don't do aspect ratio on modes very well, not even exposing them to user space. > > -- > Damien > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-10-29 15:06 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-10-28 13:58 HDMI 4k modes VIC Sharma, Shashank 2015-10-28 14:30 ` Damien Lespiau 2015-10-28 16:38 ` Jani Nikula 2015-10-28 16:50 ` Damien Lespiau 2015-10-29 8:03 ` Sharma, Shashank 2015-10-29 13:18 ` [Intel-gfx] " Ville Syrjälä 2015-10-29 15:06 ` Sharma, Shashank
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox