From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Fix failure paths around
	initial	fbdev allocation
Date: Tue, 30 Jun 2015 13:23:30 +0300
Message-ID: <87h9ppwl3x.fsf@intel.com>
References: <1435655187-8769-1-git-send-email-tvrtko.ursulin@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 4C1716E47E
 for <Intel-gfx@lists.freedesktop.org>; Tue, 30 Jun 2015 03:20:58 -0700 (PDT)
In-Reply-To: <1435655187-8769-1-git-send-email-tvrtko.ursulin@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, Intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCAzMCBKdW4gMjAxNSwgVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4
LmludGVsLmNvbT4gd3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGlu
QGludGVsLmNvbT4KPgo+IFdlIGhhZCB0aHJlZSBmYWlsdXJlIG1vZGVzIGhlcmU6Cj4KPiAxLgo+
IERlYWRsb2NrIGluIGludGVsZmJfYWxsb2MgZmFpbHVyZSBwYXRoIHdoZXJlIGl0IGNhbGxzCj4g
ZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZSwgd2hpY2ggZ3JhYnMgdGhlIHN0cnVjdCBtdXRleCBhbmQg
aW50ZWxmYl9jcmVhdGUKPiAoY2FsbGVyIG9mIGludGVsZmJfYWxsb2MpIHdhcyBhbHJlYWR5IGhv
bGRpbmcgaXQuCj4KPiAyLgo+IERvdWJsZSB1bnJlZmVyZW5jZSBvbiB0aGUgb2JqZWN0IGlmIF9f
aW50ZWxfZnJhbWVidWZmZXJfY3JlYXRlIGZhaWxzCj4gc2luY2UgYm90aCBpdCBhbmQgdGhlIGNh
bGxlciAoaW50ZWxmYl9hbGxvYykgZG8gdGhlIHVucmVmZXJlbmNlLgo+Cj4gMy4KPiBEZWFkbG9j
ayBpbiBpbnRlbGZiX2NyZWF0ZSBmYWlsdXJlIHBhdGggd2hlcmUgaXQgY2FsbHMKPiBkcm1fZnJh
bWVidWZmZXJfdW5yZWZlcmVuY2UsIHdoaWNoIGdyYWJzIHRoZSBzdHJ1Y3QgbXV0ZXggYW5kCj4g
aW50ZWxmYl9jcmVhdGUgd2FzIGFscmVhZHkgaG9sZGluZyBpdC4KPgo+IHYyOgo+ICAgICogUmVm
b3JtYXQgY29tbWl0IG1zZyB0byA3MiBjaGFycy4gKEx1a2FzIFd1bm5lcikKPiAgICAqIEFkZGVk
IHRoaXJkIGZhaWx1cmUgbW9kZS4gKEx1a2FzIFd1bm5lcikKPgo+IFNpZ25lZC1vZmYtYnk6IFR2
cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gRml4ZXM6IDYwYTVjYTAx
NWZmZDJhYWNmZTU2NzRiNWE0MDFjZDJhMzcxNTllMDcKClRoZSBmb3JtYXQgaXMKCkZpeGVzOiA2
MGE1Y2EwMTVmZmQgKCJkcm0vaTkxNTogQWRkIGxvY2tpbmcgYXJvdW5kIGZyYW1lYnVmZmVyX3Jl
ZmVyZW5jZXMtLSIpCgpTZWUgRG9jdW1lbnRhdGlvbi9TdWJtaXR0aW5nUGF0Y2hlcyBvbiBob3cg
dG8gaGF2ZSBnaXQgb3V0cHV0IHRoYXQKZm9ybWF0IGZvciB5b3UuCgpCUiwKSmFuaS4KCgoKPiBS
ZXBvcnRlZC1CeTogTHVrYXMgV3VubmVyIDxsdWthc0B3dW5uZXIuZGU+Cj4gVGVzdGVkLUJ5OiBM
dWthcyBXdW5uZXIgPGx1a2FzQHd1bm5lci5kZT4KPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0Bj
aHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs
aW51eC5pbnRlbC5jb20+Cj4gQ2M6IEx1a2FzIFd1bm5lciA8bHVrYXNAd3VubmVyLmRlPgo+IC0t
LQo+IFZpbGxlLCB5b3Ugc3VnZ2VzdGVkIHNvbWUgY2hhbmdlcyBlYXJsaWVyOwo+Cj4gIiIiCj4g
SSBzdWdnZXN0IHJlbW92aW5nIHRoZSB1bnJlZiBmcm9tIF9faW50ZWxfZnJhbWVidWZmZXJfY3Jl
YXRlKCkuCj4gIiIiCj4KPiBEbyB5b3UgdmlldyB0aGF0IGFzIGFuIGltcHJvdmVtZW50IGluIGNv
ZGUgY2xhcml0eS9vcmdhbmlzYXRpb24sCj4gb3IgeW91IHRoaW5rIG15IHZlcnNpb24gaXMgYWN0
dWFsbHkgd3JvbmcgZm9yIHNvbWUgcmVhc29uPwo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9mYmRldi5jIHwgMjEgKysrKysrKysrKysrKy0tLS0tLS0tCj4gIDEgZmlsZSBjaGFu
Z2VkLCAxMyBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9mYmRldi5jCj4gaW5kZXggMmExNzI0ZS4uMTE4NDIwYiAxMDA2NDQKPiAtLS0gYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZmJkZXYuYwo+IEBAIC0xNDEsNyArMTQxLDcgQEAgc3RhdGljIGludCBpbnRlbGZi
X2FsbG9jKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gIHsKPiAgCXN0cnVjdCBpbnRl
bF9mYmRldiAqaWZiZGV2ID0KPiAgCQljb250YWluZXJfb2YoaGVscGVyLCBzdHJ1Y3QgaW50ZWxf
ZmJkZXYsIGhlbHBlcik7Cj4gLQlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYjsKPiArCXN0cnVj
dCBkcm1fZnJhbWVidWZmZXIgKmZiID0gTlVMTDsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYg
PSBoZWxwZXItPmRldjsKPiAgCXN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyIG1vZGVfY21kID0ge307
Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+IEBAIC0xNTksNiArMTU5LDgg
QEAgc3RhdGljIGludCBpbnRlbGZiX2FsbG9jKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIs
Cj4gIAltb2RlX2NtZC5waXhlbF9mb3JtYXQgPSBkcm1fbW9kZV9sZWdhY3lfZmJfZm9ybWF0KHNp
emVzLT5zdXJmYWNlX2JwcCwKPiAgCQkJCQkJCSAgc2l6ZXMtPnN1cmZhY2VfZGVwdGgpOwo+ICAK
PiArCW11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiArCj4gIAlzaXplID0gbW9kZV9j
bWQucGl0Y2hlc1swXSAqIG1vZGVfY21kLmhlaWdodDsKPiAgCXNpemUgPSBQQUdFX0FMSUdOKHNp
emUpOwo+ICAJb2JqID0gaTkxNV9nZW1fb2JqZWN0X2NyZWF0ZV9zdG9sZW4oZGV2LCBzaXplKTsK
PiBAQCAtMTcyLDggKzE3NCw5IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9hbGxvYyhzdHJ1Y3QgZHJt
X2ZiX2hlbHBlciAqaGVscGVyLAo+ICAKPiAgCWZiID0gX19pbnRlbF9mcmFtZWJ1ZmZlcl9jcmVh
dGUoZGV2LCAmbW9kZV9jbWQsIG9iaik7Cj4gIAlpZiAoSVNfRVJSKGZiKSkgewo+ICsJCS8qIERy
b3BzIG9iamVjdCByZWZlcmVuY2Ugb24gZmFpbHVyZS4gKi8KPiAgCQlyZXQgPSBQVFJfRVJSKGZi
KTsKPiAtCQlnb3RvIG91dF91bnJlZjsKPiArCQlnb3RvIG91dDsKPiAgCX0KPiAgCj4gIAkvKiBG
bHVzaCBldmVyeXRoaW5nIG91dCwgd2UnbGwgYmUgZG9pbmcgR1RUIG9ubHkgZnJvbSBub3cgb24g
Ki8KPiBAQCAtMTgzLDE1ICsxODYsMTggQEAgc3RhdGljIGludCBpbnRlbGZiX2FsbG9jKHN0cnVj
dCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gIAkJZ290byBvdXRfZmI7Cj4gIAl9Cj4gIAo+ICsJ
bXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gKwo+ICAJaWZiZGV2LT5mYiA9IHRv
X2ludGVsX2ZyYW1lYnVmZmVyKGZiKTsKPiAgCj4gIAlyZXR1cm4gMDsKPiAgCj4gIG91dF9mYjoK
PiAtCWRybV9mcmFtZWJ1ZmZlcl9yZW1vdmUoZmIpOwo+IC1vdXRfdW5yZWY6Cj4gIAlkcm1fZ2Vt
X29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsKPiAgb3V0Ogo+ICsJbXV0ZXhfdW5sb2Nr
KCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gKwlpZiAoZmIpCj4gKwkJZHJtX2ZyYW1lYnVmZmVyX3Jl
bW92ZShmYik7Cj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+IEBAIC0yMDksOCArMjE1LDYgQEAg
c3RhdGljIGludCBpbnRlbGZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+
ICAJaW50IHNpemUsIHJldDsKPiAgCWJvb2wgcHJlYWxsb2MgPSBmYWxzZTsKPiAgCj4gLQltdXRl
eF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gLQo+ICAJaWYgKGludGVsX2ZiICYmCj4gIAkg
ICAgKHNpemVzLT5mYl93aWR0aCA+IGludGVsX2ZiLT5iYXNlLndpZHRoIHx8Cj4gIAkgICAgIHNp
emVzLT5mYl9oZWlnaHQgPiBpbnRlbF9mYi0+YmFzZS5oZWlnaHQpKSB7Cj4gQEAgLTIyNSw3ICsy
MjksNyBAQCBzdGF0aWMgaW50IGludGVsZmJfY3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpo
ZWxwZXIsCj4gIAkJRFJNX0RFQlVHX0tNUygibm8gQklPUyBmYiwgYWxsb2NhdGluZyBhIG5ldyBv
bmVcbiIpOwo+ICAJCXJldCA9IGludGVsZmJfYWxsb2MoaGVscGVyLCBzaXplcyk7Cj4gIAkJaWYg
KHJldCkKPiAtCQkJZ290byBvdXRfdW5sb2NrOwo+ICsJCQlyZXR1cm4gcmV0Owo+ICAJCWludGVs
X2ZiID0gaWZiZGV2LT5mYjsKPiAgCX0gZWxzZSB7Cj4gIAkJRFJNX0RFQlVHX0tNUygicmUtdXNp
bmcgQklPUyBmYlxuIik7Cj4gQEAgLTIzNyw2ICsyNDEsOCBAQCBzdGF0aWMgaW50IGludGVsZmJf
Y3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gIAlvYmogPSBpbnRlbF9mYi0+
b2JqOwo+ICAJc2l6ZSA9IG9iai0+YmFzZS5zaXplOwo+ICAKPiArCW11dGV4X2xvY2soJmRldi0+
c3RydWN0X211dGV4KTsKPiArCj4gIAlpbmZvID0gZnJhbWVidWZmZXJfYWxsb2MoMCwgJmRldi0+
cGRldi0+ZGV2KTsKPiAgCWlmICghaW5mbykgewo+ICAJCXJldCA9IC1FTk9NRU07Cj4gQEAgLTMw
Nyw3ICszMTMsNiBAQCBzdGF0aWMgaW50IGludGVsZmJfY3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVs
cGVyICpoZWxwZXIsCj4gIG91dF91bnBpbjoKPiAgCWk5MTVfZ2VtX29iamVjdF9nZ3R0X3VucGlu
KG9iaik7Cj4gIAlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsKPiAtb3V0
X3VubG9jazoKPiAgCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICAJcmV0dXJu
IHJldDsKPiAgfQo+IC0tIAo+IDIuNC4yCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhA
bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls
bWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJj
ZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz
a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu
dGVsLWdmeAo=