From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Convert pxvid to extvid lookup table
Date: Mon, 01 Dec 2014 11:48:48 +0200 [thread overview]
Message-ID: <87h9xfbszj.fsf@intel.com> (raw)
In-Reply-To: <20141128162205.GN10194@nuc-i3427.alporthouse.com>
On Fri, 28 Nov 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, Nov 28, 2014 at 04:55:11PM +0200, Ville Syrjälä wrote:
>> On Thu, Nov 27, 2014 at 04:23:12PM +0200, Mika Kuoppala wrote:
>> > to a procedural to save space.
>
> I really don't like this style of changelog (run on sentences from
> the subject).
Agreed. In general, the commit message should make sense on its own,
without the subject line.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-01 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 14:23 [PATCH] drm/i915: Convert pxvid to extvid lookup table Mika Kuoppala
2014-11-27 22:03 ` shuang.he
2014-11-28 14:55 ` Ville Syrjälä
2014-11-28 16:22 ` Chris Wilson
2014-11-28 18:18 ` Daniel Vetter
2014-12-01 9:48 ` Jani Nikula [this message]
2014-12-01 16:01 ` [PATCH] drm/i915: Convert pxvid to extvid lookup table to a function Mika Kuoppala
2014-12-01 16:49 ` Daniel Vetter
2014-12-03 0:54 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9xfbszj.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox