From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Shobhit Kumar <shobhit.kumar@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915: Update the DSI ULPS entry/exit sequence
Date: Fri, 04 Jul 2014 17:26:53 +0300 [thread overview]
Message-ID: <87ha2xci8i.fsf@intel.com> (raw)
In-Reply-To: <20140703141032.GI32535@nuc-i3427.alporthouse.com>
On Thu, 03 Jul 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, Jul 03, 2014 at 04:35:41PM +0530, Shobhit Kumar wrote:
>> We should keep DEVICE_READY bit set in the ULPS enter sequence. In
>> exit sequence also we should set DEVICE_READY, but thats causing
>> blankout for me. Also exit sequence is simplified as per hw team
>> recommendation.
>>
>> This should fix -
>> [drm:intel_dsi_clear_device_ready] *ERROR* DSI LP not going Low
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80818
>> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
>
> They silence that warning and appears to still work,
> Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
Pushed to -fixes, thanks for the patches and testing.
BR,
Jani.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2014-07-04 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 11:05 [PATCH 1/2] drm/i915: DPI FIFO empty check is not needed Shobhit Kumar
2014-07-03 11:05 ` [PATCH 2/2] drm/i915: Update the DSI ULPS entry/exit sequence Shobhit Kumar
2014-07-03 14:10 ` Chris Wilson
2014-07-04 14:26 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha2xci8i.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shobhit.kumar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox