From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH 2/2] drm/i915: Update the DSI ULPS
	entry/exit sequence
Date: Fri, 04 Jul 2014 17:26:53 +0300
Message-ID: <87ha2xci8i.fsf@intel.com>
References: <1404385541-15075-1-git-send-email-shobhit.kumar@intel.com>
 <1404385541-15075-2-git-send-email-shobhit.kumar@intel.com>
 <20140703141032.GI32535@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
 by gabe.freedesktop.org (Postfix) with ESMTP id 7CF606E7FA
 for <intel-gfx@lists.freedesktop.org>; Fri,  4 Jul 2014 07:27:01 -0700 (PDT)
In-Reply-To: <20140703141032.GI32535@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Shobhit Kumar <shobhit.kumar@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>, intel-gfx <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 03 Jul 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, Jul 03, 2014 at 04:35:41PM +0530, Shobhit Kumar wrote:
>> We should keep DEVICE_READY bit set in the ULPS enter sequence. In
>> exit sequence also we should set DEVICE_READY, but thats causing
>> blankout for me. Also exit sequence is simplified as per hw team
>> recommendation.
>> 
>> This should fix -
>> [drm:intel_dsi_clear_device_ready] *ERROR* DSI LP not going Low
>> 
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80818
>> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
>
> They silence that warning and appears to still work,
> Tested-by: Chris Wilson <chris@chris-wilson.co.uk>

Pushed to -fixes, thanks for the patches and testing.

BR,
Jani.


> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre

-- 
Jani Nikula, Intel Open Source Technology Center