From: Jani Nikula <jani.nikula@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/4] drm/i915/dp: native aux read return value fixes and cleanup
Date: Thu, 30 Jan 2014 17:05:34 +0200 [thread overview]
Message-ID: <87ha8l8q81.fsf@intel.com> (raw)
In-Reply-To: <20140130095022.GN17001@phenom.ffwll.local>
On Thu, 30 Jan 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Jan 30, 2014 at 11:37:00AM +0200, Jani Nikula wrote:
>> Fix and cleanup the rather confused native aux read return values and
>> return value checks. Maybe we'll get them right from now on. Just maybe.
>>
>> Did not have a chance to test this, I'm afraid, but it's pretty
>> straightforward.
>
> How does this fit in with Thierry's dp aux helper improvements? I prefer
> if we start to converge on that sooner than later ...
For the i2c-over-aux conversion
commit 8a5e6aeb30ecaf8f11a99c0d008c8935cd6fba9f
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Date: Wed Oct 30 19:50:26 2013 -0200
drm/i915: turn the eDP VDD on for any i2c transactions
will be a PITA, as we lose control of that level in the stack.
So we'd need to move the vdd enable/disable higher or lower. Per that
commit, higher was problematic. If we move it lower, we may need to add
refcounting to the vdd, but then we'll lose the warn for "eDP VDD
already requested on\n".
Ideas welcome.
Jani.
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-01-30 15:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 9:37 [PATCH 0/4] drm/i915/dp: native aux read return value fixes and cleanup Jani Nikula
2014-01-30 9:37 ` [PATCH 1/4] drm/i915/dp: make intel_dp_aux_native_read() return bool Jani Nikula
2014-01-30 10:07 ` Chris Wilson
2014-01-30 12:00 ` [PATCH v2] " Jani Nikula
2014-01-30 9:37 ` [PATCH 2/4] drm/i915/dp: move intel_dp_aux_native_read_retry() near other reads Jani Nikula
2014-01-30 12:00 ` [PATCH v2] " Jani Nikula
2014-01-30 9:37 ` [PATCH 3/4] drm/i915/dp: clean up cargo culted intel_dp_aux_native_read_retry() usage Jani Nikula
2014-01-30 9:37 ` [PATCH 4/4] drm/i915/dp: fix intel_dp_aux_native_read_retry() return value check Jani Nikula
2014-01-30 9:50 ` [PATCH 0/4] drm/i915/dp: native aux read return value fixes and cleanup Daniel Vetter
2014-01-30 13:37 ` Jani Nikula
2014-01-30 15:05 ` Jani Nikula [this message]
2014-01-30 15:12 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha8l8q81.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox