From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/3] drm/i915: Introduce i9xx_set_pipeconf() Date: Wed, 03 Apr 2013 13:08:16 +0300 Message-ID: <87hajoncz3.fsf@intel.com> References: <1364908210-13748-1-git-send-email-ville.syrjala@linux.intel.com> <1364908210-13748-2-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 38589E60E9 for ; Wed, 3 Apr 2013 03:07:24 -0700 (PDT) In-Reply-To: <1364908210-13748-2-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAwMiBBcHIgMjAxMywgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pgo+IEV4dHJhY3QgdGhlIFBJUEVDT05GIHNldHVwIGludG8gaTl4eF9zZXRfcGlwZWNvbmYoKS4g VGhpcyBtYWtlcyB0aGUKPiA8PUdlbjQvVkxWIGNvZGUgZm9sbG93IHRoZSBzYW1lIHBhdHRlcm4g YXMgdGhlIEdlbjUrIGNvZGVwYXRocy4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5u aWt1bGFAaW50ZWwuY29tPgoKPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMgfCAxMjMgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0K PiAgMSBmaWxlIGNoYW5nZWQsIDY4IGluc2VydGlvbnMoKyksIDU1IGRlbGV0aW9ucygtKQo+Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDI5OGJjMGMuLmRmYWVhMTUg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTQ1MTQsNiArNDUx NCw3MSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9zZXRfcGlwZV90aW1pbmdzKHN0cnVjdCBpbnRlbF9j cnRjICppbnRlbF9jcnRjLAo+ICAJCSAgICgobW9kZS0+aGRpc3BsYXkgLSAxKSA8PCAxNikgfCAo bW9kZS0+dmRpc3BsYXkgLSAxKSk7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGk5eHhfc2V0X3Bp cGVjb25mKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiArCQkJICAgICAgY29uc3Qgc3RydWN0IGRy bV9kaXNwbGF5X21vZGUgKm1vZGUsCj4gKwkJCSAgICAgIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxh eV9tb2RlICphZGp1c3RlZF9tb2RlLAo+ICsJCQkgICAgICBib29sIGlzX2RwKQo+ICt7Cj4gKwlz dHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+ZGV2Owo+ICsJc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXN0cnVjdCBpbnRlbF9jcnRj ICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjKTsKPiArCWludCBwaXBlID0gaW50ZWxf Y3J0Yy0+cGlwZTsKPiArCXUzMiBwaXBlY29uZjsKPiArCj4gKwkvKiBzZXR1cCBwaXBlY29uZiAq Lwo+ICsJcGlwZWNvbmYgPSBJOTE1X1JFQUQoUElQRUNPTkYocGlwZSkpOwo+ICsKPiArCWlmIChw aXBlID09IDAgJiYgSU5URUxfSU5GTyhkZXYpLT5nZW4gPCA0KSB7Cj4gKwkJLyogRW5hYmxlIHBp eGVsIGRvdWJsaW5nIHdoZW4gdGhlIGRvdCBjbG9jayBpcyA+IDkwJSBvZiB0aGUgKGRpc3BsYXkp Cj4gKwkJICogY29yZSBzcGVlZC4KPiArCQkgKgo+ICsJCSAqIFhYWDogTm8gZG91YmxlLXdpZGUg b24gOTE1R00gcGlwZSBCLiBJcyB0aGF0IHRoZSBvbmx5IHJlYXNvbiBmb3IgdGhlCj4gKwkJICog cGlwZSA9PSAwIGNoZWNrPwo+ICsJCSAqLwo+ICsJCWlmIChtb2RlLT5jbG9jayA+Cj4gKwkJICAg IGRldl9wcml2LT5kaXNwbGF5LmdldF9kaXNwbGF5X2Nsb2NrX3NwZWVkKGRldikgKiA5IC8gMTAp Cj4gKwkJCXBpcGVjb25mIHw9IFBJUEVDT05GX0RPVUJMRV9XSURFOwo+ICsJCWVsc2UKPiArCQkJ cGlwZWNvbmYgJj0gflBJUEVDT05GX0RPVUJMRV9XSURFOwo+ICsJfQo+ICsKPiArCS8qIGRlZmF1 bHQgdG8gOGJwYyAqLwo+ICsJcGlwZWNvbmYgJj0gfihQSVBFQ09ORl9CUENfTUFTSyB8IFBJUEVD T05GX0RJVEhFUl9FTik7Cj4gKwlpZiAoaXNfZHAgJiYgaW50ZWxfY3J0Yy0+Y29uZmlnLmRpdGhl cikgewo+ICsJCXBpcGVjb25mIHw9IFBJUEVDT05GXzZCUEMgfAo+ICsJCQlQSVBFQ09ORl9ESVRI RVJfRU4gfAo+ICsJCQlQSVBFQ09ORl9ESVRIRVJfVFlQRV9TUDsKPiArCX0KPiArCj4gKwlpZiAo SVNfVkFMTEVZVklFVyhkZXYpICYmCj4gKwkgICAgaW50ZWxfcGlwZV9oYXNfdHlwZShjcnRjLCBJ TlRFTF9PVVRQVVRfRURQKSAmJgo+ICsJICAgIGludGVsX2NydGMtPmNvbmZpZy5kaXRoZXIpIHsK PiArCQlwaXBlY29uZiB8PSBQSVBFQ09ORl82QlBDIHwKPiArCQkJUElQRUNPTkZfRU5BQkxFIHwK PiArCQkJSTk2NV9QSVBFQ09ORl9BQ1RJVkU7Cj4gKwl9Cj4gKwo+ICsJaWYgKEhBU19QSVBFX0NY U1IoZGV2KSkgewo+ICsJCWlmIChpbnRlbF9jcnRjLT5sb3dmcmVxX2F2YWlsKSB7Cj4gKwkJCURS TV9ERUJVR19LTVMoImVuYWJsaW5nIEN4U1IgZG93bmNsb2NraW5nXG4iKTsKPiArCQkJcGlwZWNv bmYgfD0gUElQRUNPTkZfQ1hTUl9ET1dOQ0xPQ0s7Cj4gKwkJfSBlbHNlIHsKPiArCQkJRFJNX0RF QlVHX0tNUygiZGlzYWJsaW5nIEN4U1IgZG93bmNsb2NraW5nXG4iKTsKPiArCQkJcGlwZWNvbmYg Jj0gflBJUEVDT05GX0NYU1JfRE9XTkNMT0NLOwo+ICsJCX0KPiArCX0KPiArCj4gKwlwaXBlY29u ZiAmPSB+UElQRUNPTkZfSU5URVJMQUNFX01BU0s7Cj4gKwlpZiAoIUlTX0dFTjIoZGV2KSAmJgo+ ICsJICAgIGFkanVzdGVkX21vZGUtPmZsYWdzICYgRFJNX01PREVfRkxBR19JTlRFUkxBQ0UpCj4g KwkJcGlwZWNvbmYgfD0gUElQRUNPTkZfSU5URVJMQUNFX1dfRklFTERfSU5ESUNBVElPTjsKPiAr CWVsc2UKPiArCQlwaXBlY29uZiB8PSBQSVBFQ09ORl9QUk9HUkVTU0lWRTsKPiArCj4gKwlJOTE1 X1dSSVRFKFBJUEVDT05GKHBpcGUpLCBwaXBlY29uZik7Cj4gKwlQT1NUSU5HX1JFQUQoUElQRUNP TkYocGlwZSkpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IGk5eHhfY3J0Y19tb2RlX3NldChzdHJ1 Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJCSAgICAgIGludCB4LCBpbnQgeSwKPiAgCQkJICAgICAg c3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIpCj4gQEAgLTQ1MjgsNyArNDU5Myw3IEBAIHN0YXRp YyBpbnQgaTl4eF9jcnRjX21vZGVfc2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCWludCBw bGFuZSA9IGludGVsX2NydGMtPnBsYW5lOwo+ICAJaW50IHJlZmNsaywgbnVtX2Nvbm5lY3RvcnMg PSAwOwo+ICAJaW50ZWxfY2xvY2tfdCBjbG9jaywgcmVkdWNlZF9jbG9jazsKPiAtCXUzMiBkc3Bj bnRyLCBwaXBlY29uZjsKPiArCXUzMiBkc3BjbnRyOwo+ICAJYm9vbCBvaywgaGFzX3JlZHVjZWRf Y2xvY2sgPSBmYWxzZSwgaXNfc2R2byA9IGZhbHNlOwo+ICAJYm9vbCBpc19sdmRzID0gZmFsc2Us IGlzX3R2ID0gZmFsc2UsIGlzX2RwID0gZmFsc2U7Cj4gIAlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAq ZW5jb2RlcjsKPiBAQCAtNDYwNSw5ICs0NjcwLDYgQEAgc3RhdGljIGludCBpOXh4X2NydGNfbW9k ZV9zZXQoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCQkJaGFzX3JlZHVjZWRfY2xvY2sgPyAm cmVkdWNlZF9jbG9jayA6IE5VTEwsCj4gIAkJCQludW1fY29ubmVjdG9ycyk7Cj4gIAo+IC0JLyog c2V0dXAgcGlwZWNvbmYgKi8KPiAtCXBpcGVjb25mID0gSTkxNV9SRUFEKFBJUEVDT05GKHBpcGUp KTsKPiAtCj4gIAkvKiBTZXQgdXAgdGhlIGRpc3BsYXkgcGxhbmUgcmVnaXN0ZXIgKi8KPiAgCWRz cGNudHIgPSBESVNQUExBTkVfR0FNTUFfRU5BQkxFOwo+ICAKPiBAQCAtNDYxOCw1OCArNDY4MCw5 IEBAIHN0YXRpYyBpbnQgaTl4eF9jcnRjX21vZGVfc2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywK PiAgCQkJZHNwY250ciB8PSBESVNQUExBTkVfU0VMX1BJUEVfQjsKPiAgCX0KPiAgCj4gLQlpZiAo cGlwZSA9PSAwICYmIElOVEVMX0lORk8oZGV2KS0+Z2VuIDwgNCkgewo+IC0JCS8qIEVuYWJsZSBw aXhlbCBkb3VibGluZyB3aGVuIHRoZSBkb3QgY2xvY2sgaXMgPiA5MCUgb2YgdGhlIChkaXNwbGF5 KQo+IC0JCSAqIGNvcmUgc3BlZWQuCj4gLQkJICoKPiAtCQkgKiBYWFg6IE5vIGRvdWJsZS13aWRl IG9uIDkxNUdNIHBpcGUgQi4gSXMgdGhhdCB0aGUgb25seSByZWFzb24gZm9yIHRoZQo+IC0JCSAq IHBpcGUgPT0gMCBjaGVjaz8KPiAtCQkgKi8KPiAtCQlpZiAobW9kZS0+Y2xvY2sgPgo+IC0JCSAg ICBkZXZfcHJpdi0+ZGlzcGxheS5nZXRfZGlzcGxheV9jbG9ja19zcGVlZChkZXYpICogOSAvIDEw KQo+IC0JCQlwaXBlY29uZiB8PSBQSVBFQ09ORl9ET1VCTEVfV0lERTsKPiAtCQllbHNlCj4gLQkJ CXBpcGVjb25mICY9IH5QSVBFQ09ORl9ET1VCTEVfV0lERTsKPiAtCX0KPiAtCj4gLQkvKiBkZWZh dWx0IHRvIDhicGMgKi8KPiAtCXBpcGVjb25mICY9IH4oUElQRUNPTkZfQlBDX01BU0sgfCBQSVBF Q09ORl9ESVRIRVJfRU4pOwo+IC0JaWYgKGlzX2RwKSB7Cj4gLQkJaWYgKGludGVsX2NydGMtPmNv bmZpZy5kaXRoZXIpIHsKPiAtCQkJcGlwZWNvbmYgfD0gUElQRUNPTkZfNkJQQyB8Cj4gLQkJCQkg ICAgUElQRUNPTkZfRElUSEVSX0VOIHwKPiAtCQkJCSAgICBQSVBFQ09ORl9ESVRIRVJfVFlQRV9T UDsKPiAtCQl9Cj4gLQl9Cj4gLQo+IC0JaWYgKElTX1ZBTExFWVZJRVcoZGV2KSAmJiBpbnRlbF9w aXBlX2hhc190eXBlKGNydGMsIElOVEVMX09VVFBVVF9FRFApKSB7Cj4gLQkJaWYgKGludGVsX2Ny dGMtPmNvbmZpZy5kaXRoZXIpIHsKPiAtCQkJcGlwZWNvbmYgfD0gUElQRUNPTkZfNkJQQyB8Cj4g LQkJCQkJUElQRUNPTkZfRU5BQkxFIHwKPiAtCQkJCQlJOTY1X1BJUEVDT05GX0FDVElWRTsKPiAt CQl9Cj4gLQl9Cj4gLQo+ICAJRFJNX0RFQlVHX0tNUygiTW9kZSBmb3IgcGlwZSAlYzpcbiIsIHBp cGUgPT0gMCA/ICdBJyA6ICdCJyk7Cj4gIAlkcm1fbW9kZV9kZWJ1Z19wcmludG1vZGVsaW5lKG1v ZGUpOwo+ICAKPiAtCWlmIChIQVNfUElQRV9DWFNSKGRldikpIHsKPiAtCQlpZiAoaW50ZWxfY3J0 Yy0+bG93ZnJlcV9hdmFpbCkgewo+IC0JCQlEUk1fREVCVUdfS01TKCJlbmFibGluZyBDeFNSIGRv d25jbG9ja2luZ1xuIik7Cj4gLQkJCXBpcGVjb25mIHw9IFBJUEVDT05GX0NYU1JfRE9XTkNMT0NL Owo+IC0JCX0gZWxzZSB7Cj4gLQkJCURSTV9ERUJVR19LTVMoImRpc2FibGluZyBDeFNSIGRvd25j bG9ja2luZ1xuIik7Cj4gLQkJCXBpcGVjb25mICY9IH5QSVBFQ09ORl9DWFNSX0RPV05DTE9DSzsK PiAtCQl9Cj4gLQl9Cj4gLQo+IC0JcGlwZWNvbmYgJj0gflBJUEVDT05GX0lOVEVSTEFDRV9NQVNL Owo+IC0JaWYgKCFJU19HRU4yKGRldikgJiYKPiAtCSAgICBhZGp1c3RlZF9tb2RlLT5mbGFncyAm IERSTV9NT0RFX0ZMQUdfSU5URVJMQUNFKQo+IC0JCXBpcGVjb25mIHw9IFBJUEVDT05GX0lOVEVS TEFDRV9XX0ZJRUxEX0lORElDQVRJT047Cj4gLQllbHNlCj4gLQkJcGlwZWNvbmYgfD0gUElQRUNP TkZfUFJPR1JFU1NJVkU7Cj4gLQo+ICAJaW50ZWxfc2V0X3BpcGVfdGltaW5ncyhpbnRlbF9jcnRj LCBtb2RlLCBhZGp1c3RlZF9tb2RlKTsKPiAgCj4gIAkvKiBwaXBlc3JjIGFuZCBkc3BzaXplIGNv bnRyb2wgdGhlIHNpemUgdGhhdCBpcyBzY2FsZWQgZnJvbSwKPiBAQCAtNDY4MCw4ICs0NjkzLDgg QEAgc3RhdGljIGludCBpOXh4X2NydGNfbW9kZV9zZXQoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ ICAJCSAgIChtb2RlLT5oZGlzcGxheSAtIDEpKTsKPiAgCUk5MTVfV1JJVEUoRFNQUE9TKHBsYW5l KSwgMCk7Cj4gIAo+IC0JSTkxNV9XUklURShQSVBFQ09ORihwaXBlKSwgcGlwZWNvbmYpOwo+IC0J UE9TVElOR19SRUFEKFBJUEVDT05GKHBpcGUpKTsKPiArCWk5eHhfc2V0X3BpcGVjb25mKGNydGMs IG1vZGUsIGFkanVzdGVkX21vZGUsIGlzX2RwKTsKPiArCj4gIAlpbnRlbF9lbmFibGVfcGlwZShk ZXZfcHJpdiwgcGlwZSwgZmFsc2UpOwo+ICAKPiAgCWludGVsX3dhaXRfZm9yX3ZibGFuayhkZXYs IHBpcGUpOwo+IC0tIAo+IDEuOC4xLjUKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==