From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 1/2] intel: Add the ability to supply annotations for .aub files. Date: Thu, 10 May 2012 09:25:22 -0700 Message-ID: <87havom2a5.fsf@eliezer.anholt.net> References: <1336426312-23315-1-git-send-email-stereotype441@gmail.com> <87aa1gspii.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1500016461==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paul Berry Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1500016461== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 10 May 2012 06:43:54 -0700, Paul Berry wr= ote: > On 9 May 2012 20:07, Eric Anholt wrote: >=20 > > On Mon, 7 May 2012 14:31:51 -0700, Paul Berry > > wrote: > > > This patch adds a new function, > > > drm_intel_bufmgr_gem_set_aub_annotations(), which can be used to > > > annotate the type and subtype of data stored in various sections of > > > each buffer. This data is used to populate type and subtype fields > > > when generating the .aub file, which improves the ability of later > > > debugging tools to analyze the contents of the .aub file. > > > > > > If drm_intel_bufmgr_gem_set_aub_annotations() is not called, then we > > > fall back to the old set of annotations (annotate the portion of the > > > batchbuffer that is executed as AUB_TRACE_TYPE_BATCH, and everything > > > else as AUB_TRACE_TYPE_NOTYPE). > > > > This looks better than the interface I was thinking of. Only real > > nitpick note is that the style in this file is tab indents, rather than > > 8 spaces, same as linux kernel and 2d driver style. (I have since been > > convinced that 8 spaces is superior, but a mix is worse). > > >=20 > Ok. Are there any plans to switch drm over to spaces or are we stuck with > tabs forever? Our project as a whole includes work on the linux kernel, and most people working on libdrm are also working on the kernel. As far as I'm concerned, having a different style between them would be worse than the minor benefit of having diffs look nicer. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAk+r6/IACgkQHUdvYGzw6vfZywCePpWIXLsLlVoDbfgXSInaRF8r PisAoIe9Qu3n2FN+DPb71YQruBDOTIzo =fgSx -----END PGP SIGNATURE----- --=-=-=-- --===============1500016461== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1500016461==--