From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34523EB64DC for ; Tue, 27 Jun 2023 21:22:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A51610E338; Tue, 27 Jun 2023 21:22:24 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88B9510E332; Tue, 27 Jun 2023 21:22:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687900941; x=1719436941; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=gOkgzbB7AbJodJFvIg8WeSpqxgNzJPfN8CsXIK2LFrQ=; b=H23GmQJlFOTiC8/eBJlvEH/sZfgy45IszFTfY+0pUHysYQZs3Yvxb6Gd FBTLhmc+ygZoBizHUeHgtT9rutLnGtdsDto0mfVyBu38mrPdFlP9e84Wg mOEbqS4RnJukOmuL47p9Nf4J6AAuZ2coyCAJdMc3WL5FqkLdj9pU/5yYB 52khUcnLoQDxpsVk1++IWMr6DncxySk3s44zz2OeZV4/u6YHzn4ImIWU2 2KHWM9NejMujkpGLFUa/NSJyMPmjpFxlKeaB9/5zkXjgY5dzD+W0V7+nb nIoAB59tn69Lm+urCR/IBcSJOgXoY+YdvjpnJ17HRm1awKl7bzQmOiYVS A==; X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="364232155" X-IronPort-AV: E=Sophos;i="6.01,163,1684825200"; d="scan'208";a="364232155" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 14:22:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="1047122423" X-IronPort-AV: E=Sophos;i="6.01,163,1684825200"; d="scan'208";a="1047122423" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.113.179]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 14:22:19 -0700 Date: Tue, 27 Jun 2023 14:20:01 -0700 Message-ID: <87ilb861ry.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Vinay Belgaumkar In-Reply-To: <20230627191336.319381-1-vinay.belgaumkar@intel.com> References: <20230627191336.319381-1-vinay.belgaumkar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Dump perf_limit_reasons for debug X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 27 Jun 2023 12:13:36 -0700, Vinay Belgaumkar wrote: > > GuC load takes longer sometimes due to GT frequency not ramping up. > Add perf_limit_reasons to the existing warn print to see if frequency > is being throttled. > > v2: Review comments (Ashutosh) Reviewed-by: Ashutosh Dixit > > Signed-off-by: Vinay Belgaumkar > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c > index 364d0d546ec8..0f79cb658518 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c > @@ -251,9 +251,11 @@ static int guc_wait_ucode(struct intel_guc *guc) > if (ret == 0) > ret = -ENXIO; > } else if (delta_ms > 200) { > - guc_warn(guc, "excessive init time: %lldms! [freq = %dMHz, before = %dMHz, status = 0x%08X, count = %d, ret = %d]\n", > - delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps), > - before_freq, status, count, ret); > + guc_warn(guc, "excessive init time: %lldms! [status = 0x%08X, count = %d, ret = %d]\n", > + delta_ms, status, count, ret); > + guc_warn(guc, "excessive init time: [freq = %dMHz, before = %dMHz, perf_limit_reasons = 0x%08X]\n", > + intel_rps_read_actual_frequency(&uncore->gt->rps), before_freq, > + intel_uncore_read(uncore, intel_gt_perf_limit_reasons_reg(gt))); > } else { > guc_dbg(guc, "init took %lldms, freq = %dMHz, before = %dMHz, status = 0x%08X, count = %d, ret = %d\n", > delta_ms, intel_rps_read_actual_frequency(&uncore->gt->rps), > -- > 2.38.1 >