From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EDC7C77B75 for ; Mon, 15 May 2023 22:59:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A264010E2BC; Mon, 15 May 2023 22:58:55 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43E9C10E2B3; Mon, 15 May 2023 22:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684191533; x=1715727533; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=ZQzOqBM2z1ivG+KMYOGxYv9JWhSNAYWeh+nxPTHsIUM=; b=Qa9reCcrzyCyth9leFRARhI/ELWhtcY6O8RPVCBlmODHNQF/wLCySZ5m o2fRWcTyR3LClPQysz+twsjB7PL19iTH4jUiEV8mKxCeIL9PZm/sGXIxT HDlWtno0ZWyTjQcAWRRu8wque9I6dzoDHBQcDG/tFcL8frtS03Pn/vKYB GWWz2kna4CbXf0o6PWkCujiDhbDd2imWjl/nhOdaN9upZqdatiDiCNSBy 37TZg0Gtr/+OEwWXb7pXEYD/LgYZ7JSX6h6A7Z4QFtSoiLTAo0n6/htrQ 07JjnbkAToLS3tvSPIzg93A9BXDFpL+xtloE2dHc51EDWgfsMhCstiqZ5 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="414728568" X-IronPort-AV: E=Sophos;i="5.99,277,1677571200"; d="scan'208";a="414728568" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2023 15:58:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="790836109" X-IronPort-AV: E=Sophos;i="5.99,277,1677571200"; d="scan'208";a="790836109" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.225.207]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2023 15:58:51 -0700 Date: Mon, 15 May 2023 15:58:26 -0700 Message-ID: <87ilctp5gt.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Belgaumkar, Vinay" In-Reply-To: <35ab4783-ab78-a245-7067-d7a3f35d0063@intel.com> References: <20230512235603.431386-1-vinay.belgaumkar@intel.com> <87fs81dpz6.wl-ashutosh.dixit@intel.com> <35ab4783-ab78-a245-7067-d7a3f35d0063@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, mattst88@fosstodon.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 15 May 2023 15:23:58 -0700, Belgaumkar, Vinay wrote: > > > On 5/12/2023 5:39 PM, Dixit, Ashutosh wrote: > > On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote: > > Hi Vinay, > > > >> rps_boost debugfs shows host turbo related info. This is not valid > >> when SLPC is enabled. > > A couple of thoughts about this. It appears people are know only about > > rps_boost_info and don't know about guc_slpc_info? So: > > > > a. Instead of hiding the rps_boost_info file do we need to print there > > saying "SLPC is enabled, go look at guc_slpc_info"? > rps_boost_info has an eval() function which disables the interface when RPS > is OFF. This is indeed the case here, so shouldn't we just follow that > instead of trying to link the two? > > > > b. Or, even just call guc_slpc_info_show from rps_boost_show (so the two > > files will show the same SLPC information)? > > slpc_info has a lot of other info like the SLPC state, not sure that > matches up with the rps_boost_info name. OK, I have asked in https://gitlab.freedesktop.org/drm/intel/-/issues/7632: @mattst88: is it acceptable to hide the /sys/kernel/debug/dri/0/i915_rps_boost_info file so that it doesn't cause confusion. And then user would have to go look at /sys/kernel/debug/dri/0/i915_guc_slpc_info or some such file when SLPC is being used? That's what the patch above is doing. Let's see what we hear from @mattst88. > > > >> guc_slpc_info already shows the number of boosts. Add num_waiters there > >> as well and disable rps_boost when SLPC is enabled. > >> > >> Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632 > >> Signed-off-by: Vinay Belgaumkar Thanks. -- Ashutosh