From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45FCBC433F5 for ; Tue, 4 Oct 2022 17:53:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D1F210E072; Tue, 4 Oct 2022 17:53:06 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id C197E10E072; Tue, 4 Oct 2022 17:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664905982; x=1696441982; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=q6EpAzeaREMD6X3gyCf0BKwJue0LMO9WqhXpb/0sZyA=; b=kLhEH0fgQpO7HnhgsOR9bLPhxPY2XDaaXzCQFMlVATqXoATGajQqLUUU jcS5v8s5JxNJT6jq4mQC7rLu3ZkO+O+YTGymLWIHjLq45CbwSJ7MMbNTc 8AXFwgab8DpvDSVy0F0NSDXBTxWe6x4FZIGlWfNxwA4kirt3B++fo1Y5G pp78nr9qPgdkX3Mq7r23wlmUJx5mc/cnbiH/8/ANDXa8yA4y99xYmWyN1 HoQgyVbsCWoIydUFKMKXLKKNcBU1x/+/JPfF1N6HlpxV0Tv9aFUuo4QH4 Co+EVIJyJ4gZoftlw6ZADZB8r/+8wGgYGPq1s1d7vFv5tVThwTRerRuW9 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="303959526" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="303959526" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 10:38:31 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="657211821" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="657211821" Received: from pvarla-mobl4.gar.corp.intel.com (HELO localhost) ([10.252.39.104]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 10:38:27 -0700 From: Jani Nikula To: Pablo Ceballos , David Airlie , Daniel Vetter In-Reply-To: <20220915004601.320198-1-pceballos@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220915004601.320198-1-pceballos@google.com> Date: Tue, 04 Oct 2022 20:38:24 +0300 Message-ID: <87ilkzsd4f.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915/display/lspcon: Increase LSPCON mode settle timeout X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Javier Martinez Canillas , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Thomas Zimmermann , Rodrigo Vivi , Sam Ravnborg , Pablo Ceballos Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 15 Sep 2022, Pablo Ceballos wrote: > On some devices the Parade PS175 takes more than 400ms to settle in PCON > mode. Got any bug report with more info, or any other details to back this up? This is kind of thin. What's the 800 ms based on? BR, Jani. > > Signed-off-by: Pablo Ceballos > --- > drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c > index 15d59de8810e..b4cbade13ee5 100644 > --- a/drivers/gpu/drm/i915/display/intel_lspcon.c > +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c > @@ -166,7 +166,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon, > drm_dbg_kms(&i915->drm, "Waiting for LSPCON mode %s to settle\n", > lspcon_mode_name(mode)); > > - wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400); > + wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 800); > if (current_mode != mode) > drm_err(&i915->drm, "LSPCON mode hasn't settled\n"); -- Jani Nikula, Intel Open Source Graphics Center