From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCAF2C00140 for ; Wed, 10 Aug 2022 10:09:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A983110F655; Wed, 10 Aug 2022 10:09:43 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7066B99539 for ; Wed, 10 Aug 2022 10:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660126149; x=1691662149; h=from:to:subject:in-reply-to:references:date:message-id: mime-version; bh=iSyf+GcUmxKKthWpaDCaZ+bNPFx/2iW+Br3vzKzOBl4=; b=k/bETjpKhenMbOoLqEMD1SLaL9pTHRPUNGmlGuILC6lRqaxSJoAoZDH4 U+nhh47LaTI0//rJ7bNXaN4mHqUNLIMEDEhSXGBWum+9DgEIsh9QGfQev NSYV/xp+fPaG4/hU8/QbzJwe45QnsFRRlahqxBnZUqiWmdf6tdoB464cD apZVyHj4+y86FlrXuA05CvYnHhlTs/0byt9BD+27At3i3KPHP/xxU9Zo3 Dh/HQshAURGrmFzsyadfN5Lg+u7Oyw5nYB9FhSVqF/MNA+1Cz3o8Xx0dZ nzhtn+lLoj3aEXxWD2IrxPeHEb0ngjjqeMkm4vXUgXlP5LY+tWXfPrET4 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10434"; a="270822313" X-IronPort-AV: E=Sophos;i="5.93,227,1654585200"; d="scan'208";a="270822313" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 03:09:07 -0700 X-IronPort-AV: E=Sophos;i="5.93,227,1654585200"; d="scan'208";a="664832722" Received: from iefimov-mobl1.ccr.corp.intel.com (HELO localhost) ([10.252.49.172]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 03:09:06 -0700 From: Jani Nikula To: "Murthy, Arun R" , "intel-gfx@lists.freedesktop.org" In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Wed, 10 Aug 2022 13:09:03 +0300 Message-ID: <87iln0v29s.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: replace BIT() with REG_BIT() in register definitions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 10 Aug 2022, "Murthy, Arun R" wrote: >> -----Original Message----- >> From: Intel-gfx On Behalf Of Jani >> Nikula >> Sent: Thursday, August 4, 2022 3:29 PM >> To: intel-gfx@lists.freedesktop.org >> Cc: Nikula, Jani >> Subject: [Intel-gfx] [PATCH 2/2] drm/i915/hdcp: replace BIT() with REG_BIT() >> in register definitions >> >> Registers contents are supposed to be defined using REG_BIT() to ensure >> they're u32 and the shift is within bounds. >> >> Signed-off-by: Jani Nikula >> --- > > Reviewed-by: Arun R Murthy Thanks for the review, pushed both. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center