From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 903E6C433EF for ; Wed, 13 Oct 2021 22:53:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5984261105 for ; Wed, 13 Oct 2021 22:53:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5984261105 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9836F6E882; Wed, 13 Oct 2021 22:53:10 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A8576E108; Wed, 13 Oct 2021 22:53:09 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="207672146" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="207672146" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 15:53:08 -0700 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="491677431" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.18.78]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 15:53:07 -0700 Date: Wed, 13 Oct 2021 15:53:06 -0700 Message-ID: <87ily0ilkd.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Cc: , In-Reply-To: <20211013224317.943625-1-John.C.Harrison@Intel.com> References: <20211013224317.943625-1-John.C.Harrison@Intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/i915: Skip gem_exec_fair on GuC based platforms X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 13 Oct 2021 15:43:17 -0700, wrote: > > From: John Harrison > > The gem_exec_fair test is specifically testing scheduler algorithm > performance. However, GuC does not implement the same algorithm as > execlist mode and this test is not applicable. So, until sw arch > approves a new algorithm and it is implemented in GuC, stop running > the test. > > Signed-off-by: John Harrison > --- > tests/i915/gem_exec_fair.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tests/i915/gem_exec_fair.c b/tests/i915/gem_exec_fair.c > index ef5a450f6..ca9c73c6e 100644 > --- a/tests/i915/gem_exec_fair.c > +++ b/tests/i915/gem_exec_fair.c > @@ -1314,6 +1314,12 @@ igt_main > igt_require(gem_scheduler_enabled(i915)); > igt_require(gem_scheduler_has_ctx_priority(i915)); > > + /* > + * These tests are for a specific scheduling model which is > + * not currently implemented by GuC. So skip on GuC platforms. > + */ > + igt_require(intel_gen(intel_get_drm_devid(i915)) < 12); Probably a feature check rather than a version check is better? Can we use say gem_has_guc_submission() instead? Though appears gem_has_guc_submission() only checks if guc submission is available, not if it is actually in use (unless guc will used when available automatically)? Is it possible to add the check if guc submission is actually in use? Or a check for guc scheduler? > + > cfg = intel_ctx_cfg_all_physical(i915); > > igt_info("CS timestamp frequency: %d\n", > -- > 2.25.1 >