From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3667C4320E for ; Tue, 24 Aug 2021 18:03:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5188610F8 for ; Tue, 24 Aug 2021 18:03:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A5188610F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F2766E0B9; Tue, 24 Aug 2021 18:03:14 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2CE486E0B8 for ; Tue, 24 Aug 2021 18:03:12 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10086"; a="204566655" X-IronPort-AV: E=Sophos;i="5.84,347,1620716400"; d="scan'208";a="204566655" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2021 11:03:11 -0700 X-IronPort-AV: E=Sophos;i="5.84,347,1620716400"; d="scan'208";a="526720533" Received: from romerosa-mobl.amr.corp.intel.com (HELO localhost) ([10.249.44.170]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2021 11:03:09 -0700 From: Jani Nikula To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com, daniel@ffwll.ch In-Reply-To: <87tujfezzr.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <87tujfezzr.fsf@intel.com> Date: Tue, 24 Aug 2021 21:03:05 +0300 Message-ID: <87ilzug1pi.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH 0/6] drm/i915/display: split out some dpt and fb stuff from intel_display.c X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 24 Aug 2021, Jani Nikula wrote: > On Tue, 24 Aug 2021, Rodrigo Vivi wrote: >> On Mon, Aug 23, 2021 at 03:25:30PM +0300, Jani Nikula wrote: >>> Make some forward progress on reducing intel_display.c size. >>> >>> Jani Nikula (6): >>> drm/i915/display: split out dpt out of intel_display.c >>> drm/i915: add HAS_ASYNC_FLIPS feature macro >>> drm/i915/fb: move intel_tile_width_bytes() to intel_fb.c >>> drm/i915/fb: move intel_fb_align_height() to intel_fb.c >>> drm/i915/fb: move intel_surf_alignment() to intel_fb.c >>> drm/i915/fb: move user framebuffer stuff to intel_fb.c >>> >>> drivers/gpu/drm/i915/Makefile | 1 + >>> drivers/gpu/drm/i915/display/intel_display.c | 709 +------------------ >>> drivers/gpu/drm/i915/display/intel_display.h | 6 - >>> drivers/gpu/drm/i915/display/intel_dpt.c | 229 ++++++ >>> drivers/gpu/drm/i915/display/intel_dpt.h | 19 + >>> drivers/gpu/drm/i915/display/intel_fb.c | 481 +++++++++++++ >>> drivers/gpu/drm/i915/display/intel_fb.h | 20 +- >>> drivers/gpu/drm/i915/display/intel_fbdev.c | 1 + >>> drivers/gpu/drm/i915/i915_drv.h | 2 + >>> 9 files changed, 752 insertions(+), 716 deletions(-) >>> create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.c >>> create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.h >> >> I believe it would be good to add a /** DOC: */ or at least >> a simple comment block explaining a bit what DPT is. > > I agree, but I'm not signing up for that! > >> But other than that the series looks good, so, up to you: >> >> Reviewed-by: Rodrigo Vivi >> (for the series) > > Thanks, > Jani And pushed. BR, Jani. > >> >>> >>> -- >>> 2.20.1 >>> -- Jani Nikula, Intel Open Source Graphics Center