From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915: Avoid refcount_inc on known zero count Date: Wed, 29 May 2019 15:13:25 +0300 Message-ID: <87imttsbkq.fsf@gaia.fi.intel.com> References: <20190528154053.22004-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C6E76E0FC for ; Wed, 29 May 2019 12:13:29 +0000 (UTC) In-Reply-To: <20190528154053.22004-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSW4gaW50 ZWxfd2FrZXJlZl9hdXRvLCB3ZSB1c2UgcmVmY291bnRfaW5jX25vdF96ZXJvIHRvIGRldGVjdCB0 aGUgZmlyc3QKPiB1c2UgYW5kIGluaXRpYWxpc2UgdGhlIHRpbWVyLiBPbiBkb2luZyBzbywgd2Ug aGF2ZSB0byBhdm9pZCB1c2luZwo+IHJlZmNvdW50X2luYyBvbiB0aGF0IHplcm8gY291bnQgYXMg dGhlIGRlYnVnIGNvZGUgZmxhZ3MgdGhhdCBhcyBhbgo+IGVycm9yOgo+IAlyZWZjb3VudF90OiBp bmNyZW1lbnQgb24gMDsgdXNlLWFmdGVyLWZyZWUuCj4KClllYWggdGhlcmUgYXJlIHJlaW5mb3Jj ZWQgdmVyc2lvbjogcmVmY291bnRfaW5jX2NoZWNrZWQsIHdoaWNoCkkgZmFpbGVkIHRvIG5vdGlj ZS4KCkkgZ3Vlc3MgdGhlIGdvb2QgbmV3cyBpcyB0aGF0IG5vdyB3ZSBoYXZlIHByb29mIHRoYXQg dGhlcmUgaXMKc29tZW9uZSB3YXRjaGluZyBvdXIgc2l4LgoKPiBSZWFycmFuZ2UgdGhlIGNvZGUg c28gdGhhdCBpZiB3ZSBrbm93IHRoZSBjb3VudCBpcyAwIGFuZCB3ZSBhcmUKPiBpbml0aWFsaXNp bmcsIHdlIGV4cGxpY2l0bHkgc2V0IGl0IHRvIDEuCj4KPiBGaXhlczogYjI3ZTM1YWU1YjE4ICgi ZHJtL2k5MTU6IEtlZXAgdXNlciBHR1RUIGFsaXZlIGZvciBhIG1pbmltdW0gb2YgMjUwbXMiKQo+ IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ IENjOiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dha2VyZWYuYyB8IDQgKystLQo+ICAxIGZp bGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dha2VyZWYuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3dha2VyZWYuYwo+IGluZGV4IGMyZGRhNWEzNzVmMC4uYzI1YmExYjVlOGJh IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dha2VyZWYuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dha2VyZWYuYwo+IEBAIC0xMTQsMTEgKzEx NCwxMSBAQCB2b2lkIGludGVsX3dha2VyZWZfYXV0byhzdHJ1Y3QgaW50ZWxfd2FrZXJlZl9hdXRv ICp3ZiwgdW5zaWduZWQgbG9uZyB0aW1lb3V0KQo+ICAKPiAgCWlmICghcmVmY291bnRfaW5jX25v dF96ZXJvKCZ3Zi0+Y291bnQpKSB7Cj4gIAkJc3Bpbl9sb2NrX2lycXNhdmUoJndmLT5sb2NrLCBm bGFncyk7Cj4gLQkJaWYgKCFyZWZjb3VudF9yZWFkKCZ3Zi0+Y291bnQpKSB7Cj4gKwkJaWYgKCFy ZWZjb3VudF9pbmNfbm90X3plcm8oJndmLT5jb3VudCkpIHsKCk9rLCBvdmVyZmxvdyBpcyBjaGVj a2VkIHdpdGggdGhpcy4KClJldmlld2VkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxh QGxpbnV4LmludGVsLmNvbT4KCgo+ICAJCQlHRU1fQlVHX09OKHdmLT53YWtlcmVmKTsKPiAgCQkJ d2YtPndha2VyZWYgPSBpbnRlbF9ydW50aW1lX3BtX2dldF9pZl9pbl91c2Uod2YtPmk5MTUpOwo+ ICsJCQlyZWZjb3VudF9zZXQoJndmLT5jb3VudCwgMSk7Cj4gIAkJfQo+IC0JCXJlZmNvdW50X2lu Yygmd2YtPmNvdW50KTsKPiAgCQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZ3Zi0+bG9jaywgZmxh Z3MpOwo+ICAJfQo+ICAKPiAtLSAKPiAyLjIwLjEKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4