From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/6] drm/i915: Reorder struct_mutex-vs-reset_lock in i915_gem_fault() Date: Thu, 21 Feb 2019 14:05:56 +0200 Message-ID: <87imxdwdln.fsf@gaia.fi.intel.com> References: <20190221102924.13442-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8A38A895A8 for ; Thu, 21 Feb 2019 12:06:18 +0000 (UTC) In-Reply-To: <20190221102924.13442-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQW5ub3lp bmdseSwgc3RydWN0X211dGV4IHdhcyBub3QgZW50aXJlbHkgZWxpbWluYXRlZCBmcm9tIHRoZSBy ZXNldAo+IHBhdGh3YXk7IGZvciByZWFzb25zIG9mIGl0cyBvd24sIGludGVsX2Rpc3BsYXlfcmVz dW1lcygpIHJlcXVpcmVzCj4gc3RydWN0X211dGV4IHRvIHByZXBhcmUgdGhlIHBsYW5lcyBpdCBh bHJlYWR5IGNhcHR1cmVkLiBUbyBhdm9pZCB0aGUKPiBpbW1lZGlhdGUgcHJvYmxlbSBvZiBhIGRl YWRsb2NrIGJldHdlZW4gdGhlIHN0cnVjdF9tdXRleCBhbmQgdGhlIHJlc2V0Cj4gc3JjdSwgd2Ug aGF2ZSB0byBhY3F1aXJlIHRoZSByZXNldF9sb2NrIGJlZm9yZSBzdHJ1Y3RfbXV0ZXggaW4KPiBp OTE1X2dlbV9mYXVsdCgpLiBOb3cgYW55IHdhaXQgdW5kZXJuZWF0aCBzdHJ1Y3RfbXV0ZXggd2ls bCByZXN1bHQgdXMgaW4KPiBoYXZpbmcgdG8gZm9yY2libHkgcmVzZXQgYWxsIGluZmxpZ2h0IHJl bmRlcmluZywgbGVzcyB0aGFuIGlkZWFsLgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29u IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3Vv cHBhbGFAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBh bGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW0uYyB8IDIwICsrKysrKysrKystLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNl cnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGlu ZGV4IGNjODhlNzk3NDQyMi4uNjJlNGRmMWNiZjg3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jCj4gQEAgLTE4MzQsOSArMTgzNCwxNSBAQCB2bV9mYXVsdF90IGk5MTVfZ2VtX2ZhdWx0KHN0 cnVjdCB2bV9mYXVsdCAqdm1mKQo+ICAKPiAgCXdha2VyZWYgPSBpbnRlbF9ydW50aW1lX3BtX2dl dChkZXZfcHJpdik7Cj4gIAo+ICsJc3JjdSA9IGk5MTVfcmVzZXRfdHJ5bG9jayhkZXZfcHJpdik7 Cj4gKwlpZiAoc3JjdSA8IDApIHsKPiArCQlyZXQgPSBzcmN1Owo+ICsJCWdvdG8gZXJyX3JwbTsK PiArCX0KPiArCj4gIAlyZXQgPSBpOTE1X211dGV4X2xvY2tfaW50ZXJydXB0aWJsZShkZXYpOwo+ ICAJaWYgKHJldCkKPiAtCQlnb3RvIGVycl9ycG07Cj4gKwkJZ290byBlcnJfcmVzZXQ7Cj4gIAo+ ICAJLyogQWNjZXNzIHRvIHNub29wYWJsZSBwYWdlcyB0aHJvdWdoIHRoZSBHVFQgaXMgaW5jb2hl cmVudC4gKi8KPiAgCWlmIChvYmotPmNhY2hlX2xldmVsICE9IEk5MTVfQ0FDSEVfTk9ORSAmJiAh SEFTX0xMQyhkZXZfcHJpdikpIHsKPiBAQCAtMTg4NSwxMiArMTg5MSw2IEBAIHZtX2ZhdWx0X3Qg aTkxNV9nZW1fZmF1bHQoc3RydWN0IHZtX2ZhdWx0ICp2bWYpCj4gIAlpZiAocmV0KQo+ICAJCWdv dG8gZXJyX3VucGluOwo+ICAKPiAtCXNyY3UgPSBpOTE1X3Jlc2V0X3RyeWxvY2soZGV2X3ByaXYp Owo+IC0JaWYgKHNyY3UgPCAwKSB7Cj4gLQkJcmV0ID0gc3JjdTsKPiAtCQlnb3RvIGVycl9mZW5j ZTsKPiAtCX0KPiAtCj4gIAkvKiBGaW5hbGx5LCByZW1hcCBpdCB1c2luZyB0aGUgbmV3IEdUVCBv ZmZzZXQgKi8KPiAgCXJldCA9IHJlbWFwX2lvX21hcHBpbmcoYXJlYSwKPiAgCQkJICAgICAgIGFy ZWEtPnZtX3N0YXJ0ICsgKHZtYS0+Z2d0dF92aWV3LnBhcnRpYWwub2Zmc2V0IDw8IFBBR0VfU0hJ RlQpLAo+IEBAIC0xODk4LDcgKzE4OTgsNyBAQCB2bV9mYXVsdF90IGk5MTVfZ2VtX2ZhdWx0KHN0 cnVjdCB2bV9mYXVsdCAqdm1mKQo+ICAJCQkgICAgICAgbWluX3QodTY0LCB2bWEtPnNpemUsIGFy ZWEtPnZtX2VuZCAtIGFyZWEtPnZtX3N0YXJ0KSwKPiAgCQkJICAgICAgICZnZ3R0LT5pb21hcCk7 Cj4gIAlpZiAocmV0KQo+IC0JCWdvdG8gZXJyX3Jlc2V0Owo+ICsJCWdvdG8gZXJyX2ZlbmNlOwo+ ICAKPiAgCS8qIE1hcmsgYXMgYmVpbmcgbW1hcHBlZCBpbnRvIHVzZXJzcGFjZSBmb3IgbGF0ZXIg cmV2b2NhdGlvbiAqLwo+ICAJYXNzZXJ0X3JwbV93YWtlbG9ja19oZWxkKGRldl9wcml2KTsKPiBA QCAtMTkwOCwxNCArMTkwOCwxNCBAQCB2bV9mYXVsdF90IGk5MTVfZ2VtX2ZhdWx0KHN0cnVjdCB2 bV9mYXVsdCAqdm1mKQo+ICAKPiAgCWk5MTVfdm1hX3NldF9nZ3R0X3dyaXRlKHZtYSk7Cj4gIAo+ IC1lcnJfcmVzZXQ6Cj4gLQlpOTE1X3Jlc2V0X3VubG9jayhkZXZfcHJpdiwgc3JjdSk7Cj4gIGVy cl9mZW5jZToKPiAgCWk5MTVfdm1hX3VucGluX2ZlbmNlKHZtYSk7Cj4gIGVycl91bnBpbjoKPiAg CV9faTkxNV92bWFfdW5waW4odm1hKTsKPiAgZXJyX3VubG9jazoKPiAgCW11dGV4X3VubG9jaygm ZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICtlcnJfcmVzZXQ6Cj4gKwlpOTE1X3Jlc2V0X3VubG9jayhk ZXZfcHJpdiwgc3JjdSk7Cj4gIGVycl9ycG06Cj4gIAlpbnRlbF9ydW50aW1lX3BtX3B1dChkZXZf cHJpdiwgd2FrZXJlZik7Cj4gIAlpOTE1X2dlbV9vYmplY3RfdW5waW5fcGFnZXMob2JqKTsKPiAt LSAKPiAyLjIwLjEKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=