From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2 2/2] drm/i915: Abandon the reset if we fail to stop the engines Date: Fri, 27 Oct 2017 15:18:44 +0300 Message-ID: <87inf0g4wr.fsf@gaia.fi.intel.com> References: <20171027104011.2341-1-chris@chris-wilson.co.uk> <20171027104011.2341-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id A87FE6E910 for ; Fri, 27 Oct 2017 12:20:03 +0000 (UTC) In-Reply-To: <20171027104011.2341-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gU29tZSBt YWNoaW5lcywgKmNvdWdoKiBzbmIgKmNvdWdoKiwgZmFpbCBjYXRhc3Ryb3BoaWNhbGx5IGlmIGFz a2VkIHRvCj4gcmVzZXQgdGhlIEdQVSB1bmRlciBjZXJ0YWluIGNvbmRpdGlvbnMuIFRoZSBpbml0 aWFsIGd1ZXNzIGlzIHRoYXQgdGhpcwo+IGlzIHdoZW4gdGhlIHJpbmdzIGFyZSBzdGlsbCBidXN5 IGF0IHRoZSB0aW1lIG9mIHRoZSByZXNldCByZXF1ZXN0Cj4gKGJlY2F1c2UgdGhhdCdzIGEgcGF0 dGVybiB3ZSd2ZSBzZWVuIGVsc2V3aGVyZSwgaGVuY2Ugd2h5IHdlIGRvIHRyeQo+IGdlbjNfc3Rv cF9lbmdpbmVzKCkgYmVmb3JlIHJlc2V0KSBzbyBhYmFuZG9uIHRoZSByZXNldCBhbmQgbGVhdmUg dGhlCj4gZGV2aWNlIHdlZGdlZCwgaWYgZ2VuM19zdG9wX2VuZ2luZXMoKSBmYWlscy4KPgo+IHYy OiBPbmx5IGdpdmUgdXAgaWYgbm90IGlkbGUgYWZ0ZXIgZW1wdHlpbmcgdGhlIHJpbmcuCj4KPiBC dWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAz MjQwCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYyB8IDQzICsrKysrKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMzIGluc2Vy dGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3VuY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3Jl LmMKPiBpbmRleCA5NmVlNmIyNzU0YmUuLmY4MGRiZmYzNTk1ZiAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3VuY29yZS5jCj4gQEAgLTEzNzIsNyArMTM3Miw3IEBAIGludCBpOTE1X3JlZ19y ZWFkX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4g IAo+IC1zdGF0aWMgdm9pZCBnZW4zX3N0b3BfZW5naW5lKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSkKPiArc3RhdGljIGJvb2wgZ2VuM19zdG9wX2VuZ2luZShzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IGVuZ2luZS0+aTkxNTsKPiAgCWNvbnN0IHUzMiBiYXNlID0gZW5naW5lLT5tbWlvX2Jhc2U7 Cj4gQEAgLTEzOTIsMjYgKzEzOTIsNDYgQEAgc3RhdGljIHZvaWQgZ2VuM19zdG9wX2VuZ2luZShz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAlJOTE1X1dSSVRFX0ZXKFJJTkdfSEVB RChiYXNlKSwgMCk7Cj4gIAlJOTE1X1dSSVRFX0ZXKFJJTkdfVEFJTChiYXNlKSwgMCk7Cj4gIAo+ ICsJLyogQ2hlY2sgYWN0cyBhcyBhIHBvc3QgKi8KPiArCWlmIChpbnRlbF93YWl0X2Zvcl9yZWdp c3Rlcl9mdyhkZXZfcHJpdiwKPiArCQkJCSAgICAgICBtb2RlLAo+ICsJCQkJICAgICAgIE1PREVf SURMRSwKPiArCQkJCSAgICAgICBNT0RFX0lETEUsCj4gKwkJCQkgICAgICAgMTAwMCkpIHsKPiAr CQlEUk1fREVCVUdfRFJJVkVSKCIlczogdGltZWQgb3V0IGFmdGVyIGNsZWFyaW5nIHJpbmdcbiIs Cj4gKwkJCQkgZW5naW5lLT5uYW1lKTsKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwl9Cj4gKwoKSSBy ZWNhbGwgdGhhdCB0aGlzIGJhaWxvdXQgd2FzIHRoZSByZWFzb24gSSBkaWRuJ3Qgd2FudCB0bwp1 c2UgdGhlIHN0b3BfcmluZyBpbiBpbnRlbF9yaW5nYnVmZmVyLmMKCk5vdyBpZiB5b3UgY2hvb3Nl IHRvIHJlaW50cm9kdWNlIHRoZSBiYWlsb3V0LCBJIHRoaW5rIHlvdSBjYW4KbWFrZSBhIGdlbmVy aWMgc3RvcF9lbmdpbmUgYW5kIGdldCByaWQgb2YgdGhlIGNvcHkuCgotTWlrYQoKPiAgCS8qIFRo ZSByaW5nIG11c3QgYmUgZW1wdHkgYmVmb3JlIGl0IGlzIGRpc2FibGVkICovCj4gIAlJOTE1X1dS SVRFX0ZXKFJJTkdfQ1RMKGJhc2UpLCAwKTsKPiArCVBPU1RJTkdfUkVBRF9GVyhSSU5HX0NUTChi YXNlKSk7Cj4gIAo+IC0JLyogQ2hlY2sgYWN0cyBhcyBhIHBvc3QgKi8KPiAtCWlmIChJOTE1X1JF QURfRlcoUklOR19IRUFEKGJhc2UpKSAhPSAwKQo+IC0JCURSTV9ERUJVR19EUklWRVIoIiVzOiBy aW5nIGhlYWQgbm90IHBhcmtlZFxuIiwKPiAtCQkJCSBlbmdpbmUtPm5hbWUpOwo+ICsJcmV0dXJu IHRydWU7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGk5MTVfc3RvcF9lbmdpbmVzKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkJICAgICAgdW5zaWduZWQgZW5naW5lX21h c2spCj4gK3N0YXRpYyBpbnQgaTkxNV9zdG9wX2VuZ2luZXMoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LAo+ICsJCQkgICAgIHVuc2lnbmVkIGVuZ2luZV9tYXNrKQo+ICB7Cj4gIAlz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4gIAllbnVtIGludGVsX2VuZ2luZV9pZCBp ZDsKPiArCWJvb2wgaWRsZTsKPiAgCj4gIAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDMpCj4g LQkJcmV0dXJuOwo+ICsJCXJldHVybiB0cnVlOwo+ICAKPiArCWlkbGUgPSB0cnVlOwo+ICAJZm9y X2VhY2hfZW5naW5lX21hc2tlZChlbmdpbmUsIGRldl9wcml2LCBlbmdpbmVfbWFzaywgaWQpCj4g LQkJZ2VuM19zdG9wX2VuZ2luZShlbmdpbmUpOwo+ICsJCWlkbGUgJj0gZ2VuM19zdG9wX2VuZ2lu ZShlbmdpbmUpOwo+ICsJaWYgKGlkbGUpCj4gKwkJcmV0dXJuIHRydWU7Cj4gKwo+ICsJZGV2X2Vy cihkZXZfcHJpdi0+ZHJtLmRldiwgIkZhaWxlZCB0byBzdG9wIGFsbCBlbmdpbmVzXG4iKTsKPiAr CWZvcl9lYWNoX2VuZ2luZV9tYXNrZWQoZW5naW5lLCBkZXZfcHJpdiwgZW5naW5lX21hc2ssIGlk KSB7Cj4gKwkJc3RydWN0IGRybV9wcmludGVyIHAgPSBkcm1fZGVidWdfcHJpbnRlcihfX2Z1bmNf Xyk7Cj4gKwkJaW50ZWxfZW5naW5lX2R1bXAoZW5naW5lLCAmcCk7Cj4gKwl9Cj4gKwlyZXR1cm4g ZmFsc2U7Cj4gIH0KPiAgCj4gIHN0YXRpYyBib29sIGk5MTVfcmVzZXRfY29tcGxldGUoc3RydWN0 IHBjaV9kZXYgKnBkZXYpCj4gQEAgLTE3NzIsNyArMTc5MiwxMCBAQCBpbnQgaW50ZWxfZ3B1X3Jl c2V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdW5zaWduZWQgZW5naW5lX21h c2spCj4gIAkJICoKPiAgCQkgKiBGSVhNRTogV2EgZm9yIG1vcmUgbW9kZXJuIGdlbnMgbmVlZHMg dG8gYmUgdmFsaWRhdGVkCj4gIAkJICovCj4gLQkJaTkxNV9zdG9wX2VuZ2luZXMoZGV2X3ByaXYs IGVuZ2luZV9tYXNrKTsKPiArCQlpZiAoIWk5MTVfc3RvcF9lbmdpbmVzKGRldl9wcml2LCBlbmdp bmVfbWFzaykpIHsKPiArCQkJcmV0ID0gLUVJTzsKPiArCQkJYnJlYWs7Cj4gKwkJfQo+ICAKPiAg CQlyZXQgPSAtRU5PREVWOwo+ICAJCWlmIChyZXNldCkKPiAtLSAKPiAyLjE1LjAucmMyCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=