Re: [PATCH i-g-t v4 4/6] tests/kms_ccs: Test case where the CCS buffer was not provided

From: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org,
	tomeu.vizoso@collabora.com
Subject: Re: [PATCH i-g-t v4 4/6] tests/kms_ccs: Test case where the CCS buffer was not provided
Date: Mon, 09 Oct 2017 03:14:14 -0300	[thread overview]
Message-ID: <87infox2yx.fsf@dilma.collabora.co.uk> (raw)
In-Reply-To: <20171003163532.GB19707@mail.bwidawsk.net> (Ben Widawsky's message of "Tue, 3 Oct 2017 09:35:33 -0700")

Ben Widawsky <ben@bwidawsk.net> writes:

> On 17-09-27 15:34:17, Gabriel Krisman Bertazi wrote:
>>Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
>>---
>> tests/kms_ccs.c | 37 +++++++++++++++++++++++++++----------
>> 1 file changed, 27 insertions(+), 10 deletions(-)
>>
>>diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
>>index 73025a1e019f..35dfcca6be14 100644
>>--- a/tests/kms_ccs.c
>>+++ b/tests/kms_ccs.c
>>@@ -33,8 +33,12 @@ enum test_flags {
>> 	TEST_ROTATE_180			= 1 << 2,
>> 	TEST_BAD_PIXEL_FORMAT		= 1 << 3,
>> 	TEST_BAD_ROTATION_90		= 1 << 4,
>>+	TEST_NO_AUX_BUFFER		= 1 << 5,
>> };
>>
>>+#define TEST_FAIL_ON_ADDFB2 \
>>+	(TEST_BAD_PIXEL_FORMAT | TEST_NO_AUX_BUFFER)
>>+
>
> Adding the define confuses things more than it helps IMO.
>
>> enum test_fb_flags {
>> 	FB_COMPRESSED			= 1 << 0,
>> 	FB_HAS_PLANE			= 1 << 1,
>>@@ -315,22 +319,29 @@ static void generate_fb(data_t *data, struct igt_fb *fb,
>> 		 */
>> 		int ccs_width = ALIGN(width * 4, 32) / 32;
>> 		int ccs_height = ALIGN(height, 16) / 16;
>>-		f.pitches[1] = ALIGN(ccs_width * 1, 128);
>>-		f.modifier[1] = modifier;
>
> I think the case you're trying to test should have the modifier set for plane1,
> just no handle, size or whatever. If you don't do this, I'm not sure what you're
> actually testing.

So, if I understood correctly, leaving the modifier unset was requested
by Daniels on a previous review:

https://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg129817.html

-- 
Gabriel Krisman Bertazi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx