intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] dim: Accept author x signed-off based on email.
Date: Tue, 26 Sep 2017 16:24:35 +0300	[thread overview]
Message-ID: <87ing58uek.fsf@intel.com> (raw)
In-Reply-To: <20170926115907.jrcyqcxqcgpjbjel@phenom.ffwll.local>

On Tue, 26 Sep 2017, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Sep 21, 2017 at 06:27:28AM -0700, Rodrigo Vivi wrote:
>> On Thu, Sep 21, 2017 at 11:12:52AM +0000, Jani Nikula wrote:
>> > On Wed, 20 Sep 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>> > > It seems Patchwork or SMTP servers are messing some patches
>> > > and changing the original git's author name on git per "Last, First".
>> > > So we end up with a mismatch were signed-off uses one name format
>> > > and author is using another format.
>> > >
>> > > So, let's check for email addresses instead.
>> > >
>> > > v2: Avoid useles warning and only check for email.
>> > >
>> > > Cc: Jani Nikula <jani.nikula@intel.com>
>> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> > 
>> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>> 
>> pushed, thanks.
>
> Yeah except this breaks funny people like me who use different mails for
> stuff. My idea with fixing this was that we parse the mail name and check
> for both "Last, First" and "First Last" to work around the outlook crap.
>
> I really don't want to send mail from @intel.com to anywhere near public
> stuff.

Ok, I'm fine with reverting, and finding another way.

BR,
Jani.

> -Daniel
>
>> 
>> > 
>> > > ---
>> > >  dim | 2 +-
>> > >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > diff --git a/dim b/dim
>> > > index dbaeb1ec944d..a63000fb67a8 100755
>> > > --- a/dim
>> > > +++ b/dim
>> > > @@ -689,7 +689,7 @@ function checkpatch_commit_push
>> > >  	sha1=$1
>> > >  
>> > >  	# use real names for people with many different email addresses
>> > > -	author=$(git show -s $sha1 --format="format:%an")
>> > > +	author=$(git show -s $sha1 --format="format:%ae")
>> > >  	committer=$(git show -s $sha1 --format="format:%cn")
>> > >  
>> > >  	# check for author sign-off
>> > 
>> > -- 
>> > Jani Nikula, Intel Open Source Technology Center
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-09-26 13:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 17:48 [PATCH] dim: Accept author x signed-off based on email, but warn Rodrigo Vivi
2017-09-20  7:56 ` Jani Nikula
2017-09-20 11:02 ` Joonas Lahtinen
2017-09-20 11:51   ` Jani Nikula
2017-09-20 12:46     ` Rodrigo Vivi
2017-09-20 12:49     ` [PATCH] dim: Accept author x signed-off based on email Rodrigo Vivi
2017-09-21 11:12       ` Jani Nikula
2017-09-21 13:27         ` Rodrigo Vivi
2017-09-26 11:59           ` Daniel Vetter
2017-09-26 13:24             ` Jani Nikula [this message]
2017-09-26 16:55               ` Rodrigo Vivi
2017-09-27 12:14                 ` Daniel Vetter
2017-09-27 15:39                   ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ing58uek.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).