* [PATCH] drm/i915: KW fix in intel_dsi_dcs_backlight.c
@ 2017-08-03 8:00 Balasubramaniam, Hari Chand
2017-08-03 8:23 ` ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Balasubramaniam, Hari Chand @ 2017-08-03 8:00 UTC (permalink / raw)
To: intel-gfx; +Cc: Balasubramaniam, Hari Chand
variable 'data' might be used uninitialized in this function.
Thus, adding NULL initialized to 'data' variable.
SQUASHME! - This patch should be squashed into following existing patch
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Author: Deepak M <m.deepak@intel.com>
Date: Wed Apr 19 15:49:02 2017 +0800
drm/i915/dsi: Add DCS control for Panel PWM
If the source of the backlight PWM is from the
panel then the PWM can be controlled by DCS
command, this patch adds the support to
enable/disbale panel PWM, control backlight level
etc...
v2: Moving the CABC bkl functions to new file.(Jani)
v3: Rebase
v4: Rebase
v5: Use mipi_dsi_dcs_write() instead of mipi_dsi_dcs_write_buffer() (Jani)
Move DCS macro`s to include/video/mipi_display.h (Jani)
v6: Rename the file to intel_dsi_panel_pwm.c
Removing the CABC operations
v7 by Jani: renames, rebases, etc.
v8 by Jani: s/INTEL_BACKLIGHT_CABC/INTEL_BACKLIGHT_DSI_DCS/
v9 by Jani: rename init function to intel_dsi_dcs_init_backlight_funcs
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Yetunde Adebisi <yetundex.adebisi@intel.com>
Signed-off-by: Deepak M <m.deepak@intel.com>
Reviewed-by: Yetunde Adebisi <yetundex.adebisi@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/71238a4b14b8c3a6c04070c789f09f1b4bc00a15.1461676337.git.jani.nikula@intel.com
(cherry picked from commit 90198355b83c79e2158ec591085858b191f08502)
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Change-Id: Icab0769c56fbb59f24d35fcb0a14c21a858bf8ac
Change-Id: Ib16bdda6c1950efddf66e31ab3172a2a17b09bc9
Signed-off-by: Balasubramaniam, Hari Chand <hari.chand.balasubramaniam@intel.com>
---
drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c b/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
index ac7c602..eec4585 100644
--- a/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
+++ b/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
@@ -46,7 +46,7 @@ static u32 dcs_get_backlight(struct intel_connector *connector)
struct intel_encoder *encoder = connector->encoder;
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
struct mipi_dsi_device *dsi_device;
- u8 data;
+ u8 data = 0;
enum port port;
/* FIXME: Need to take care of 16 bit brightness level */
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: KW fix in intel_dsi_dcs_backlight.c
2017-08-03 8:00 [PATCH] drm/i915: KW fix in intel_dsi_dcs_backlight.c Balasubramaniam, Hari Chand
@ 2017-08-03 8:23 ` Patchwork
2017-08-03 12:39 ` [PATCH] " Jani Nikula
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-08-03 8:23 UTC (permalink / raw)
To: Balasubramaniam, Hari Chand; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: KW fix in intel_dsi_dcs_backlight.c
URL : https://patchwork.freedesktop.org/series/28291/
State : success
== Summary ==
Series 28291v1 drm/i915: KW fix in intel_dsi_dcs_backlight.c
https://patchwork.freedesktop.org/api/1.0/series/28291/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-a:
pass -> DMESG-WARN (fi-pnv-d510) fdo#101597 +1
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-byt-n2820) fdo#101705
fdo#101597 https://bugs.freedesktop.org/show_bug.cgi?id=101597
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:280 pass:269 dwarn:0 dfail:0 fail:0 skip:11 time:451s
fi-bdw-gvtdvm total:280 pass:266 dwarn:0 dfail:0 fail:0 skip:14 time:434s
fi-blb-e6850 total:280 pass:225 dwarn:1 dfail:0 fail:0 skip:54 time:357s
fi-bsw-n3050 total:280 pass:244 dwarn:0 dfail:0 fail:0 skip:36 time:540s
fi-bxt-j4205 total:280 pass:261 dwarn:0 dfail:0 fail:0 skip:19 time:511s
fi-byt-n2820 total:280 pass:252 dwarn:0 dfail:0 fail:0 skip:28 time:503s
fi-glk-2a total:280 pass:261 dwarn:0 dfail:0 fail:0 skip:19 time:604s
fi-hsw-4770 total:280 pass:264 dwarn:0 dfail:0 fail:0 skip:16 time:439s
fi-hsw-4770r total:280 pass:264 dwarn:0 dfail:0 fail:0 skip:16 time:417s
fi-ilk-650 total:280 pass:230 dwarn:0 dfail:0 fail:0 skip:50 time:416s
fi-ivb-3520m total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:499s
fi-ivb-3770 total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:475s
fi-kbl-7500u total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:465s
fi-kbl-7560u total:280 pass:270 dwarn:0 dfail:0 fail:0 skip:10 time:579s
fi-kbl-r total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:586s
fi-pnv-d510 total:280 pass:222 dwarn:3 dfail:0 fail:0 skip:55 time:564s
fi-skl-6260u total:280 pass:270 dwarn:0 dfail:0 fail:0 skip:10 time:457s
fi-skl-6700hq total:280 pass:263 dwarn:0 dfail:0 fail:0 skip:17 time:582s
fi-skl-6700k total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:475s
fi-skl-6770hq total:280 pass:270 dwarn:0 dfail:0 fail:0 skip:10 time:478s
fi-skl-gvtdvm total:280 pass:267 dwarn:0 dfail:0 fail:0 skip:13 time:434s
fi-skl-x1585l total:280 pass:269 dwarn:0 dfail:0 fail:0 skip:11 time:478s
fi-snb-2520m total:280 pass:252 dwarn:0 dfail:0 fail:0 skip:28 time:551s
fi-snb-2600 total:280 pass:251 dwarn:0 dfail:0 fail:0 skip:29 time:406s
fcb630a80579faf6d12ee62cb49bd7a4acff41e6 drm-tip: 2017y-08m-01d-17h-14m-57s UTC integration manifest
b1d080e3ea65 drm/i915: KW fix in intel_dsi_dcs_backlight.c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5315/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: KW fix in intel_dsi_dcs_backlight.c
2017-08-03 8:00 [PATCH] drm/i915: KW fix in intel_dsi_dcs_backlight.c Balasubramaniam, Hari Chand
2017-08-03 8:23 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-08-03 12:39 ` Jani Nikula
2017-08-15 2:05 ` [PATCH] drm/i915: Initialize 'data' " Balasubramaniam, Hari Chand
2017-08-15 8:17 ` ✓ Fi.CI.BAT: success for drm/i915: KW fix in intel_dsi_dcs_backlight.c (rev2) Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2017-08-03 12:39 UTC (permalink / raw)
To: intel-gfx; +Cc: Balasubramaniam, Hari Chand
On Thu, 03 Aug 2017, "Balasubramaniam, Hari Chand" <hari.chand.balasubramaniam@intel.com> wrote:
> variable 'data' might be used uninitialized in this function.
>
> Thus, adding NULL initialized to 'data' variable.
>
> SQUASHME! - This patch should be squashed into following existing patch
The upstream commit has been merged and released in v4.8, kind of hard
to squash! And the commit is in fact
commit 90198355b83c79e2158ec591085858b191f08502
Author: Jani Nikula <jani.nikula@intel.com>
Date: Tue Apr 26 16:14:25 2016 +0300
drm/i915/dsi: Add DCS control for Panel PWM
Please update the commit message to reflect upstream. You'll also need
Fixes: 90198355b83c ("drm/i915/dsi: Add DCS control for Panel PWM")
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Yetunde Adebisi <yetundex.adebisi@intel.com>
Cc: Deepak M <m.deepak@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
BR,
Jani.
>
> Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Author: Deepak M <m.deepak@intel.com>
> Date: Wed Apr 19 15:49:02 2017 +0800
>
> drm/i915/dsi: Add DCS control for Panel PWM
>
> If the source of the backlight PWM is from the
> panel then the PWM can be controlled by DCS
> command, this patch adds the support to
> enable/disbale panel PWM, control backlight level
> etc...
>
> v2: Moving the CABC bkl functions to new file.(Jani)
>
> v3: Rebase
>
> v4: Rebase
>
> v5: Use mipi_dsi_dcs_write() instead of mipi_dsi_dcs_write_buffer() (Jani)
> Move DCS macro`s to include/video/mipi_display.h (Jani)
>
> v6: Rename the file to intel_dsi_panel_pwm.c
> Removing the CABC operations
>
> v7 by Jani: renames, rebases, etc.
>
> v8 by Jani: s/INTEL_BACKLIGHT_CABC/INTEL_BACKLIGHT_DSI_DCS/
>
> v9 by Jani: rename init function to intel_dsi_dcs_init_backlight_funcs
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Yetunde Adebisi <yetundex.adebisi@intel.com>
> Signed-off-by: Deepak M <m.deepak@intel.com>
> Reviewed-by: Yetunde Adebisi <yetundex.adebisi@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Link: http://patchwork.freedesktop.org/patch/msgid/71238a4b14b8c3a6c04070c789f09f1b4bc00a15.1461676337.git.jani.nikula@intel.com
> (cherry picked from commit 90198355b83c79e2158ec591085858b191f08502)
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>
> Change-Id: Icab0769c56fbb59f24d35fcb0a14c21a858bf8ac
>
> Change-Id: Ib16bdda6c1950efddf66e31ab3172a2a17b09bc9
> Signed-off-by: Balasubramaniam, Hari Chand <hari.chand.balasubramaniam@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c b/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
> index ac7c602..eec4585 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
> +++ b/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
> @@ -46,7 +46,7 @@ static u32 dcs_get_backlight(struct intel_connector *connector)
> struct intel_encoder *encoder = connector->encoder;
> struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
> struct mipi_dsi_device *dsi_device;
> - u8 data;
> + u8 data = 0;
> enum port port;
>
> /* FIXME: Need to take care of 16 bit brightness level */
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] drm/i915: Initialize 'data' in intel_dsi_dcs_backlight.c
2017-08-03 8:00 [PATCH] drm/i915: KW fix in intel_dsi_dcs_backlight.c Balasubramaniam, Hari Chand
2017-08-03 8:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-03 12:39 ` [PATCH] " Jani Nikula
@ 2017-08-15 2:05 ` Balasubramaniam, Hari Chand
2017-08-15 8:07 ` Jani Nikula
2017-08-15 8:17 ` ✓ Fi.CI.BAT: success for drm/i915: KW fix in intel_dsi_dcs_backlight.c (rev2) Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: Balasubramaniam, Hari Chand @ 2017-08-15 2:05 UTC (permalink / raw)
To: intel-gfx
Cc: Jani Nikula, Deepak M, Yetunde Adebisi, Daniel Vetter,
Balasubramaniam, Hari Chand
variable 'data'is used uninitialized in this function. thus, 'function dcs_get_backlight'
will return unwanted value/fail.
Thus, adding NULL initialized to 'data' variable will solve the return
failure happening.
v2: Change commit message to reflect upstream with proper message
Change-Id: I3e2d3369601c119d3527efc454ea4367d7306416
Fixes: 90198355b83c ("drm/i915/dsi: Add DCS control for Panel PWM")
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Yetunde Adebisi <yetundex.adebisi@intel.com>
Cc: Deepak M <m.deepak@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Balasubramaniam, Hari Chand <hari.chand.balasubramaniam@intel.com>
---
drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c b/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
index ac7c602..eec4585 100644
--- a/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
+++ b/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
@@ -46,7 +46,7 @@ static u32 dcs_get_backlight(struct intel_connector *connector)
struct intel_encoder *encoder = connector->encoder;
struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
struct mipi_dsi_device *dsi_device;
- u8 data;
+ u8 data = 0;
enum port port;
/* FIXME: Need to take care of 16 bit brightness level */
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Initialize 'data' in intel_dsi_dcs_backlight.c
2017-08-15 2:05 ` [PATCH] drm/i915: Initialize 'data' " Balasubramaniam, Hari Chand
@ 2017-08-15 8:07 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2017-08-15 8:07 UTC (permalink / raw)
To: intel-gfx
Cc: Yetunde Adebisi, Daniel Vetter, Deepak M,
Balasubramaniam, Hari Chand
On Tue, 15 Aug 2017, "Balasubramaniam, Hari Chand" <hari.chand.balasubramaniam@intel.com> wrote:
> variable 'data'is used uninitialized in this function. thus, 'function dcs_get_backlight'
> will return unwanted value/fail.
>
> Thus, adding NULL initialized to 'data' variable will solve the return
> failure happening.
Pushed to drm-intel-next-queued, thanks for the patch.
BR,
Jani.
>
> v2: Change commit message to reflect upstream with proper message
>
> Change-Id: I3e2d3369601c119d3527efc454ea4367d7306416
> Fixes: 90198355b83c ("drm/i915/dsi: Add DCS control for Panel PWM")
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Yetunde Adebisi <yetundex.adebisi@intel.com>
> Cc: Deepak M <m.deepak@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Balasubramaniam, Hari Chand <hari.chand.balasubramaniam@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c b/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
> index ac7c602..eec4585 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
> +++ b/drivers/gpu/drm/i915/intel_dsi_dcs_backlight.c
> @@ -46,7 +46,7 @@ static u32 dcs_get_backlight(struct intel_connector *connector)
> struct intel_encoder *encoder = connector->encoder;
> struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
> struct mipi_dsi_device *dsi_device;
> - u8 data;
> + u8 data = 0;
> enum port port;
>
> /* FIXME: Need to take care of 16 bit brightness level */
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: KW fix in intel_dsi_dcs_backlight.c (rev2)
2017-08-03 8:00 [PATCH] drm/i915: KW fix in intel_dsi_dcs_backlight.c Balasubramaniam, Hari Chand
` (2 preceding siblings ...)
2017-08-15 2:05 ` [PATCH] drm/i915: Initialize 'data' " Balasubramaniam, Hari Chand
@ 2017-08-15 8:17 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-08-15 8:17 UTC (permalink / raw)
To: Balasubramaniam, Hari Chand; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: KW fix in intel_dsi_dcs_backlight.c (rev2)
URL : https://patchwork.freedesktop.org/series/28291/
State : success
== Summary ==
Series 28291v2 drm/i915: KW fix in intel_dsi_dcs_backlight.c
https://patchwork.freedesktop.org/api/1.0/series/28291/revisions/2/mbox/
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:447s
fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:549s
fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:517s
fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:520s
fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:514s
fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:603s
fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:423s
fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:508s
fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:584s
fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:532s
fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:471s
fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:473s
6e63b790f851e8756624cfdf145a02b2eadf5634 drm-tip: 2017y-08m-14d-21h-10m-56s UTC integration manifest
8710818ffc8e drm/i915: Initialize 'data' in intel_dsi_dcs_backlight.c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5398/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-15 8:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-03 8:00 [PATCH] drm/i915: KW fix in intel_dsi_dcs_backlight.c Balasubramaniam, Hari Chand
2017-08-03 8:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-03 12:39 ` [PATCH] " Jani Nikula
2017-08-15 2:05 ` [PATCH] drm/i915: Initialize 'data' " Balasubramaniam, Hari Chand
2017-08-15 8:07 ` Jani Nikula
2017-08-15 8:17 ` ✓ Fi.CI.BAT: success for drm/i915: KW fix in intel_dsi_dcs_backlight.c (rev2) Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox