* [PATCH] drm/i915: make skl_ddb_add_affected_planes static
@ 2016-10-04 9:29 Jani Nikula
2016-10-04 10:19 ` ✗ Fi.CI.BAT: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2016-10-04 9:29 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Paulo Zanoni
Fix sparse warning:
drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol
'skl_ddb_add_affected_planes' was not declared. Should it be static?
Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually affected by ddb changes")
Cc: Lyude <cpaul@redhat.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
Please run sparse on your patches, please run sparse before you push.
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 425544b1f733..7f1748a1e614 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3966,7 +3966,7 @@ pipes_modified(struct drm_atomic_state *state)
return ret;
}
-int
+static int
skl_ddb_add_affected_planes(struct intel_crtc_state *cstate)
{
struct drm_atomic_state *state = cstate->base.state;
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✗ Fi.CI.BAT: warning for drm/i915: make skl_ddb_add_affected_planes static
2016-10-04 9:29 [PATCH] drm/i915: make skl_ddb_add_affected_planes static Jani Nikula
@ 2016-10-04 10:19 ` Patchwork
2016-10-04 10:26 ` [PATCH] " Joonas Lahtinen
2016-10-04 13:28 ` Lyude
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-10-04 10:19 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: make skl_ddb_add_affected_planes static
URL : https://patchwork.freedesktop.org/series/13267/
State : warning
== Summary ==
Series 13267v1 drm/i915: make skl_ddb_add_affected_planes static
https://patchwork.freedesktop.org/api/1.0/series/13267/revisions/1/mbox/
Test kms_cursor_legacy:
Subgroup basic-flip-before-cursor-legacy:
pass -> DMESG-WARN (fi-skl-6700k)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-snb-2520m)
Test pm_rpm:
Subgroup basic-pci-d3-state:
pass -> DMESG-WARN (fi-skl-6700k)
Subgroup basic-rte:
pass -> DMESG-WARN (fi-skl-6700k)
fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15
fi-bsw-n3050 total:244 pass:202 dwarn:0 dfail:0 fail:0 skip:42
fi-bxt-t5700 total:244 pass:214 dwarn:0 dfail:0 fail:0 skip:30
fi-byt-j1900 total:244 pass:210 dwarn:2 dfail:0 fail:1 skip:31
fi-byt-n2820 total:244 pass:208 dwarn:0 dfail:0 fail:1 skip:35
fi-hsw-4770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-hsw-4770r total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-ilk-650 total:244 pass:182 dwarn:0 dfail:0 fail:2 skip:60
fi-ivb-3520m total:244 pass:219 dwarn:0 dfail:0 fail:0 skip:25
fi-ivb-3770 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37
fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
fi-skl-6700hq total:244 pass:221 dwarn:1 dfail:0 fail:0 skip:22
fi-skl-6700k total:244 pass:216 dwarn:4 dfail:0 fail:0 skip:24
fi-skl-6770hq total:244 pass:228 dwarn:1 dfail:0 fail:1 skip:14
fi-snb-2520m total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36
fi-snb-2600 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2619/
51bf114bf6c0ac7de7b8e6fbbdc3cb4a2f7dc75f drm-intel-nightly: 2016y-10m-04d-09h-20m-32s UTC integration manifest
39061ec drm/i915: make skl_ddb_add_affected_planes static
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: make skl_ddb_add_affected_planes static
2016-10-04 9:29 [PATCH] drm/i915: make skl_ddb_add_affected_planes static Jani Nikula
2016-10-04 10:19 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2016-10-04 10:26 ` Joonas Lahtinen
2016-10-04 10:53 ` Jani Nikula
2016-10-04 13:28 ` Lyude
2 siblings, 1 reply; 5+ messages in thread
From: Joonas Lahtinen @ 2016-10-04 10:26 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Paulo Zanoni
On ti, 2016-10-04 at 12:29 +0300, Jani Nikula wrote:
> Fix sparse warning:
>
> drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol
> 'skl_ddb_add_affected_planes' was not declared. Should it be static?
>
> Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually affected by ddb changes")
> Cc: Lyude <cpaul@redhat.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: make skl_ddb_add_affected_planes static
2016-10-04 10:26 ` [PATCH] " Joonas Lahtinen
@ 2016-10-04 10:53 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2016-10-04 10:53 UTC (permalink / raw)
To: Joonas Lahtinen, intel-gfx; +Cc: Paulo Zanoni
On Tue, 04 Oct 2016, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> On ti, 2016-10-04 at 12:29 +0300, Jani Nikula wrote:
>> Fix sparse warning:
>>
>> drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol
>> 'skl_ddb_add_affected_planes' was not declared. Should it be static?
>>
>> Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually affected by ddb changes")
>> Cc: Lyude <cpaul@redhat.com>
>> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Thanks, pushed to dinq.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: make skl_ddb_add_affected_planes static
2016-10-04 9:29 [PATCH] drm/i915: make skl_ddb_add_affected_planes static Jani Nikula
2016-10-04 10:19 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-10-04 10:26 ` [PATCH] " Joonas Lahtinen
@ 2016-10-04 13:28 ` Lyude
2 siblings, 0 replies; 5+ messages in thread
From: Lyude @ 2016-10-04 13:28 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Paulo Zanoni
Reviewed-by: Lyude <cpaul@redhat.com>
On Tue, 2016-10-04 at 12:29 +0300, Jani Nikula wrote:
> Fix sparse warning:
>
> drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol
> 'skl_ddb_add_affected_planes' was not declared. Should it be static?
>
> Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually
> affected by ddb changes")
> Cc: Lyude <cpaul@redhat.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ---
>
> Please run sparse on your patches, please run sparse before you push.
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c
> b/drivers/gpu/drm/i915/intel_pm.c
> index 425544b1f733..7f1748a1e614 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3966,7 +3966,7 @@ pipes_modified(struct drm_atomic_state *state)
> return ret;
> }
>
> -int
> +static int
> skl_ddb_add_affected_planes(struct intel_crtc_state *cstate)
> {
> struct drm_atomic_state *state = cstate->base.state;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-10-04 13:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-04 9:29 [PATCH] drm/i915: make skl_ddb_add_affected_planes static Jani Nikula
2016-10-04 10:19 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-10-04 10:26 ` [PATCH] " Joonas Lahtinen
2016-10-04 10:53 ` Jani Nikula
2016-10-04 13:28 ` Lyude
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox