From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH 08/33] drm/i915: Move setting of
	request->batch	into its single callsite
Date: Tue, 09 Aug 2016 18:53:16 +0300
Message-ID: <87invandlf.fsf@gaia.fi.intel.com>
References: <1470581141-14432-1-git-send-email-chris@chris-wilson.co.uk>
 <1470581141-14432-9-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTP id 40C9C6E074
 for <intel-gfx@lists.freedesktop.org>; Tue,  9 Aug 2016 15:53:54 +0000 (UTC)
In-Reply-To: <1470581141-14432-9-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gcmVxdWVz
dC0+YmF0Y2hfb2JqIGlzIG9ubHkgc2V0IGJ5IGV4ZWNidWZmZXIgZm9yIHRoZSBjb252ZW5pZW5j
ZSBvZgo+IGRlYnVnZ2luZyBoYW5ncy4gQnkgbW92aW5nIHRoYXQgb3BlcmF0aW9uIHRvIHRoZSBj
YWxsc2l0ZSwgd2UgY2FuCj4gc2ltcGxpZnkgYWxsIG90aGVyIGNhbGxlcnMgYW5kIGZ1dHVyZSBw
YXRjaGVzLiBXZSBhbHNvIG1vdmUgdGhlCj4gY29tcGxpY2F0aW9ucyBvZiByZWZlcmVuY2UgaGFu
ZGxpbmcgb2YgdGhlIHJlcXVlc3QtPmJhdGNoX29iaiBuZXh0IHRvCj4gd2hlcmUgdGhlIGFjdGl2
ZSB0cmFja2luZyBpcyBzZXQgdXAgZm9yIHRoZSByZXF1ZXN0Lgo+Cj4gU2lnbmVkLW9mZi1ieTog
Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gIGRyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyB8IDEwICsrKysrKysrKy0KPiAgZHJp
dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jICAgIHwgMTIgKy0tLS0tLS0tLS0t
Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuaCAgICB8ICA4ICsrKy0t
LS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0p
Cj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZl
ci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gaW5kZXgg
YzQ5NGI3OWRlZDIwLi5jOGQxM2ZlYTRiMjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4gQEAgLTE3MDIsNiArMTcwMiwxNCBAQCBpOTE1X2dlbV9k
b19leGVjYnVmZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAkJZ290
byBlcnJfYmF0Y2hfdW5waW47Cj4gIAl9Cj4gIAo+ICsJLyogV2hpbHN0IHRoaXMgcmVxdWVzdCBl
eGlzdHMsIGJhdGNoX29iaiB3aWxsIGJlIG9uIHRoZQo+ICsJICogYWN0aXZlX2xpc3QsIGFuZCBz
byB3aWxsIGhvbGQgdGhlIGFjdGl2ZSByZWZlcmVuY2UuIE9ubHkgd2hlbiB0aGlzCj4gKwkgKiBy
ZXF1ZXN0IGlzIHJldGlyZWQgd2lsbCB0aGUgdGhlIGJhdGNoX29iaiBiZSBtb3ZlZCBvbnRvIHRo
ZQo+ICsJICogaW5hY3RpdmVfbGlzdCBhbmQgbG9zZSBpdHMgYWN0aXZlIHJlZmVyZW5jZS4gSGVu
Y2Ugd2UgZG8gbm90IG5lZWQKPiArCSAqIHRvIGV4cGxpY2l0bHkgaG9sZCBhbm90aGVyIHJlZmVy
ZW5jZSBoZXJlLgo+ICsJICovCgpUaGUgY29tbWVudCBoZXJlIG1pZ2h0IG9yIG1pZ2h0IG5vdCBu
ZWVkIHJldmlzaXRpbmcuIEkgY2FuJ3Qgc2F5IHlldC4KCkJ1dCB3aGVuIEkgdHJpZWQgdG8gbGVh
cm4gaG93IHRoZSBjdXJyZW50IGNvZGUgd29ya3MsIEkgZm91bmQKdGhhdCB0aGVyZSBhcmUgY29t
bWVudHMgcmVmZXJlbmNpbmcgX19pOTE1X2dlbV9hY3RpdmVfZ2V0X3JlcXVlc3RfcmN1KCkKd2hp
Y2ggZG9lcyBub3QgZXhpc3QuCgotTWlrYQoKPiArCXBhcmFtcy0+cmVxdWVzdC0+YmF0Y2hfb2Jq
ID0gcGFyYW1zLT5iYXRjaC0+b2JqOwo+ICsKPiAgCXJldCA9IGk5MTVfZ2VtX3JlcXVlc3RfYWRk
X3RvX2NsaWVudChwYXJhbXMtPnJlcXVlc3QsIGZpbGUpOwo+ICAJaWYgKHJldCkKPiAgCQlnb3Rv
IGVycl9yZXF1ZXN0Owo+IEBAIC0xNzIwLDcgKzE3MjgsNyBAQCBpOTE1X2dlbV9kb19leGVjYnVm
ZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAo+ICAJcmV0ID0gZXhl
Y2J1Zl9zdWJtaXQocGFyYW1zLCBhcmdzLCAmZWItPnZtYXMpOwo+ICBlcnJfcmVxdWVzdDoKPiAt
CV9faTkxNV9hZGRfcmVxdWVzdChwYXJhbXMtPnJlcXVlc3QsIHBhcmFtcy0+YmF0Y2gtPm9iaiwg
cmV0ID09IDApOwo+ICsJX19pOTE1X2FkZF9yZXF1ZXN0KHBhcmFtcy0+cmVxdWVzdCwgcmV0ID09
IDApOwo+ICAKPiAgZXJyX2JhdGNoX3VucGluOgo+ICAJLyoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aTkxNV9nZW1fcmVxdWVzdC5jCj4gaW5kZXggYjdmZmRlMDAyYTYyLi5jNmY1MjNlMjg3OWMgMTAw
NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jCj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fcmVxdWVzdC5jCj4gQEAgLTQ2MSw5ICs0
NjEsNyBAQCBzdGF0aWMgdm9pZCBpOTE1X2dlbV9tYXJrX2J1c3koY29uc3Qgc3RydWN0IGludGVs
X2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgKiByZXF1ZXN0IGlzIG5vdCBiZWluZyB0cmFja2VkIGZv
ciBjb21wbGV0aW9uIGJ1dCB0aGUgd29yayBpdHNlbGYgaXMKPiAgICogZ29pbmcgdG8gaGFwcGVu
IG9uIHRoZSBoYXJkd2FyZS4gVGhpcyB3b3VsZCBiZSBhIEJhZCBUaGluZyh0bSkuCj4gICAqLwo+
IC12b2lkIF9faTkxNV9hZGRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJl
cXVlc3QsCj4gLQkJCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gLQkJCWJvb2wg
Zmx1c2hfY2FjaGVzKQo+ICt2b2lkIF9faTkxNV9hZGRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVf
Z2VtX3JlcXVlc3QgKnJlcXVlc3QsIGJvb2wgZmx1c2hfY2FjaGVzKQo+ICB7Cj4gIAlzdHJ1Y3Qg
aW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4gIAlzdHJ1Y3QgaW50ZWxfcmluZyAqcmluZzsKPiBA
QCAtNTA0LDE0ICs1MDIsNiBAQCB2b2lkIF9faTkxNV9hZGRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5
MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QsCj4gIAo+ICAJcmVxdWVzdC0+aGVhZCA9IHJlcXVlc3Rf
c3RhcnQ7Cj4gIAo+IC0JLyogV2hpbHN0IHRoaXMgcmVxdWVzdCBleGlzdHMsIGJhdGNoX29iaiB3
aWxsIGJlIG9uIHRoZQo+IC0JICogYWN0aXZlX2xpc3QsIGFuZCBzbyB3aWxsIGhvbGQgdGhlIGFj
dGl2ZSByZWZlcmVuY2UuIE9ubHkgd2hlbiB0aGlzCj4gLQkgKiByZXF1ZXN0IGlzIHJldGlyZWQg
d2lsbCB0aGUgdGhlIGJhdGNoX29iaiBiZSBtb3ZlZCBvbnRvIHRoZQo+IC0JICogaW5hY3RpdmVf
bGlzdCBhbmQgbG9zZSBpdHMgYWN0aXZlIHJlZmVyZW5jZS4gSGVuY2Ugd2UgZG8gbm90IG5lZWQK
PiAtCSAqIHRvIGV4cGxpY2l0bHkgaG9sZCBhbm90aGVyIHJlZmVyZW5jZSBoZXJlLgo+IC0JICov
Cj4gLQlyZXF1ZXN0LT5iYXRjaF9vYmogPSBvYmo7Cj4gLQo+ICAJLyogU2VhbCB0aGUgcmVxdWVz
dCBhbmQgbWFyayBpdCBhcyBwZW5kaW5nIGV4ZWN1dGlvbi4gTm90ZSB0aGF0Cj4gIAkgKiB3ZSBt
YXkgaW5zcGVjdCB0aGlzIHN0YXRlLCB3aXRob3V0IGhvbGRpbmcgYW55IGxvY2tzLCBkdXJpbmcK
PiAgCSAqIGhhbmdjaGVjay4gSGVuY2Ugd2UgYXBwbHkgdGhlIGJhcnJpZXIgdG8gZW5zdXJlIHRo
YXQgd2UgZG8gbm90Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt
X3JlcXVlc3QuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuaAo+IGlu
ZGV4IDcyMWViOGNiY2U5Yi4uZDUxNzZmOWNjMjJmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfZ2VtX3JlcXVlc3QuaAo+IEBAIC0yMjUsMTMgKzIyNSwxMSBAQCBzdGF0aWMgaW5saW5l
IHZvaWQgaTkxNV9nZW1fcmVxdWVzdF9hc3NpZ24oc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0
ICoqcGRzdCwKPiAgCSpwZHN0ID0gc3JjOwo+ICB9Cj4gIAo+IC12b2lkIF9faTkxNV9hZGRfcmVx
dWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiAtCQkJc3RydWN0IGRybV9p
OTE1X2dlbV9vYmplY3QgKmJhdGNoX29iaiwKPiAtCQkJYm9vbCBmbHVzaF9jYWNoZXMpOwo+ICt2
b2lkIF9faTkxNV9hZGRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwg
Ym9vbCBmbHVzaF9jYWNoZXMpOwo+ICAjZGVmaW5lIGk5MTVfYWRkX3JlcXVlc3QocmVxKSBcCj4g
LQlfX2k5MTVfYWRkX3JlcXVlc3QocmVxLCBOVUxMLCB0cnVlKQo+ICsJX19pOTE1X2FkZF9yZXF1
ZXN0KHJlcSwgdHJ1ZSkKPiAgI2RlZmluZSBpOTE1X2FkZF9yZXF1ZXN0X25vX2ZsdXNoKHJlcSkg
XAo+IC0JX19pOTE1X2FkZF9yZXF1ZXN0KHJlcSwgTlVMTCwgZmFsc2UpCj4gKwlfX2k5MTVfYWRk
X3JlcXVlc3QocmVxLCBmYWxzZSkKPiAgCj4gIHN0cnVjdCBpbnRlbF9ycHNfY2xpZW50Owo+ICAj
ZGVmaW5lIE5PX1dBSVRCT09TVCBFUlJfUFRSKC0xKQo+IC0tIAo+IDIuOC4xCj4KPiBfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWls
aW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz
dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0
b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==