From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH] drm/i915: Use bitmask for IS_REVID checking
Date: Wed, 11 May 2016 14:58:32 +0300
Message-ID: <87inykiz6f.fsf@intel.com>
References: <1462885341-30380-1-git-send-email-tvrtko.ursulin@linux.intel.com>
 <87shxq6nru.fsf@intel.com> <5731E925.9010007@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id EA7286E694
 for <Intel-gfx@lists.freedesktop.org>; Wed, 11 May 2016 11:58:34 +0000 (UTC)
In-Reply-To: <5731E925.9010007@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, Intel-gfx@lists.freedesktop.org
Cc: "Syrjala, Ville" <ville.syrjala@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCAxMCBNYXkgMjAxNiwgVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4
LmludGVsLmNvbT4gd3JvdGU6Cj4gSGksCj4KPiBPbiAxMC8wNS8xNiAxNDozMywgSmFuaSBOaWt1
bGEgd3JvdGU6Cj4+IE9uIFR1ZSwgMTAgTWF5IDIwMTYsIFR2cnRrbyBVcnN1bGluIDx0dnJ0a28u
dXJzdWxpbkBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+Pj4gRnJvbTogVHZydGtvIFVyc3VsaW4g
PHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4+Cj4+PiBXaXRoIHRoaXMgc2NoZW1lIGFsbCBj
YWxsIHNpdGVzIG9mIElTX1NLTF9SRVZJRCBhbmQgSVNfQlhUX1JFVklECj4+PiByZXN1bHQgaW4g
YSBtYXhpbXVtIG9mIG9uZSBjb25kaXRpb25hbCBqdW1wIGluc3RydWN0aW9uICh3YXMKPj4+IHRo
cmVlIGJlZm9yZSkgYW5kIG92ZXJhbGwgcmVkdWN0aW9uIGluIGNvZGUgc2l6ZS4KPj4KPj4gSU1P
IHdlIHJlYWxseSBzaG91bGRuJ3QgYm90aGVyIHdpdGggdGhpcy4gVGhlIGVuZCBnb2FsIGlzIHRo
YXQgd2UgcmVtb3ZlCj4+IGFsbCBvZiB0aGVzZSB3aGVuIHdlIGRlY2lkZSB3ZSBubyBsb25nZXIg
Y2FyZSBhYm91dCBlYXJseQo+PiAobm9uLXByb2R1Y3Rpb24pIHJldmlzaW9ucyBmb3IgYSBwbGF0
Zm9ybS4gRm9yIFNreWxha2UgSSdkIGFyZ3VlIHdlIGFyZQo+PiBiZXlvbmQgdGhpcyBwb2ludC4K
Pgo+IFRob3VnaHQgdGhhdCBzaW1wbHkgcmVtb3ZpbmcgZXZlcnl0aGluZyBndWFyZGVkIGJ5IElT
X1NLTF9SRVZJRCBtaWdodCBiZSAKPiBwb3NzaWJsZSBuZXZlciBjcm9zc2VkIG15IG1pbmQuIDop
IFdoaWNoIG9uZSBpcyB0aGUgZmlyc3QgcHJvZHVjdGlvbiAKPiBzdGVwcGluZyB0aGVuPwoKTm9u
ZSBvZiB0aGUgb25lcyB3ZSBsaXN0IGFuZCBjaGVjayBmb3IgaS5lLiB3ZSBzaG91bGQgcmVwbGFj
ZSBhbGwgb2YgdGhlCklTX1NLTF9SRVZJRCgpIHVzZXMgd2l0aCBlaXRoZXIgMCBvciBJU19TS1lM
QUtFKCksIGFuZCBzaW1wbGlmeSBmcm9tCnRoZXJlLgoKTWF5YmUgd2Ugc2hvdWxkIGNoZWNrIHRo
ZSByZXZpZCBvbmNlIG9uIGRyaXZlciBsb2FkLCBhbmQgd2hpbmUgYWJvdXQKZWFybHkgaGFyZHdh
cmUuIFdlJ3ZlIGhhZCBzdWNoIGNoZWNrcyBpbiB0aGUgcGFzdCBvbiBlYXJsaWVyCnBsYXRmb3Jt
cy4gVGhpcyBtaWdodCBzYXZlIG91ciBwcmVjaW91cyB0aW1lLCBhcyB3ZSBzaG91bGRuJ3QgYmUK
ZGVidWdnaW5nIGlzc3VlcyByZXBvcnRlZCBhZ2FpbnN0IHByZS1wcm9kdWN0aW9uIGhhcmR3YXJl
LgoKVmlsbGUgaGVyZSBzYXlzIGRyb3BwaW5nIHRoZSBjaGVja3MgaXMgYSBnb29kIHRpbWUgdG8g
dmVyaWZ5IHRoZQp3b3JrYXJvdW5kcyB3ZSBkbyBoYXZlIGluIHBsYWNlIGFyZSBjb3JyZWN0IGdv
aW5nIGZvcndhcmQuCgoKQlIsCkphbmkuCgoKCj4KPiBSZWdhcmRzLAo+Cj4gVHZydGtvLgo+Cj4+
Pgo+Pj4gU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVs
LmNvbT4KPj4+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4+
IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+Pj4gLS0tCj4+PiAgIGRy
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMgfCAxMSArKysrKysrKysrKwo+Pj4gICBkcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIHwgMjQgKysrKysrKysrKysrKysrKysrKy0tLS0t
Cj4+PiAgIDIgZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkK
Pj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZG1hLmMKPj4+IGluZGV4IDQ2YWMxZGE2NGEwOS4uMWFl
ODEyNDM2ODI3IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEu
Ywo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYwo+Pj4gQEAgLTEwNzIs
NiArMTA3MiwxNyBAQCBzdGF0aWMgaW50IGk5MTVfZHJpdmVyX2luaXRfZWFybHkoc3RydWN0IGRy
bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+Pj4gICAJbWVtY3B5KGRldmljZV9pbmZvLCBpbmZv
LCBzaXplb2YoZGV2X3ByaXYtPmluZm8pKTsKPj4+ICAgCWRldmljZV9pbmZvLT5kZXZpY2VfaWQg
PSBkZXYtPnBkZXYtPmRldmljZTsKPj4+Cj4+PiArCS8qIEZvciB1bmtub3duIHJldmlzaW9ucyBt
YXNrIHN0YXlzIGF0IHplcm8gd2hpY2ggaXMgY29ycmVjdC4gKi8KPj4+ICsJaWYgKGRldi0+cGRl
di0+cmV2aXNpb24gPAo+Pj4gKwkgICAgc2l6ZW9mKGRldmljZV9pbmZvLT5yZXZpc2lvbl9tYXNr
KSAqIEJJVFNfUEVSX0JZVEUpCj4+PiArCQlkZXZpY2VfaW5mby0+cmV2aXNpb25fbWFzayA9IEJJ
VChkZXYtPnBkZXYtPnJldmlzaW9uKTsKPj4+ICsKPj4+ICsJaWYgKElTX1NLWUxBS0UoZGV2X3By
aXYpKQo+Pj4gKwkJZGV2aWNlX2luZm8tPnNrbF9yZXZfbWFzayA9IH4wOwo+Pj4gKwo+Pj4gKwlp
ZiAoSVNfQlJPWFRPTihkZXZfcHJpdikpCj4+PiArCQlkZXZpY2VfaW5mby0+Ynh0X3Jldl9tYXNr
ID0gfjA7Cj4+PiArCj4+PiAgIAlzcGluX2xvY2tfaW5pdCgmZGV2X3ByaXYtPmlycV9sb2NrKTsK
Pj4+ICAgCXNwaW5fbG9ja19pbml0KCZkZXZfcHJpdi0+Z3B1X2Vycm9yLmxvY2spOwo+Pj4gICAJ
bXV0ZXhfaW5pdCgmZGV2X3ByaXYtPmJhY2tsaWdodF9sb2NrKTsKPj4+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx
NV9kcnYuaAo+Pj4gaW5kZXggMjZlN2RlNDE1OTY2Li5mYmViNjhlOWVjOTYgMTAwNjQ0Cj4+PiAt
LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+PiArKysgYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+PiBAQCAtNzU3LDYgKzc1Nyw5IEBAIHN0cnVjdCBpbnRl
bF9jc3Igewo+Pj4gICBzdHJ1Y3QgaW50ZWxfZGV2aWNlX2luZm8gewo+Pj4gICAJdTMyIGRpc3Bs
YXlfbW1pb19vZmZzZXQ7Cj4+PiAgIAl1MTYgZGV2aWNlX2lkOwo+Pj4gKwl1OCByZXZpc2lvbl9t
YXNrOwo+Pj4gKwl1OCBza2xfcmV2X21hc2s7Cj4+PiArCXU4IGJ4dF9yZXZfbWFzazsKPj4+ICAg
CXU4IG51bV9waXBlczozOwo+Pj4gICAJdTggbnVtX3Nwcml0ZXNbSTkxNV9NQVhfUElQRVNdOwo+
Pj4gICAJdTggZ2VuOwo+Pj4gQEAgLTI1MTksMTQgKzI1MjIsMjMgQEAgc3RydWN0IGRybV9pOTE1
X2NtZF90YWJsZSB7Cj4+PiAgICNkZWZpbmUgSU5URUxfREVWSUQocCkJKElOVEVMX0lORk8ocCkt
PmRldmljZV9pZCkKPj4+ICAgI2RlZmluZSBJTlRFTF9SRVZJRChwKQkoX19JOTE1X18ocCktPmRl
di0+cGRldi0+cmV2aXNpb24pCj4+Pgo+Pj4gLSNkZWZpbmUgUkVWSURfRk9SRVZFUgkJMHhmZgo+
Pj4gKyNkZWZpbmUgUkVWSURfRk9SRVZFUgkJMAo+Pj4gKwo+Pj4gICAvKgo+Pj4gICAgKiBSZXR1
cm4gdHJ1ZSBpZiByZXZpc2lvbiBpcyBpbiByYW5nZSBbc2luY2UsdW50aWxdIGluY2x1c2l2ZS4K
Pj4+ICAgICoKPj4+ICAgICogVXNlIDAgZm9yIG9wZW4tZW5kZWQgc2luY2UsIGFuZCBSRVZJRF9G
T1JFVkVSIGZvciBvcGVuLWVuZGVkIHVudGlsLgo+Pj4gICAgKi8KPj4+IC0jZGVmaW5lIElTX1JF
VklEKHAsIHNpbmNlLCB1bnRpbCkgXAo+Pj4gLQkoSU5URUxfUkVWSUQocCkgPj0gKHNpbmNlKSAm
JiBJTlRFTF9SRVZJRChwKSA8PSAodW50aWwpKQo+Pj4gKyNkZWZpbmUgSVNfUkVWSUQocCwgbWFz
aywgc2luY2UsIHVudGlsKSAoe1wKPj4+ICsJdW5zaWduZWQgaW50IF9fcyA9IChzaW5jZSksIF9f
ZSA9ICh1bnRpbCk7IFwKPj4+ICsJQlVJTERfQlVHX09OKCFfX2J1aWx0aW5fY29uc3RhbnRfcChz
aW5jZSkpOyBcCj4+PiArCUJVSUxEX0JVR19PTighX19idWlsdGluX2NvbnN0YW50X3AodW50aWwp
KTsgXAo+Pj4gKwlCVUlMRF9CVUdfT04oc2luY2UgPj0gc2l6ZW9mKElOVEVMX0lORk8ocCktPnJl
dmlzaW9uX21hc2spICogQklUU19QRVJfQllURSk7IFwKPj4+ICsJQlVJTERfQlVHX09OKHVudGls
ID49IHNpemVvZihJTlRFTF9JTkZPKHApLT5yZXZpc2lvbl9tYXNrKSAqIEJJVFNfUEVSX0JZVEUp
OyBcCj4+PiArCWlmICgoX19lKSA9PSBSRVZJRF9GT1JFVkVSKSBcCj4+PiArCQlfX2UgPSBCSVRT
X1BFUl9MT05HIC0gMTsgXAo+Pj4gKwkhIShJTlRFTF9JTkZPKHApLT5yZXZpc2lvbl9tYXNrICYg
KG1hc2spICYgR0VOTUFTSygoX19lKSwgKF9fcykpKTsgXAo+Pj4gK30pCj4+Pgo+Pj4gICAjZGVm
aW5lIElTX0k4MzAoZGV2KQkJKElOVEVMX0RFVklEKGRldikgPT0gMHgzNTc3KQo+Pj4gICAjZGVm
aW5lIElTXzg0NUcoZGV2KQkJKElOVEVMX0RFVklEKGRldikgPT0gMHgyNTYyKQo+Pj4gQEAgLTI2
MDUsMTQgKzI2MTcsMTYgQEAgc3RydWN0IGRybV9pOTE1X2NtZF90YWJsZSB7Cj4+PiAgICNkZWZp
bmUgU0tMX1JFVklEX0UwCQkweDQKPj4+ICAgI2RlZmluZSBTS0xfUkVWSURfRjAJCTB4NQo+Pj4K
Pj4+IC0jZGVmaW5lIElTX1NLTF9SRVZJRChwLCBzaW5jZSwgdW50aWwpIChJU19TS1lMQUtFKHAp
ICYmIElTX1JFVklEKHAsIHNpbmNlLCB1bnRpbCkpCj4+PiArI2RlZmluZSBJU19TS0xfUkVWSUQo
cCwgc2luY2UsIHVudGlsKSBJU19SRVZJRChwLCBJTlRFTF9JTkZPKHApLT5za2xfcmV2X21hc2ss
IFwKPj4+ICsJCQkJICAgICAgICAgICAgICAgc2luY2UsIHVudGlsKQo+Pj4KPj4+ICAgI2RlZmlu
ZSBCWFRfUkVWSURfQTAJCTB4MAo+Pj4gICAjZGVmaW5lIEJYVF9SRVZJRF9BMQkJMHgxCj4+PiAg
ICNkZWZpbmUgQlhUX1JFVklEX0IwCQkweDMKPj4+ICAgI2RlZmluZSBCWFRfUkVWSURfQzAJCTB4
OQo+Pj4KPj4+IC0jZGVmaW5lIElTX0JYVF9SRVZJRChwLCBzaW5jZSwgdW50aWwpIChJU19CUk9Y
VE9OKHApICYmIElTX1JFVklEKHAsIHNpbmNlLCB1bnRpbCkpCj4+PiArI2RlZmluZSBJU19CWFRf
UkVWSUQocCwgc2luY2UsIHVudGlsKSBJU19SRVZJRChwLCBJTlRFTF9JTkZPKHApLT5ieHRfcmV2
X21hc2ssIFwKPj4+ICsJCQkJICAgICAgICAgICAgICAgc2luY2UsIHVudGlsKQo+Pj4KPj4+ICAg
LyoKPj4+ICAgICogVGhlIGdlblggZGVzaWduYXRpb24gdHlwaWNhbGx5IHJlZmVycyB0byB0aGUg
cmVuZGVyIGVuZ2luZSwgc28gcmVuZGVyCj4+CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4g
U291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy
ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp
bmZvL2ludGVsLWdmeAo=