From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2 8/9] drm/i915: Apply a mb between emitting the request and hangcheck Date: Wed, 06 Apr 2016 17:24:07 +0300 Message-ID: <87inzuq0hk.fsf@gaia.fi.intel.com> References: <1459900669-31740-1-git-send-email-chris@chris-wilson.co.uk> <1459946003-24543-1-git-send-email-chris@chris-wilson.co.uk> <1459946003-24543-8-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 3FCB46E196 for ; Wed, 6 Apr 2016 14:26:18 +0000 (UTC) In-Reply-To: <1459946003-24543-8-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gWyB0ZXh0 L3BsYWluIF0KPiBTZWFsIHRoZSByZXF1ZXN0IGFuZCBtYXJrIGl0IGFzIHBlbmRpbmcgZXhlY3V0 aW9uIGJlZm9yZSB3ZSBzdWJtaXQgaXQgdG8KPiBoYXJkd2FyZS4gV2UgYXNzdW1lIHRoYXQgdGhl IGFjdHVhbCBzdWJtaXNzaW9uIGNhbm5vdCBmYWlsICh0aGF0Cj4gZ3VhcmFudGVlIGlzIHByb3Zp ZGVkIGJ5IHByZWFsbG9jYXRpbmcgc3BhY2UgaW4gdGhlIHJlcXVlc3QgZm9yIHRoZQo+IHN1Ym1p c3Npb24pLiBBcyB3ZSBtYXkgaW5zcGVjdCB0aGlzIHN0YXRlIHdpdGhvdXQgaG9sZGluZyBhbnkg bG9ja3MKPiBkdXJpbmcgaGFuZ2NoZWNrIHdlIHNob3VsZCBhcHBseSBhIGJhcnJpZXIgdG8gZW5z dXJlIHRoYXQgd2UgZG8KPiBub3Qgc2VlIGEgbW9yZSByZWNlbnQgdmFsdWUgaW4gdGhlIEhXUyB0 aGFuIHdlIGFyZSB0cmFja2luZy4KPgo+IEJhc2VkIG9uIGEgcGF0Y2ggYnkgTWlrYSBLdW9wcGFs YS4KPgo+IFN1Z2dlc3RlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5p bnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwu Y29tPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5j b20+CgpSZXZpZXdlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAzOSArKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9pcnEuYyB8ICAzICsrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDE4 IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggNzUwNmU4NTA5 MTNlLi41YTY1YTc2NjNiODggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBAQCAtMjU3 NSw2ICsyNTc1LDI4IEBAIHZvaWQgX19pOTE1X2FkZF9yZXF1ZXN0KHN0cnVjdCBkcm1faTkxNV9n ZW1fcmVxdWVzdCAqcmVxdWVzdCwKPiAgCQlXQVJOKHJldCwgIipfcmluZ19mbHVzaF9hbGxfY2Fj aGVzIGZhaWxlZDogJWQhXG4iLCByZXQpOwo+ICAJfQo+ICAKPiArCXRyYWNlX2k5MTVfZ2VtX3Jl cXVlc3RfYWRkKHJlcXVlc3QpOwo+ICsKPiArCXJlcXVlc3QtPmhlYWQgPSByZXF1ZXN0X3N0YXJ0 Owo+ICsKPiArCS8qIFdoaWxzdCB0aGlzIHJlcXVlc3QgZXhpc3RzLCBiYXRjaF9vYmogd2lsbCBi ZSBvbiB0aGUKPiArCSAqIGFjdGl2ZV9saXN0LCBhbmQgc28gd2lsbCBob2xkIHRoZSBhY3RpdmUg cmVmZXJlbmNlLiBPbmx5IHdoZW4gdGhpcwo+ICsJICogcmVxdWVzdCBpcyByZXRpcmVkIHdpbGwg dGhlIHRoZSBiYXRjaF9vYmogYmUgbW92ZWQgb250byB0aGUKPiArCSAqIGluYWN0aXZlX2xpc3Qg YW5kIGxvc2UgaXRzIGFjdGl2ZSByZWZlcmVuY2UuIEhlbmNlIHdlIGRvIG5vdCBuZWVkCj4gKwkg KiB0byBleHBsaWNpdGx5IGhvbGQgYW5vdGhlciByZWZlcmVuY2UgaGVyZS4KPiArCSAqLwo+ICsJ cmVxdWVzdC0+YmF0Y2hfb2JqID0gb2JqOwo+ICsKPiArCS8qIFNlYWwgdGhlIHJlcXVlc3QgYW5k IG1hcmsgaXQgYXMgcGVuZGluZyBleGVjdXRpb24uIE5vdGUgdGhhdAo+ICsJICogd2UgbWF5IGlu c3BlY3QgdGhpcyBzdGF0ZSwgd2l0aG91dCBob2xkaW5nIGFueSBsb2NrcywgZHVyaW5nCj4gKwkg KiBoYW5nY2hlY2suIEhlbmNlIHdlIGFwcGx5IHRoZSBiYXJyaWVyIHRvIGVuc3VyZSB0aGF0IHdl IGRvIG5vdAo+ICsJICogc2VlIGEgbW9yZSByZWNlbnQgdmFsdWUgaW4gdGhlIGh3cyB0aGFuIHdl IGFyZSB0cmFja2luZy4KPiArCSAqLwo+ICsJcmVxdWVzdC0+ZW1pdHRlZF9qaWZmaWVzID0gamlm ZmllczsKPiArCXJlcXVlc3QtPnByZXZpb3VzX3NlcW5vID0gZW5naW5lLT5sYXN0X3N1Ym1pdHRl ZF9zZXFubzsKPiArCXNtcF9zdG9yZV9tYihlbmdpbmUtPmxhc3Rfc3VibWl0dGVkX3NlcW5vLCBy ZXF1ZXN0LT5zZXFubyk7Cj4gKwlsaXN0X2FkZF90YWlsKCZyZXF1ZXN0LT5saXN0LCAmZW5naW5l LT5yZXF1ZXN0X2xpc3QpOwo+ICsKPiAgCS8qIFJlY29yZCB0aGUgcG9zaXRpb24gb2YgdGhlIHN0 YXJ0IG9mIHRoZSByZXF1ZXN0IHNvIHRoYXQKPiAgCSAqIHNob3VsZCB3ZSBkZXRlY3QgdGhlIHVw ZGF0ZWQgc2Vxbm8gcGFydC13YXkgdGhyb3VnaCB0aGUKPiAgCSAqIEdQVSBwcm9jZXNzaW5nIHRo ZSByZXF1ZXN0LCB3ZSBuZXZlciBvdmVyLWVzdGltYXRlIHRoZQo+IEBAIC0yNTkyLDIzICsyNjE0 LDYgQEAgdm9pZCBfX2k5MTVfYWRkX3JlcXVlc3Qoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0 ICpyZXF1ZXN0LAo+ICAJLyogTm90IGFsbG93ZWQgdG8gZmFpbCEgKi8KPiAgCVdBUk4ocmV0LCAi ZW1pdHxhZGRfcmVxdWVzdCBmYWlsZWQ6ICVkIVxuIiwgcmV0KTsKPiAgCj4gLQlyZXF1ZXN0LT5o ZWFkID0gcmVxdWVzdF9zdGFydDsKPiAtCj4gLQkvKiBXaGlsc3QgdGhpcyByZXF1ZXN0IGV4aXN0 cywgYmF0Y2hfb2JqIHdpbGwgYmUgb24gdGhlCj4gLQkgKiBhY3RpdmVfbGlzdCwgYW5kIHNvIHdp bGwgaG9sZCB0aGUgYWN0aXZlIHJlZmVyZW5jZS4gT25seSB3aGVuIHRoaXMKPiAtCSAqIHJlcXVl c3QgaXMgcmV0aXJlZCB3aWxsIHRoZSB0aGUgYmF0Y2hfb2JqIGJlIG1vdmVkIG9udG8gdGhlCj4g LQkgKiBpbmFjdGl2ZV9saXN0IGFuZCBsb3NlIGl0cyBhY3RpdmUgcmVmZXJlbmNlLiBIZW5jZSB3 ZSBkbyBub3QgbmVlZAo+IC0JICogdG8gZXhwbGljaXRseSBob2xkIGFub3RoZXIgcmVmZXJlbmNl IGhlcmUuCj4gLQkgKi8KPiAtCXJlcXVlc3QtPmJhdGNoX29iaiA9IG9iajsKPiAtCj4gLQlyZXF1 ZXN0LT5lbWl0dGVkX2ppZmZpZXMgPSBqaWZmaWVzOwo+IC0JcmVxdWVzdC0+cHJldmlvdXNfc2Vx bm8gPSBlbmdpbmUtPmxhc3Rfc3VibWl0dGVkX3NlcW5vOwo+IC0JZW5naW5lLT5sYXN0X3N1Ym1p dHRlZF9zZXFubyA9IHJlcXVlc3QtPnNlcW5vOwo+IC0JbGlzdF9hZGRfdGFpbCgmcmVxdWVzdC0+ bGlzdCwgJmVuZ2luZS0+cmVxdWVzdF9saXN0KTsKPiAtCj4gLQl0cmFjZV9pOTE1X2dlbV9yZXF1 ZXN0X2FkZChyZXF1ZXN0KTsKPiAtCj4gIAlpOTE1X3F1ZXVlX2hhbmdjaGVjayhlbmdpbmUtPmRl dik7Cj4gIAo+ICAJcXVldWVfZGVsYXllZF93b3JrKGRldl9wcml2LT53cSwKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfaXJxLmMKPiBpbmRleCA1YmVjMTM4NDQ4MDAuLmE1ZWI3N2QxZjhjYiAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9pcnEuYwo+IEBAIC0yODA2LDcgKzI4MDYsOCBAQCBzdGF0aWMgYm9vbAo+ ICByaW5nX2lkbGUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLCB1MzIgc2Vxbm8pCj4g IHsKPiAgCXJldHVybiAobGlzdF9lbXB0eSgmZW5naW5lLT5yZXF1ZXN0X2xpc3QpIHx8Cj4gLQkJ aTkxNV9zZXFub19wYXNzZWQoc2Vxbm8sIGVuZ2luZS0+bGFzdF9zdWJtaXR0ZWRfc2Vxbm8pKTsK PiArCQlpOTE1X3NlcW5vX3Bhc3NlZChzZXFubywKPiArCQkJCSAgUkVBRF9PTkNFKGVuZ2luZS0+ bGFzdF9zdWJtaXR0ZWRfc2Vxbm8pKSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBib29sCj4gLS0gCj4g Mi44LjAucmMzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=