From: Jani Nikula <jani.nikula@linux.intel.com>
To: Radhakrishna Sripada <radhakrishna.sripada@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Kalyan Kondapally <kalyan.kondapally@intel.com>
Subject: Re: [PATCH] drm/i915/skl: Increase ddb blocks to support large cursor sizes
Date: Fri, 18 Dec 2015 12:01:32 +0200 [thread overview]
Message-ID: <87io3wcbyb.fsf@intel.com> (raw)
In-Reply-To: <1450321580-26269-1-git-send-email-radhakrishna.sripada@intel.com>
On Thu, 17 Dec 2015, Radhakrishna Sripada <radhakrishna.sripada@intel.com> wrote:
> Original value of 32 blocks is not sufficient when using cursor size of
> 256x256 causing FIFO underruns when the reworked wm
> caluclations in
>
> commit 024c9045221fe45482863c47c4b4c47d37f97cbf
> Author: Matt Roper <matthew.d.roper@intel.com>
> Date: Thu Sep 24 15:53:11 2015 -0700
>
> drm/i915/skl: Eliminate usage of pipe_wm_parameters from SKL-style WM (v4)
>
> are used. Increasing the number of blocks to 52 to make cursor plane tolerate
> SAGV block time for the maximum possible cursor size.
>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> Signed-off-by: Kalyan Kondapally <kalyan.kondapally@intel.com>
Cc: drm-intel-fixes@lists.freedesktop.org
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index d385d99..137fb68 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -2802,7 +2802,7 @@ skl_ddb_get_pipe_allocation_limits(struct drm_device *dev,
> static unsigned int skl_cursor_allocation(const struct intel_wm_config *config)
> {
> if (config->num_pipes_active == 1)
> - return 32;
> + return 52;
>
> return 8;
> }
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-18 10:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 3:06 [PATCH] drm/i915/skl: Increase ddb blocks to support large cursor sizes Radhakrishna Sripada
2015-12-18 10:01 ` Jani Nikula [this message]
2015-12-18 10:35 ` Ville Syrjälä
2015-12-18 14:58 ` Matt Roper
2015-12-18 15:10 ` Ville Syrjälä
2015-12-18 15:14 ` Matt Roper
2015-12-18 15:24 ` Matt Roper
2015-12-21 12:09 ` Daniel Vetter
2015-12-23 2:52 ` Kumar, Shobhit
2016-01-04 13:48 ` Kumar, Shobhit
2016-01-05 10:14 ` Daniel Vetter
2016-02-16 10:14 ` Kumar, Shobhit
2016-02-18 8:28 ` Kumar, Shobhit
2015-12-18 15:34 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io3wcbyb.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kalyan.kondapally@intel.com \
--cc=radhakrishna.sripada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).