From: Jani Nikula <jani.nikula@linux.intel.com>
To: Emil Renner Berthing <kernel@esmil.dk>,
Gabriel Feceoru <gabriel.feceoru@intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Consider SPLL as another shared pll, v2.
Date: Wed, 18 Nov 2015 15:16:00 +0200 [thread overview]
Message-ID: <87io4zcusv.fsf@intel.com> (raw)
In-Reply-To: <CANBLGczN8uhTN8sG96xHuf4TU03Fd23EQ4=umTMWJZwA-jTEoQ@mail.gmail.com>
On Wed, 18 Nov 2015, Emil Renner Berthing <kernel@esmil.dk> wrote:
> On 18 November 2015 at 13:31, Gabriel Feceoru <gabriel.feceoru@intel.com> wrote:
>>
>>
>> On 16.11.2015 17:53, Jani Nikula wrote:
>>>
>>> On Mon, 16 Nov 2015, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> wrote:
>>>>
>>>> When diagnosing a unrelated bug for someone on irc, it would seem the
>>>> hardware can
>>>> be brought up by the BIOS with the embedded displayport using the SPLL
>>>> for spread spectrum.
>>>>
>>>> Right now this is not handled well in i915, and it calculates the crtc
>>>> needs to
>>>> be reprogrammed on the first modeset without SSC, but the SPLL itself
>>>> was kept
>>>> active. Fix this by exposing SPLL as a shared pll that will not be
>>>> returned
>>>> by intel_get_shared_dpll; you have to know it exists to use it.
>>>>
>>>> Changes since v1:
>>>> - Create a separate dpll_hw_state.spll for spll, and use
>>>> separate pll functions for spll.
>>>>
>>>> Tested-by: Emil Renner Berthing <kernel@esmil.dk> #v1
>>>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>>> ---
>>>> Emil, can you retest?
>>>
>>>
>>> Gabriel, you too please!
>>
>>
>> I retested it and it's ok.
>
> It works fine for me too. I haven't run the tests yet, but I've run
> the patch applied to v4.3 the last couple of days.
Pushed to drm-intel-fixes, thanks for the patch, review and testing.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-11-18 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 13:42 [PATCH] drm/i915: Consider SPLL as another shared pll, v2 Maarten Lankhorst
2015-11-16 15:53 ` Jani Nikula
2015-11-18 12:31 ` Gabriel Feceoru
2015-11-18 12:38 ` Emil Renner Berthing
2015-11-18 13:16 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io4zcusv.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=gabriel.feceoru@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel@esmil.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox