From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Don't use a define when it's clearer to just put the value
Date: Wed, 27 Aug 2014 13:56:46 +0300 [thread overview]
Message-ID: <87iolejj4h.fsf@intel.com> (raw)
In-Reply-To: <1409135421-5850-1-git-send-email-damien.lespiau@intel.com>
On Wed, 27 Aug 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> Instead of going through hoops, just put the driver author directly as
> DRM_AUTHOR() argument. This will also make it consistent when we add
> Intel to the list.
>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 3 ++-
> drivers/gpu/drm/i915/i915_drv.h | 2 --
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index c4cf1af..f886922 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1707,6 +1707,7 @@ static void __exit i915_exit(void)
> module_init(i915_init);
> module_exit(i915_exit);
>
> -MODULE_AUTHOR(DRIVER_AUTHOR);
> +MODULE_AUTHOR("Tungsten Graphics, Inc.");
> +
> MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 71e36d2..5957db4 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -50,8 +50,6 @@
> /* General customization:
> */
>
> -#define DRIVER_AUTHOR "Tungsten Graphics, Inc."
> -
> #define DRIVER_NAME "i915"
> #define DRIVER_DESC "Intel Graphics"
> #define DRIVER_DATE "20140822"
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2014-08-27 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 10:30 [PATCH 1/2] drm/i915: Don't use a define when it's clearer to just put the value Damien Lespiau
2014-08-27 10:30 ` [PATCH 2/2] drm/i915: Add "Intel Corporation" as module author Damien Lespiau
2014-08-27 10:56 ` Jani Nikula
2014-08-27 11:15 ` Daniel Vetter
2014-08-27 10:56 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iolejj4h.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox