* [PATCH 1/2] drm/i915: Don't use a define when it's clearer to just put the value
@ 2014-08-27 10:30 Damien Lespiau
2014-08-27 10:30 ` [PATCH 2/2] drm/i915: Add "Intel Corporation" as module author Damien Lespiau
2014-08-27 10:56 ` [PATCH 1/2] drm/i915: Don't use a define when it's clearer to just put the value Jani Nikula
0 siblings, 2 replies; 5+ messages in thread
From: Damien Lespiau @ 2014-08-27 10:30 UTC (permalink / raw)
To: intel-gfx
Instead of going through hoops, just put the driver author directly as
DRM_AUTHOR() argument. This will also make it consistent when we add
Intel to the list.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 3 ++-
drivers/gpu/drm/i915/i915_drv.h | 2 --
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index c4cf1af..f886922 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1707,6 +1707,7 @@ static void __exit i915_exit(void)
module_init(i915_init);
module_exit(i915_exit);
-MODULE_AUTHOR(DRIVER_AUTHOR);
+MODULE_AUTHOR("Tungsten Graphics, Inc.");
+
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL and additional rights");
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 71e36d2..5957db4 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -50,8 +50,6 @@
/* General customization:
*/
-#define DRIVER_AUTHOR "Tungsten Graphics, Inc."
-
#define DRIVER_NAME "i915"
#define DRIVER_DESC "Intel Graphics"
#define DRIVER_DATE "20140822"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] drm/i915: Add "Intel Corporation" as module author
2014-08-27 10:30 [PATCH 1/2] drm/i915: Don't use a define when it's clearer to just put the value Damien Lespiau
@ 2014-08-27 10:30 ` Damien Lespiau
2014-08-27 10:56 ` Jani Nikula
2014-08-27 11:15 ` Daniel Vetter
2014-08-27 10:56 ` [PATCH 1/2] drm/i915: Don't use a define when it's clearer to just put the value Jani Nikula
1 sibling, 2 replies; 5+ messages in thread
From: Damien Lespiau @ 2014-08-27 10:30 UTC (permalink / raw)
To: intel-gfx
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index f886922..1d6d9ac 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1708,6 +1708,7 @@ module_init(i915_init);
module_exit(i915_exit);
MODULE_AUTHOR("Tungsten Graphics, Inc.");
+MODULE_AUTHOR("Intel Corporation");
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL and additional rights");
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] drm/i915: Add "Intel Corporation" as module author
2014-08-27 10:30 ` [PATCH 2/2] drm/i915: Add "Intel Corporation" as module author Damien Lespiau
@ 2014-08-27 10:56 ` Jani Nikula
2014-08-27 11:15 ` Daniel Vetter
1 sibling, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2014-08-27 10:56 UTC (permalink / raw)
To: Damien Lespiau, intel-gfx
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
On Wed, 27 Aug 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index f886922..1d6d9ac 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1708,6 +1708,7 @@ module_init(i915_init);
> module_exit(i915_exit);
>
> MODULE_AUTHOR("Tungsten Graphics, Inc.");
> +MODULE_AUTHOR("Intel Corporation");
>
> MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL and additional rights");
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] drm/i915: Add "Intel Corporation" as module author
2014-08-27 10:30 ` [PATCH 2/2] drm/i915: Add "Intel Corporation" as module author Damien Lespiau
2014-08-27 10:56 ` Jani Nikula
@ 2014-08-27 11:15 ` Daniel Vetter
1 sibling, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2014-08-27 11:15 UTC (permalink / raw)
To: Damien Lespiau; +Cc: intel-gfx
On Wed, Aug 27, 2014 at 11:30:21AM +0100, Damien Lespiau wrote:
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index f886922..1d6d9ac 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1708,6 +1708,7 @@ module_init(i915_init);
> module_exit(i915_exit);
>
> MODULE_AUTHOR("Tungsten Graphics, Inc.");
> +MODULE_AUTHOR("Intel Corporation");
It only took us like 5 years or so ... both merged, thanks.
-Daniel
>
> MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL and additional rights");
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] drm/i915: Don't use a define when it's clearer to just put the value
2014-08-27 10:30 [PATCH 1/2] drm/i915: Don't use a define when it's clearer to just put the value Damien Lespiau
2014-08-27 10:30 ` [PATCH 2/2] drm/i915: Add "Intel Corporation" as module author Damien Lespiau
@ 2014-08-27 10:56 ` Jani Nikula
1 sibling, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2014-08-27 10:56 UTC (permalink / raw)
To: Damien Lespiau, intel-gfx
On Wed, 27 Aug 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> Instead of going through hoops, just put the driver author directly as
> DRM_AUTHOR() argument. This will also make it consistent when we add
> Intel to the list.
>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 3 ++-
> drivers/gpu/drm/i915/i915_drv.h | 2 --
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index c4cf1af..f886922 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1707,6 +1707,7 @@ static void __exit i915_exit(void)
> module_init(i915_init);
> module_exit(i915_exit);
>
> -MODULE_AUTHOR(DRIVER_AUTHOR);
> +MODULE_AUTHOR("Tungsten Graphics, Inc.");
> +
> MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 71e36d2..5957db4 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -50,8 +50,6 @@
> /* General customization:
> */
>
> -#define DRIVER_AUTHOR "Tungsten Graphics, Inc."
> -
> #define DRIVER_NAME "i915"
> #define DRIVER_DESC "Intel Graphics"
> #define DRIVER_DATE "20140822"
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-27 11:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-27 10:30 [PATCH 1/2] drm/i915: Don't use a define when it's clearer to just put the value Damien Lespiau
2014-08-27 10:30 ` [PATCH 2/2] drm/i915: Add "Intel Corporation" as module author Damien Lespiau
2014-08-27 10:56 ` Jani Nikula
2014-08-27 11:15 ` Daniel Vetter
2014-08-27 10:56 ` [PATCH 1/2] drm/i915: Don't use a define when it's clearer to just put the value Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox