From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Sanitize the enable_ppgtt
	module	option once
Date: Tue, 29 Apr 2014 16:27:15 +0300
Message-ID: <87iopstgek.fsf@intel.com>
References: <1398765238-24862-1-git-send-email-daniel.vetter@ffwll.ch>
 <20140429104450.GB23841@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id D22A56EA11
 for <intel-gfx@lists.freedesktop.org>; Tue, 29 Apr 2014 06:28:01 -0700 (PDT)
In-Reply-To: <20140429104450.GB23841@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Ben Widawsky <ben@bwidawsk.net>, Alessandro Suardi <alessandro.suardi@gmail.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 29 Apr 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Apr 29, 2014 at 11:53:58AM +0200, Daniel Vetter wrote:
>> Otherwise we'll end up spamming dmesg on every context creation on snb
>> with vt-d enabled. This regression was introduced in
>> 
>> commit 246cbfb5fb9a1ca0997fbb135464c1ff5bb9c549
>> Author: Ben Widawsky <benjamin.widawsky@intel.com>
>> Date:   Fri Dec 6 14:11:14 2013 -0800
>> 
>>     drm/i915: Reorganize intel_enable_ppgtt
>> 
>> As the i915.enable_ppgtt is read-only it cannot be changed after the
>> module is loaded and so we can perform an early sanitization of the
>> values.
>> 
>> v2:
>> - Add comment and pimp commit message (Chris)
>> - Use the param consistently (Jani)
>> 
>> v3:
>> - Fix init sequence on pre-gen6 by moving the sanitize_ppgtt call to
>>   gtt_init. Fixes boot hangs on pre-gen6.
>> - Add a debug output for the sanitize ppgtt mode.
>> 
>> References: https://lkml.org/lkml/2014/4/17/599
>> Rererences: https://bugs.freedesktop.org/show_bug.cgi?id=77916
>> Cc: Alessandro Suardi <alessandro.suardi@gmail.com>
>> Cc: Ben Widawsky <ben@bwidawsk.net>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> I am pretty sure we only call i915_gem_gtt_init() once during driver
> load... So let's try that r-b again.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Pushed to -fixes, thanks for the patch and review.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center