From: Jani Nikula <jani.nikula@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/dp: use sizeof for memset instead of magic value
Date: Fri, 04 Oct 2013 18:28:20 +0300 [thread overview]
Message-ID: <87ioxd5a3v.fsf@intel.com> (raw)
In-Reply-To: <20131004124429.GR31334@phenom.ffwll.local>
On Fri, 04 Oct 2013, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Oct 04, 2013 at 03:08:47PM +0300, Jani Nikula wrote:
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_dp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index 60118da..0ed7717 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -2406,7 +2406,7 @@ static bool
>> intel_dp_reset_link_train(struct intel_dp *intel_dp, uint32_t *DP,
>> uint8_t dp_train_pat)
>> {
>> - memset(intel_dp->train_set, 0, 4);
>> + memset(intel_dp->train_set, 0, sizeof(intel_dp->train_set));
>
> Oh, missed that one in my big review of alloc/memset.
You didn't, I sneaked it in afterwards...
Jani.
> -Daniel
>
>> intel_dp_set_signal_levels(intel_dp, DP);
>> return intel_dp_set_link_train(intel_dp, DP, dp_train_pat);
>> }
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-10-04 15:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 12:08 [PATCH 1/2] drm/i915/dp: use sizeof for memset instead of magic value Jani Nikula
2013-10-04 12:08 ` [PATCH 2/2] drm/i915/dp: update training set in a burst write with training pattern set Jani Nikula
2013-10-04 12:48 ` Ville Syrjälä
2013-10-04 12:44 ` [PATCH 1/2] drm/i915/dp: use sizeof for memset instead of magic value Daniel Vetter
2013-10-04 15:28 ` Jani Nikula [this message]
2013-10-09 9:54 ` Jani Nikula
2013-10-09 10:47 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioxd5a3v.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox